Implement policy in code - execution (6)

This commit migrate all execution policies into code [1].

Like oslo.config, with oslo.policy, we can define all of
default rules in code base and only change some rules
via policy file. Another thing that we should use yaml
format instead of json format.

[1] https://governance.openstack.org/tc/goals/queens/policy-in-code.html
Co-authored-By: Dai Dang-Van <daidv@vn.fujitsu.com>
Closes-Bug: #1723333
Change-Id: I3e1d9f5b61d9f2511190fb810726aeb22912ad7b
This commit is contained in:
Hieu LE 2017-10-13 11:09:39 +07:00 committed by Dai Dang Van
parent 518066b019
commit d2274af9a2
4 changed files with 94 additions and 14 deletions

View File

@ -1,12 +1,6 @@
{
"default": "rule:admin_or_owner",
"executions:create": "rule:admin_or_owner",
"executions:delete": "rule:admin_or_owner",
"executions:get": "rule:admin_or_owner",
"executions:list": "rule:admin_or_owner",
"executions:update": "rule:admin_or_owner",
"members:create": "rule:admin_or_owner",
"members:delete": "rule:admin_or_owner",
"members:get": "rule:admin_or_owner",

View File

@ -19,6 +19,7 @@ from mistral.policies import action_executions
from mistral.policies import base
from mistral.policies import cron_trigger
from mistral.policies import environment
from mistral.policies import execution
def list_rules():
@ -27,5 +28,6 @@ def list_rules():
action_executions.list_rules(),
base.list_rules(),
cron_trigger.list_rules(),
environment.list_rules()
environment.list_rules(),
execution.list_rules()
)

View File

@ -0,0 +1,91 @@
# All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from oslo_policy import policy
from mistral.policies import base
EXECUTIONS = 'executions:%s'
rules = [
policy.DocumentedRuleDefault(
name=EXECUTIONS % 'create',
check_str=base.RULE_ADMIN_OR_OWNER,
description='Create a new execution.',
operations=[
{
'path': '/v2/executions',
'method': 'POST'
}
]
),
policy.DocumentedRuleDefault(
name=EXECUTIONS % 'delete',
check_str=base.RULE_ADMIN_OR_OWNER,
description='Delete the specified execution.',
operations=[
{
'path': '/v2/executions/{execution_id}',
'method': 'DELETE'
}
]
),
policy.DocumentedRuleDefault(
name=EXECUTIONS % 'get',
check_str=base.RULE_ADMIN_OR_OWNER,
description='Return the specified execution.',
operations=[
{
'path': '/v2/executions/{execution_id}',
'method': 'GET'
}
]
),
policy.DocumentedRuleDefault(
name=EXECUTIONS % 'list',
check_str=base.RULE_ADMIN_OR_OWNER,
description='Return all executions.',
operations=[
{
'path': '/v2/executions',
'method': 'GET'
}
]
),
policy.DocumentedRuleDefault(
name=EXECUTIONS % 'list:all_projects',
check_str=base.RULE_ADMIN_ONLY,
description='Return all executions from all projects.',
operations=[
{
'path': '/v2/executions',
'method': 'GET'
}
]
),
policy.DocumentedRuleDefault(
name=EXECUTIONS % 'update',
check_str=base.RULE_ADMIN_OR_OWNER,
description='Update an execution.',
operations=[
{
'path': '/v2/executions',
'method': 'PUT'
}
]
)
]
def list_rules():
return rules

View File

@ -15,13 +15,6 @@
policy_data = """{
"default": "rule:admin_or_owner",
"executions:create": "rule:admin_or_owner",
"executions:delete": "rule:admin_or_owner",
"executions:get": "rule:admin_or_owner",
"executions:list": "rule:admin_or_owner",
"executions:list:all_projects": "rule:admin_only",
"executions:update": "rule:admin_or_owner",
"members:create": "rule:admin_or_owner",
"members:delete": "rule:admin_or_owner",
"members:get": "rule:admin_or_owner",