openstack
/
monasca-analytics
Code Issues Proposed changes

Change assertTrue(isinstance()) by optimal assert 

Some of tests use different method of
assertTrue(isinstance(A, B)) or assertEqual(type(A), B).
The correct way is to use assertIsInstance(A, B) provided
by testtools

Change-Id: I127045563897bccf77b2ba5a8975b2d7706ec3f6
This commit is contained in:
gecong1973 2016-10-08 09:22:03 +08:00
parent 92c0f6eeec
commit 9ee464db89
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/sml/test_svm_one_class.py
View File

@ -53,4 +53,4 @@ class TestSvmOneClass(MonanasTestCase):
def test_learn_structure(self):
data = self.get_testing_data()
clf = self.svm.learn_structure(data)
self.assertTrue(isinstance(clf, svm.OneClassSVM))
self.assertIsInstance(clf, svm.OneClassSVM)