openstack
/
monasca-api
Code Issues Proposed changes

Convert type to uppercase in command setters 

This is because currently we do not so they can be lowercase
or mixed case once they get to the validation call which then
will not look at the email or webhook addresses

Change-Id: I99cc704d33956d8709ac40f7fbc69496bafe90d7
This commit is contained in:
Michael James Hoppal 2016-08-10 16:33:31 -06:00
parent fa5da0035b
commit 834b2cc440
3 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
java/src/main/java/monasca/api/app/command/CreateNotificationMethodCommand.java
View File

@ -89,6 +89,10 @@ public class CreateNotificationMethodCommand {
this.convertedPeriod = Validation.parseAndValidateNumber(period, "period");
}
public void setType(String type){
this.type = type == null ? null : type.toUpperCase();
}
public int getConvertedPeriod(){
return this.convertedPeriod;
}

4
java/src/main/java/monasca/api/app/command/PatchNotificationMethodCommand.java
View File

@ -83,6 +83,10 @@ public class PatchNotificationMethodCommand {
this.convertedPeriod = period;
}
public void setType(String type){
this.type = type == null ? null : type.toUpperCase();
}
public int getConvertedPeriod(){
return this.convertedPeriod;
}

4
java/src/main/java/monasca/api/app/command/UpdateNotificationMethodCommand.java
View File

@ -88,6 +88,10 @@ public class UpdateNotificationMethodCommand {
this.convertedPeriod = Validation.parseAndValidateNumber(period, "period");
}
public void setType(String type){
this.type = type == null ? null : type.toUpperCase();
}
public int getConvertedPeriod(){
return this.convertedPeriod;
}