The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.
Fix problems found by updated hacking version.
Remove hacking and friends from lower-constraints, they are not needed
there at all.
Align lower-constraints for new pip [1]
Fix flake8 E305 and E117 and set W504 as ignored
[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019285.html
Change-Id: Idae87291f4556eee77d40ab49f0d151435d70875
Additionally, temporarily set build-monasca-docker-image as non-voting
due to problems with buggy confluent-kafka 1.4.0 release, which prevents
building the Docker image.
Change-Id: I561ea633a09eb3d7468d2d55aa46d6fb3b2380ff
Story: 2007549
Task: 39390
The Jira module is now available in global-requirements:
https://review.openstack.org/#/c/562151/
Since the Jira module is now loaded by default, it always
needs to be installed. If a future change prevents loading
of the Jira module unless the Jira plugin is enabled then
this change can be reverted.
Change-Id: I3fea82e681cd49aab5cd6afc29c60302af7b63b7
Story: 2005400
Task: 30394
* Set max line length to 100
* Clean up code for pep8 checks
Change-Id: Ie00dc204f522fb2112f02f4151ec8a15d5523459
Signed-off-by: Jui Chandwaskar <jchandwaskar@op5.com>
Change upgrades the monasca-notification to leverage
the capabilities of both oslo.log and oslo.conf:
- configuration of logging separated from application settings
- ability to enforce data types for application settings
- ability to use oslo.config-generator capabilities
- automatic configuration parsing done by oslo.cfg
That change will bring it closer to the rest of monasca
components where such transition has happened already.
However, in the rest of monasca, oslo.cfg was partially
or fully implemented whereas monasca-notification has
been relying on YAML based configuration file.
Therefore backward compatybility for such format will
be kept for now.
Story: 2000959
Task: 4093
Task: 4092
Change-Id: Ia75c3b60d0fada854178f21ca5ccb9e6a880f37f
Python3.5 tests were not running because Python3 has not
Queue module (instead have queue module). Commit
does not fix failing tests but gives an insight in what
exactly is failing and allows to fix them in future.
Also applied sixer utility to fix common Py2-Py3 compatybility
issues.
Additionally:
* removed unconstrained mysql and psycopg drivers from tox.ini.
Instead added them to test-requirements to be picked up
by requirements bot. That also allowed to remove 3 tox
environments.
* added removing .testrepository/times.dbm (may cause py3 environment
to fail if present)
Change-Id: I9bcc33dad80fdfbf60d95c4bb0ce7f79f642a414
Avoid dangerous file parsing and object serialization libraries.
yaml.load is the obvious function to use but it is dangerous[1]
Because yaml.load return Python object may be dangerous if you
receive a YAML document from an untrusted source such as the Internet.
The function yaml.safe_load limits this ability to simple Python
objects like integers or lists.
In addition, Bandit flags yaml.load() as security risk so replace
all occurrences with yaml.safe_load(). Thus I replace yaml.load()
with yaml.safe_load()
[1] https://security.openstack.org/guidelines/dg_avoid-dangerous-input-parsing-libraries.html
Change-Id: I3f1a756e80b617ba1bcf824ef4dee9a27eb6887a
Closes-Bug: #1634265
When an exception was caught and rethrown, it should
call 'raise' without any arguments because it shows
the place where an exception occured initially instead
of place where the exception re-raised
Change-Id: I3667715dc1bb4d8d56ad7a8c660c61fa676cdf9f
Martin Chacon Piza