This patch update browser from Chrome to Firefox
in karma.conf.js because nodejs fails with Chrome
browser as not able to access some URL.
So let's switch to Firefox browser now then we can
use Chrome browser in future once this issue is resolved.
It also bump few pacakges version in 'lower-constraints.txt'
to fix lower-constraint job.
Change-Id: Id8454b0b0f7dc4b257699734f779935fb05b512f
Currently, murano-dashboard has
"devDependencies": {
"eslint": "^0.23.0",
"eslint-config-openstack": "1.2.0"
}
while horizon has switched to more recent and stable options of:
"eslint": "1.2.1",
"eslint-config-openstack": "1.2.3"
This updates the devDependencies in Murano dashboard to
mirror those of horizon.
Change-Id: I56b93cfba2d69319ca4d4a5f1b5983009b302168
Closes-Bug: #1524552
Since openstack-config for eslint is now published on npm we should use
it as basis for our linting rules. It is actually stricter, than our
current semi-default config as it enables some of the previously
unchecked rules.
Partially implements: blueprint add-js-lint-jobs
Change-Id: I0cb8247167a44f30a657693442f99a87f116350a
This commit adds a eslint tox environment, that installs eslint and
checks muranodashboard js code against it.
Eslint is the current linter of choice for horizon, because it is
capable of detecting both style and syntax errors (and does not have
license limitations of jshint).
To run: tox -e eslint
Partially implements: blueprint add-js-lint-jobs
Change-Id: I645f279ab6ac45b7d1d872ded803c126dd0a10e7
manchandavishal