summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Alvarez <dalvarez@redhat.com>2018-12-26 19:55:40 +0100
committerDaniel Alvarez <dalvarez@redhat.com>2018-12-26 19:55:51 +0100
commit649c7d7af9a23da46b44db344ad16b1b186ef3ca (patch)
treeb9e72bc762a2c7ad6795cf0ea81e84433e3a668c
parent357c028b17eb5901c1c33c1d87100a93e3e31d31 (diff)
functional: Do not inherit from SqlTestCaseLight
Inheriting from SqlTestCaseLight in some tests and from SqlTestCase in some others at the same time may cause errors in functional tests. According to comments in SqlTestCaseLight implementation in Neutron, that's intended for unit tests only. This patch is changing it so that all tests inherit from the same Sql Base class. For a long time, we've been hitting failures in gate due to race conditions in functional tests caused by this issue. Change-Id: Id9c917f604024f6c82b1ff638ba58bce1f2b306b Closes-Bug: #1808146 Signed-off-by: Daniel Alvarez <dalvarez@redhat.com>
Notes
Notes (review): Code-Review+2: Daniel Alvarez <dalvarez@redhat.com> Workflow+1: Daniel Alvarez <dalvarez@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 27 Dec 2018 11:39:30 +0000 Reviewed-on: https://review.openstack.org/627191 Project: openstack/networking-ovn Branch: refs/heads/master
-rw-r--r--networking_ovn/tests/functional/db/test_migrations.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/networking_ovn/tests/functional/db/test_migrations.py b/networking_ovn/tests/functional/db/test_migrations.py
index d532a19..ea864af 100644
--- a/networking_ovn/tests/functional/db/test_migrations.py
+++ b/networking_ovn/tests/functional/db/test_migrations.py
@@ -54,11 +54,11 @@ class _TestModelsMigrationsOVN(test_migrations._TestModelsMigrations):
54 54
55class TestModelsMigrationsMysql(testlib_api.MySQLTestCaseMixin, 55class TestModelsMigrationsMysql(testlib_api.MySQLTestCaseMixin,
56 _TestModelsMigrationsOVN, 56 _TestModelsMigrationsOVN,
57 testlib_api.SqlTestCaseLight): 57 testlib_api.SqlTestCase):
58 pass 58 pass
59 59
60 60
61class TestModelsMigrationsPostgresql(testlib_api.PostgreSQLTestCaseMixin, 61class TestModelsMigrationsPostgresql(testlib_api.PostgreSQLTestCaseMixin,
62 _TestModelsMigrationsOVN, 62 _TestModelsMigrationsOVN,
63 testlib_api.SqlTestCaseLight): 63 testlib_api.SqlTestCase):
64 pass 64 pass