summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
5 hoursMerge "Change TripleO job to run against scenario 3"HEADmasterZuul
20 hoursMerge "Improve error handling for ChassisMetadataAgentEvent"Zuul
24 hoursMerge "Add 'unknown' to the address list if the port's port security is ↵Zuul
disabled"
28 hoursMerge "Fix unbound "mac" variable"Zuul
31 hoursChange TripleO job to run against scenario 3Daniel Alvarez
After the switch in TripleO to ML2/OVN [0], scenario007 was flipped to ML2/OVS so we'll gate against scenario 3 from now on. [0] https://review.openstack.org/593056 Signed-off-by: Daniel Alvarez <dalvarez@redhat.com> Co-Authored-By: Jakub Libosvar <jlibosva@redhat.com> Change-Id: I0a072ae9fda97a01cb6466288061660a7ad28995 Notes (review): Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Code-Review+1: Kamil Sambor <ksambor@redhat.com> Code-Review+2: Numan Siddique <nusiddiq@redhat.com> Workflow+1: Numan Siddique <nusiddiq@redhat.com> Code-Review+2: Miguel Angel Ajo <mangelajo@redhat.com> Code-Review+1: Jakub Libosvar <libosvar@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 21 Feb 2019 11:47:05 +0000 Reviewed-on: https://review.openstack.org/637561 Project: openstack/networking-ovn Branch: refs/heads/master
31 hoursAdd 'unknown' to the address list if the port's port security is disabledNuman Siddique
When a port's port security is disabled then the port should be allowed to use any mac address. And for this to work, OVN expects 'unknown' address to be added into the Logical_Switch_Port.addresses column. This patch adds this 'unknown' address if the port security is disabled. Change-Id: I5f25f4d4b2acccada3ab2944e9cfd2461149ef3e Closes-bug: #1815270 Co-Authored-By: Lucas Alvares Gomes <lucasagomes@gmail.com> Notes (review): Code-Review+2: Daniel Alvarez <dalvarez@redhat.com> Code-Review+1: Numan Siddique <nusiddiq@redhat.com> Workflow+1: Lucas Alvares Gomes <lucasagomes@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 20 Feb 2019 16:39:50 +0000 Reviewed-on: https://review.openstack.org/636011 Project: openstack/networking-ovn Branch: refs/heads/master
2 daysFix unbound "mac" variableDaniel Alvarez
There's a DEBUG trace which is using a non existent variable in that scope and that caused a failure when DEBUG level was enabled. Closes-Bug: #1816031 Change-Id: I6c77623bd199bcbb3f4ad46a7fee3b2fac325790 Signed-off-by: Daniel Alvarez <dalvarez@redhat.com> Co-Authored-By: Lucas Alvares Gomes <lucasagomes@gmail.com> Notes (review): Code-Review+2: Daniel Alvarez <dalvarez@redhat.com> Code-Review+2: Miguel Angel Ajo <mangelajo@redhat.com> Workflow+1: Miguel Angel Ajo <mangelajo@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 20 Feb 2019 12:45:40 +0000 Reviewed-on: https://review.openstack.org/637172 Project: openstack/networking-ovn Branch: refs/heads/master
2 daysMerge "Maintenance: Re-create the metadata port"Zuul
3 daysImprove error handling for ChassisMetadataAgentEventLucas Alvares Gomes
The ChassisMetadataAgentEvent class is suppose to handle events which are triggered when a Chassis entry is created or updated in the OVSDB. Prior to this patch, it was assumed that the external_ids column of that entry would contain the "neutron:ovn-metadata-sb-cfg" key in it which is not always true. This patch is fixing the problem by handling the case which that key is not yet present in the Chassis external_ids column. The patch also prevent the ChassisMetadataAgentEvent from running by not adding it to the list of events to watch in case the OVN metadata is not enabled. Change-Id: Ie7f348a70a6f0c67f1822f73e0c559eac46b18bb Closes-Bug: #1816033 Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com> Notes (review): Code-Review+2: Terry Wilson <twilson@redhat.com> Code-Review+2: Daniel Alvarez <dalvarez@redhat.com> Workflow+1: Daniel Alvarez <dalvarez@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 20 Feb 2019 21:01:34 +0000 Reviewed-on: https://review.openstack.org/637175 Project: openstack/networking-ovn Branch: refs/heads/master
4 daysMaintenance: Re-create the metadata portLucas Alvares Gomes
This patch adds a new task to the maintenance thread which re-creates the metadata port in case it's been wrongly deleted (by whatever reasons). The task will run immediately at service restart and fix those ports, just like ml2/ovs would do with the DHCP ports. Closes-Bug: #1813939 Change-Id: I0819c2b956dd41c8fe59a2b1b4fec9d229afb067 Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com> Notes (review): Code-Review+2: Terry Wilson <twilson@redhat.com> Code-Review+2: Daniel Alvarez <dalvarez@redhat.com> Workflow+1: Daniel Alvarez <dalvarez@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 19 Feb 2019 12:33:18 +0000 Reviewed-on: https://review.openstack.org/636312 Project: openstack/networking-ovn Branch: refs/heads/master
5 daysMerge "Refactor Devstack Plugin for OVN Octavia Provider Driver"Zuul
6 daysMerge "Migrate from Octavia to Octavia-Lib"Zuul
6 daysMerge "Add extra validation and update the migration guide"Zuul
6 daysRefactor Devstack Plugin for OVN Octavia Provider DriverReedip
This patch refactors the devstack plugin by dropping implemented devstack modes and phases with regard to Octavia. Networking-ovn's devstack plugin should not handle nor call out functions responsible for installing and configuring Octavia. Change-Id: I0eb931892406cfd4a6c24f8e22718a6caf1c08b2 Notes (review): Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Code-Review+2: Daniel Alvarez <dalvarez@redhat.com> Workflow+1: Daniel Alvarez <dalvarez@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 16 Feb 2019 14:06:54 +0000 Reviewed-on: https://review.openstack.org/636582 Project: openstack/networking-ovn Branch: refs/heads/master
8 daysMigrate from Octavia to Octavia-LibReedip
This patch migrates from octavia to octavia-lib Change-Id: I9542669c1f7f16c6ce8a7a10afcbf7f563f35919 Notes (review): Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Code-Review+2: Daniel Alvarez <dalvarez@redhat.com> Workflow+1: Daniel Alvarez <dalvarez@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 15 Feb 2019 21:16:51 +0000 Reviewed-on: https://review.openstack.org/636564 Project: openstack/networking-ovn Branch: refs/heads/master
9 daysMerge "Make networking-ovn-migration-mtu output less confusing"Zuul
9 daysMerge "stop using common db mixin"Zuul
9 daysMerge "Target proper Chassis events for agent liveness"Zuul
9 daysMerge "Fix instances of events as strings instead of tuples"Zuul
9 daysMake networking-ovn-migration-mtu output less confusingMiguel Angel Ajo
When called fron ovn_migration.sh the output seems confusing and makes it look like the admin still has to go and do something on the command line, while in fact ovn_migration.sh will handle it. Closes-Bug: 1814824 Change-Id: I549e23135ead0332e4e92c1044d20f64e20d1106 Notes (review): Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Code-Review+2: Daniel Alvarez <dalvarez@redhat.com> Workflow+1: Daniel Alvarez <dalvarez@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 12 Feb 2019 23:10:40 +0000 Reviewed-on: https://review.openstack.org/635042 Project: openstack/networking-ovn Branch: refs/heads/master
9 daysAdd extra validation and update the migration guideMiguel Angel Ajo
After the last call to tripleo's overcloud deploy to ensure tripleo knows about "br-int" and not "br-migration" run an extra round of validation. Update the migration guide with such detail and also extend the details of what's happening under the hood since administrators need to know. Change-Id: I6c9d2537c0d04b46fae3340f522ab660c56d3c1e Notes (review): Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Code-Review+2: Daniel Alvarez <dalvarez@redhat.com> Code-Review+1: Reedip <rbanerje@redhat.com> Code-Review+2: Terry Wilson <twilson@redhat.com> Workflow+1: Terry Wilson <twilson@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 15 Feb 2019 17:28:18 +0000 Reviewed-on: https://review.openstack.org/619624 Project: openstack/networking-ovn Branch: refs/heads/master
10 daysstop using common db mixinBoden R
All of the methods of common db mixin are available via neutron-lib and the mixin will be removed before long. This patch switches the code over to use neutron-lib's APIs rather than those of the mixin as well as top using the mixin as a parent class. Change-Id: I08ced959d27e09c8483cc9c793c1ecff26bb8d36 Notes (review): Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Workflow+1: Lucas Alvares Gomes <lucasagomes@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 12 Feb 2019 18:08:21 +0000 Reviewed-on: https://review.openstack.org/636164 Project: openstack/networking-ovn Branch: refs/heads/master
13 daysMerge "ovn-metadata-agent: bind haproxy to 169.254.169.254"Zuul
2019-02-07Fix instances of events as strings instead of tuplesTerry Wilson
Although it technically works because the match use 'in' and events are non-overlapping strings, the clear intent is for these to be tuples and (x) is not a tuple, while (x,) is. Change-Id: I316215d33a47a34839114fd41401f7c701c4ff21 Notes (review): Code-Review+2: Daniel Alvarez <dalvarez@redhat.com> Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Workflow+1: Lucas Alvares Gomes <lucasagomes@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 12 Feb 2019 12:01:03 +0000 Reviewed-on: https://review.openstack.org/635572 Project: openstack/networking-ovn Branch: refs/heads/master
2019-02-07Target proper Chassis events for agent livenessTerry Wilson
Agent stats for the ovn-controller are updated any time there is any CREATE/UPDATE event happens on a Chassis. This includes things like external_ids updates for metadata agent liveness. So as long as the metadata agent is running, ovn-controller agent shows up as 'alive'. This patch makes sure we only update the ovn-controller agent status when nb_cfg is incremented. Change-Id: I44c616b94031d611e43c58c32894ae9d54662bcd Closes-Bug: #1814975 Notes (review): Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Code-Review+2: Daniel Alvarez <dalvarez@redhat.com> Workflow+1: Daniel Alvarez <dalvarez@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 12 Feb 2019 18:08:20 +0000 Reviewed-on: https://review.openstack.org/635354 Project: openstack/networking-ovn Branch: refs/heads/master
2019-02-07Merge "Make ovn_migration.sh generate-inventory reference the right next step"Zuul
2019-02-07Merge "Fix ovn-extras.yaml check on ovn_migration.sh"Zuul
2019-02-07Merge "Fix downtime bug during migration"Zuul
2019-02-07Merge "Disable oooq jobs on migration or other irrelevant"Zuul
2019-02-07Merge "Remove only non-alive agents during migration"Zuul
2019-02-06Fix ovn-extras.yaml check on ovn_migration.shMiguel Angel Ajo
Change-Id: I26131fa898cb1bf7ef105166d5e696e3c944ff64 Closes-Bug: 1814820 Notes (review): Code-Review+2: Numan Siddique <nusiddiq@redhat.com> Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Workflow+1: Lucas Alvares Gomes <lucasagomes@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 07 Feb 2019 13:52:06 +0000 Reviewed-on: https://review.openstack.org/635037 Project: openstack/networking-ovn Branch: refs/heads/master
2019-02-06Merge "Make sure all mapped bridges are properly cleaned up"Zuul
2019-02-06Merge "remove noqa use of neutron.db.api"Zuul
2019-02-05Fix downtime bug during migrationMiguel Angel Ajo
We remove a workaround which was applied because of [1], which now it's fixed in openvswitch. The problem is that the workaround introduced unnecessary downtime. Change-Id: I20a17896bc911b59ad85eefa9c76c41c058a0c16 Closes-Bug: 1814831 Notes (review): Code-Review+2: Numan Siddique <nusiddiq@redhat.com> Code-Review+2: Daniel Alvarez <dalvarez@redhat.com> Workflow+1: Daniel Alvarez <dalvarez@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 07 Feb 2019 13:52:06 +0000 Reviewed-on: https://review.openstack.org/635063 Project: openstack/networking-ovn Branch: refs/heads/master
2019-02-05Make ovn_migration.sh generate-inventory reference the right next stepMiguel Angel Ajo
Otherwise the admin could skip a step. Change-Id: I9cd6031f88c064dba457d033aa072b6ed918840d Closes-Bug: 1814826 Notes (review): Code-Review+2: Numan Siddique <nusiddiq@redhat.com> Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Workflow+1: Lucas Alvares Gomes <lucasagomes@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 07 Feb 2019 16:09:08 +0000 Reviewed-on: https://review.openstack.org/635048 Project: openstack/networking-ovn Branch: refs/heads/master
2019-02-05Disable oooq jobs on migration or other irrelevantMiguel Angel Ajo
The purpose of this change is to save CI resources and time. Change-Id: I514100c81b8c5d5ccb451417349a7a17ae66aa3d Notes (review): Code-Review+2: Daniel Alvarez <dalvarez@redhat.com> Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Workflow+1: Lucas Alvares Gomes <lucasagomes@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 07 Feb 2019 13:20:21 +0000 Reviewed-on: https://review.openstack.org/635029 Project: openstack/networking-ovn Branch: refs/heads/master
2019-02-05Make sure all mapped bridges are properly cleaned upMiguel Angel Ajo
We need to configure them in standalone mode (to let traffic going around in the absence of controller), and clean up the controller. Change-Id: If9ecf21ec178a1e73eda5684a6b41ded8e3db8b3 Closes-Bug: 1814817 Notes (review): Code-Review+2: Numan Siddique <nusiddiq@redhat.com> Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Workflow+1: Lucas Alvares Gomes <lucasagomes@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 06 Feb 2019 13:05:31 +0000 Reviewed-on: https://review.openstack.org/635024 Project: openstack/networking-ovn Branch: refs/heads/master
2019-02-05Remove only non-alive agents during migrationMiguel Angel Ajo
During the migration process we were cleaning up all ml2/ovs neutron agents, but, in some cases we still rely on the neutron-dhcp-agents, and we need to avoid cleaning those up. Change-Id: I6064bb207e27928f29d39773b30d98a2345efd43 Closes-bug: 1814812 Notes (review): Code-Review+2: Numan Siddique <nusiddiq@redhat.com> Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Workflow+1: Lucas Alvares Gomes <lucasagomes@gmail.com> Code-Review+2: Daniel Alvarez <dalvarez@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 07 Feb 2019 12:17:29 +0000 Reviewed-on: https://review.openstack.org/635022 Project: openstack/networking-ovn Branch: refs/heads/master
2019-02-05ovn-metadata-agent: bind haproxy to 169.254.169.254Daniel Alvarez
Currently ovn-metadata-agent spawns haproxy to bind in 0.0.0.0 inside the ovnmeta namespace. This is not needed as we know that we'll always receive those in 169.254.169.254 and it can have security issues. Closes-Bug: #1745618 Signed-off-by: Daniel Alvarez <dalvarez@redhat.com> Change-Id: I19ba651ad5b120ecb9859d9f7786b447f3218078 Notes (review): Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Code-Review+1: Brian Haley <haleyb.dev@gmail.com> Code-Review+2: Terry Wilson <twilson@redhat.com> Workflow+1: Terry Wilson <twilson@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 08 Feb 2019 10:45:41 +0000 Reviewed-on: https://review.openstack.org/634947 Project: openstack/networking-ovn Branch: refs/heads/master
2019-02-05metadata-agent: Remove 'ovs_integration_bridge' optionDaniel Alvarez
This option is no longer used as the source of truth for the OVS bridge to be used by metadata agent will be OVSDB configuration so we can simply drop it. For more information please take a look at https://launchpad.net/bugs/1799216. Change-Id: Ic8e377c7a3462c006bb645f0bbd0147b684c2998 Signed-off-by: Daniel Alvarez <dalvarez@redhat.com> Notes (review): Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Code-Review+2: Numan Siddique <nusiddiq@redhat.com> Code-Review+1: Reedip <rbanerje@redhat.com> Code-Review+1: Terry Wilson <twilson@redhat.com> Workflow+1: Daniel Alvarez <dalvarez@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 05 Feb 2019 16:32:28 +0000 Reviewed-on: https://review.openstack.org/618767 Project: openstack/networking-ovn Branch: refs/heads/master
2019-02-04Merge "TrivialFix : Verify Listener Protocol"Zuul
2019-02-01Merge "Do not waste CI resources on changes to migration/*"Zuul
2019-01-31Merge "Add IPv6 default route to OVN Logical Router"Zuul
2019-01-30Revert "Switch to stestr"Lucas Alvares Gomes
Turns out the functional tests with python3.5 started to fail due to this change. We will need to investigate it better prior to going ahead with switching to stestr, unfortunately. This reverts commit b713ad36fb00fba93cb943e879674c61d6b71491. Change-Id: I2da1c9fd3294dc4abba95ea31a8f92bdd8f50a8a Notes (review): Code-Review+2: Daniel Alvarez <dalvarez@redhat.com> Workflow+1: Daniel Alvarez <dalvarez@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 31 Jan 2019 12:41:59 +0000 Reviewed-on: https://review.openstack.org/633917 Project: openstack/networking-ovn Branch: refs/heads/master
2019-01-28Merge "Switch to stestr"Zuul
2019-01-28Merge "TrivialFix: Fix wrong config option in docs"Zuul
2019-01-28Merge "CI: Remove ovsdbapp-src tempest job definition"Zuul
2019-01-28Merge "Fix missing print format error"Zuul
2019-01-28TrivialFix: Fix wrong config option in docsDaniel Alvarez
This patch is fixing the doc by correcting the right parameter for enabling DVR as 'enable_distributed_floating_ip'. TrivialFix Change-Id: Iba817e73c84dd94966ccfe530c364cf5976a988a Signed-off-by: Daniel Alvarez <dalvarez@redhat.com> Notes (review): Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Workflow+1: Lucas Alvares Gomes <lucasagomes@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 28 Jan 2019 18:31:12 +0000 Reviewed-on: https://review.openstack.org/633543 Project: openstack/networking-ovn Branch: refs/heads/master
2019-01-28remove noqa use of neutron.db.apiBoden R
With the rehoming of [1] there should no longer be a need to import neutron.db.api as per the bug mentioned in [1]. This patch removes the noqa import of that module and bumps the min version of neutron-lib up to 1.22.0 [1] https://review.openstack.org/#/c/625332/ Change-Id: I09e582d4ffb26d91357fb644cf39750846aaa89d Notes (review): Code-Review+2: YAMAMOTO Takashi <yamamoto@midokura.com> Code-Review+2: Lucas Alvares Gomes <lucasagomes@gmail.com> Workflow+1: Lucas Alvares Gomes <lucasagomes@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 06 Feb 2019 02:19:02 +0000 Reviewed-on: https://review.openstack.org/633284 Project: openstack/networking-ovn Branch: refs/heads/master