tox now always recreates an env although the env is shared using envdir
options.
~~~
$ tox -e genpolicy
genpolicy: recreate env because env type changed from
{'name': 'genconfig', 'type': 'VirtualEnvRunner'} to
{'name': 'genpolicy', 'type': 'VirtualEnvRunner'}
~~~
According to the maintainer of tox, this functionality is not intended
to be supported.
https://github.com/tox-dev/tox/issues/425#issuecomment-1011944293
Change-Id: I6b87ff7ad426b6a872286eb18a97885863cc6ce1
UPPER_CONSTRAINTS_FILE is old name and deprecated
This allows to use upper-constraints file as more
readable way instead of UPPER_CONSTRAINTS_FILE=<lower-constraints file>.
Change-Id: I802a996bac02b30c46d71ba998bcf0c2961612dc
We need to specify doc requirements in doc/requirements.txt
to avoid problems with the pip resolver for the release team.
Removed specific doc requirements from test-requirements.txt
Change-Id: I2d3a6e6bb0db372565458ea5eed4d84efdef37d2
This repo has been using the outdated pbr sphinx integration and thus
Ic5d22bbc3d1ece72a7611e023d54d456f6f1a211 broke docs publishing.
Use the new way of docs building everywhere with running sphinx-build to
fix docs publishing.
Change-Id: I839369ed9f61262d6f715ebaa491201218ff2d91
Commit I94a443c92fe2317ba2591ae3a227ec8df82ec294 removed the tempest
tests from this project.
This commit remove some leftover pathes to the tempest tests.
Change-Id: Ifd48004e26beedd92231ee730aa897ceb2945d84
Note that toctree_only option [1] is set to True in latex_documents
in doc/source/conf.py to get a better document structure in
the generated PDF file.
The above solution also helps us avoid a filename conflict between
the generated PDF file name and a PDF file converted from an SVG image
of the project badge where both files would be neutron-dynamic-routing.pdf.
Change-Id: I809040e0a4def90451f9a80c02c6f811af330bc9
Story: 2006099
Task: 35128
This change ensures all CI jobs run against neutron-dynamic-routing
run with python 3 and all test code is compatible with python 3.
Change-Id: I77f940dca9239d710bb146e8cdf1d6058f2fbdd4
All of the methods of common db mixin are available via neutron-lib
and the mixin will be removed before long.
This patch switches the code over to use neutron-lib's APIs rather
than those of the mixin.
This commit also includes the following unrelated change
to pass the gate.
----------------------------------------
tox.ini: Remove symbolic links to fix issues in py3 jobs
2019-02-11 21:38:47.092425 | ubuntu-xenial | py35 runtests: commands[1] | find . -type d -name __pycache__ -delete
2019-02-11 21:38:47.093110 | ubuntu-xenial | setting PATH=/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/py35/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
2019-02-11 21:38:47.097926 | ubuntu-xenial | /home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing$ /usr/bin/find . -type d -name __pycache__ -delete
2019-02-11 21:38:47.101454 | ubuntu-xenial | /usr/bin/find: cannot delete ‘./.tox/py35/lib/python3.5/plat-x86_64-linux-gnu/__pycache__’: Directory not empty
2019-02-11 21:38:47.101813 | ubuntu-xenial | /usr/bin/find: cannot delete ‘./.tox/py35/lib/python3.5/collections/__pycache__’: Directory not empty
2019-02-11 21:38:47.102118 | ubuntu-xenial | /usr/bin/find: cannot delete ‘./.tox/py35/lib/python3.5/encodings/__pycache__’: Directory not empty
2019-02-11 21:38:47.304506 | ubuntu-xenial | /usr/bin/find: cannot delete ‘./.tox/py35/lib/python3.5/importlib/__pycache__’: Directory not empty
2019-02-11 21:38:47.309574 | ubuntu-xenial | ERROR: InvocationError for command '/usr/bin/find . -type d -name __pycache__ -delete' (exited with code 1)
----------------------------------------
Change-Id: If4fa99d98e9507d9fefa84cd39d7d1d3381801a0
We recently removed nenutron.common.rpc [1] as the rpc module lives in
neutron-lib now. This project was missed because I didn't find
neutron.common.rpc as an import. This patch switches rpc uses over to
neutron-lib.
This also addresses an issue where toxenv fails when it encounters a
non-empty __pycache__ directory. This adjusts the options passed to
find so that it is tolerant of this scenario and allows tox runs to
proceed.
[1] https://review.openstack.org/#/c/634790/
Change-Id: Ice83f7574f146436e3db045693b530f0cfeda049
This commit converts the existing neutron-dynamic-routing policy.json
into policy-in-code.
Partially Implements: blueprint neutron-policy-in-code
Change-Id: I4f99739ca8b979ddf69c52c3f1b36e320326db8d
This patch adds local tox targets for pep8 and python 3 as per [1]
that will install dependencies in editable mode.
To run them use the pep8-dev and py3-dev targets respectively.
[1] https://etherpad.openstack.org/p/neutron-sibling-setup
Change-Id: Id6e30be7b063e3ae42590068d4a25b7c563d67a3
The commands used by constraints need at least tox 2.0. Update to
reflect reality, which should help with local running of constraints
targets.
Change-Id: I1d2d013695d783cee0ea3e8caf69a71da6a9028c
Closes-Bug: #1801465
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: I383a87c917dcdf9469d57b55ab2630420e3ac87c
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
According to Openstack summit session [1] stestr is
maintained project to which all Openstack projects
should migrate.
Let's switch it then.
[1] https://etherpad.openstack.org/p/YVR-python-pti
Change-Id: I9fd237292f7da50e60da398b1649001bf1829c66
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
Change-Id: I4d6fc19a8f7983ddb5c02f03cc6bc59fe4fa5b1a
Depends-On: https://review.openstack.org/555034
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Instead of using tox-install.sh, we can install horizon and neutron
now directly from pypi - or use the current branch in CI system using
tox-siblings.
Update tox.ini for this change and add neutron to requirements file.
Change-Id: Ifb0890e6d287dc24a654ac47d23cd9e1d7fb830d
Some of the available checks are disabled by default, like:
[H106] Don’t put vim configuration in source files
[H203] Use assertIs(Not)None to check for None
Change-Id: I553460a231ee27b63220c1540b39fd213e79e032
This will, among other things, guarantee to us that if all tests are
skipped, the targets will actually fail instead of silently succeeding.
The only target that can't switch to ostestr is cover, but that's ok
because it's effectively duplicated by other unit test jobs to guarantee
that it runs some tests.
Change-Id: I837c2d9d76f0d48a949106bf12bb91ab2c041fa3
Related-Bug: #1683249
This makes tox use the latest version of the tool from os-testr repo,
which contains some valuable changes, like the one making the gate fail
if for some reason no tests are executed because all of them are
skipped.
Change-Id: If88be4b310d746ccc885e3d0c1db8a4dfabb2a28
Once a new neutron-lib release will be cut off, the new hacking check
will break the pep8 target because the code still uses translation
markers for log messages.
Instead of fixing all remaining log messages and hoping no new messages
land before neutron-lib release, we temporarily disable the check; we
will reenable it back once we have a neutron-lib release in gate that we
can validate the patch removing translation markers against.
Change-Id: Icef59a03184473476e0657334bcc30dc7bf4f9ff
A recent hacking check landed in neutron broke the pep8 target for the
repo. Using hacking checks from neutron is error prone.
This patch switches the repo to checks from neutron-lib. It also skips
N530 check because the repo still imports from neutron.*
Change-Id: I70ce6698a3f25af39917ec7bdf1a31a1d4cabf89
Openstack infra now supports upper constraints for
all jobs. Updated tox.ini to use upper constraints
for all jobs.
Change-Id: Iab54f04d873d85c799e6b520314dd0f00db3c257
Closes-Bug: #1614361
tox shows warning message as follow.
py27 runtests: PYTHONHASHSEED='3460558810'
py27 runtests: commands[0] | find . -type f -name *.py[c|o] -delete
WARNING:test command found but not installed in testenv
cmd: /usr/bin/find
env: /home/vikram/myData/work/openstack/neutron-dynamic-routing/.tox/py27
Maybe you forgot to specify a dependency? See also the whitelist_externals envconfig setting.
py27 runtests: commands[1] | find . -type d -name __pycache__ -delete
WARNING:test command found but not installed in testenv
cmd: /usr/bin/find
env: /home/vikram/myData/work/openstack/neutron-dynamic-routing/.tox/py27
Maybe you forgot to specify a dependency? See also the whitelist_externals envconfig setting.
py27 runtests: commands[2] | sh tools/pretty_tox.sh
It seems that "find" command needs full path in tox.ini
Partial-Bug: #1560003
Change-Id: Iafd0ea9fc6a79859313c004845003c7e71c2c216
Now that there is a passing gate job, we can claim support for
Python 3.5 in the classifier. This patch also adds the convenience
py35 venv.
Change-Id: I6b74811ef13caa3006a52e331346acc59eaca017
This change allows to run functional tests adding gate_hook.sh and
post_test_hook.sh scripts.
Partial-Bug: #1560003
Change-Id: I1d34e4f3eaf2ea8de9aab070513c6590e8e785dd
Many deprecations are triggered early (on imports, for example)
before the warnings are enabled by the WarningsFixture in the
base test class.
To make sure all DeprecationWarning messages are emitted we enable
them via the PYTHONWARNINGS environment variable.
Change-Id: I25c6d9fe0c50fd117a432ce6ca9a31e104503ffc
The translations are done via the pep8 checks. This code is no
longer needed and very out of date.
TrivialFix
Change-Id: I4313fd049d40341b6480828819e84fadd4eb4060
This patch moves the BGP service plugin, agent, driver, and
tests out of the neutron repository and into the
neutron-dynamic-routing repository.
Partially-Implements: blueprint bgp-spinout
Partial-Bug: #1560003
Co-Authored-By: vikram.choudhary <vikram.choudhary@huawei.com>
Change-Id: I80ea28a51d7b18e67d6ed4cd2da22520f950300f
elajkat