hacking 3.0.x is too old.
Try to synchronize pylint ignore and extension list with
other Networking projects.
With new pip the order of packages is not relevant, so the
related comment from requirements.txts is removed, see pip
documentation:
https://pip.pypa.io/en/stable/cli/pip_install/#installation-order
Change-Id: I99a2d30149088d3d71d56351d180e665c38686ef
tox now always recreates an env although the env is shared using envdir
options.
~~~
$ tox -e genpolicy
genpolicy: recreate env because env type changed from
{'name': 'genconfig', 'type': 'VirtualEnvRunner'} to
{'name': 'genpolicy', 'type': 'VirtualEnvRunner'}
~~~
According to the maintainer of tox, this functionality is not intended
to be supported.
https://github.com/tox-dev/tox/issues/425#issuecomment-1011944293
Change-Id: I069f590d873ea7a0e689936664c07843c2706fd5
Since we use usedevelop=True, as a result neutron-fwaas
installation happens at 'develop-inst' phase and it installs
requirements from requirements.txt without considering
tox constraints, This can lead to issue where broken
requirements are installed in docs job and as a result
it will fail.
In order to get constraints be considered for this case, add
requirements.txt to deps for docs env(same as [1]).
[1 https://review.opendev.org/q/Ic8f6472fe708d12f8fc129729465367083e1095a
Change-Id: Iea9556f6f025ad2f3dfa38fd401aa64414bd561f
With latest tox (>4.0.15) python version conflicted with base
python. Adding ignore_basepython_conflict = True solves this
issue.
Change-Id: I4711cdb1741c0348bc81049be53a5480945e7e12
The work for making routed networks work with multiple segments per
host, introduced new signature for VlanManager.get, requesting
segmentation_id, make neutron-fwaas code compatible with it.
With oslo.db 12.1.0 some unit tests started to fail, with using the
CONTEXT_R/W session we can fix it.
Adopt dsvm-functional target name as [0] changed in Neutron, so the new
name of the target is dsvm-functional-gate.
[0]: https://review.opendev.org/c/openstack/neutron/+/856262
Change-Id: Ie7459974f6f2358c8d9c37e66aa9cda530ecefc0
Related-Bug: #1956435
Related-Bug: #1764738
In Zed cycle, we have dropped the python 3.6/3.7[1] testing
and its support. Add release notes and update the python
classifier for the same.
[1] https://governance.openstack.org/tc/reference/runtimes/zed.html
Change-Id: Ib04b560408ccf22c86e899e15fbcbe86b53f636e
This reverts commit caae7b6a6f.
Reason for revert:
Many users still need L3 firewalls and Inspur team wants to maintain
this project.
Neutron drivers team discussed the topic of the maintenance of
neutron-fwaas, and agreed to include neutron-fwaas again to Neutron
stadium[1].
Some updates have been made:
Remove use "autonested_transaction" method, see more [2]
Replace "neutron_lib.callbacks.registry.notify" with "registry.publish"
Replace rootwrap execution with privsep context execution.
Ensure db Models and migration scripts are sync, set table
firewall_group_port_associations_v2's two columns nullable=False
[1] https://meetings.opendev.org/meetings/neutron_drivers/2022/neutron_drivers.2022-01-28-14.00.log.html#l-14
[2] https://review.opendev.org/c/openstack/neutron-lib/+/761728
Change-Id: I14f551c199d9badcf25b9e65c954c012326d27cd
1. It's Ussuri. We can *finally* stop testing Python 2 [1]. Time to party.
We don't attempt any cleanup but simply stop testing with Python 2,
indicate that we only support Python 3 via 'setup.cfg' and remove any
Python 2 only dependencies.
This should free up a significant amount of resources from the gate and
let us start using Python 3 idioms in our code. Win-win.
2. Cleanup basepython from individual testenv sections
3. From this point on the codebase will be incompatible with python2
[1] https://governance.openstack.org/tc/resolutions/20180529-python2-deprecation-timeline.html#python2-deprecation-timeline
Change-Id: Ia08c363263aaa406d0bf55e10ce8258695387578
All projects should be switched to use stestr already. In
neutron-fwaas it is already done but there were some leftovers
after os-testr and this commit removes them.
Change-Id: I7d0c72d1327eedcfd309ec4c346064d0adad6008
The module reference in PDF doc is not easy to read
and the HTML version is much better, so I decided to show
the module reference in HTML doc only.
Change-Id: I914d26ce1b430573020c78af54a38598ae96886b
Story: 2006099
Task: 35129
This patch switches neutron-fwaas-fullstack to Zuul v3 syntax
and to inherits from neutron-fullstack job definition.
It also removed neutron-fwaas-fullstack-python35 job definition as
this job wasn't run anywhere and now as neutron-fwaas-fullstack will
inherits from neutron-fullstack it will run on python 3.
Depends-On: https://review.opendev.org/#/c/647931/
Change-Id: I4c08367d7e0670b3f8219b281af22632d53fcdae
Related-Bug: #1804844
Recent update brought os-testr 1.0.0 that already uses stestr test [1]
runner instead of testrepository. This patch migrates those places using
testrepository to using stestr.
[1] http://lists.openstack.org/pipermail/openstack-dev/2017-September/122135.html
Co-Authored-By: Nate Johnston <nate.johnston@redhat.com>
Change-Id: I36f922799fa5a0ed75f412999922f7d5bab180cc
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
NOTE: legacy-neutron-fwaas-dsvm-functional is failing.
This needs to be fixed in a separate patch.
Change-Id: I71dc6449c64b9a9f974d83e51423a7c67a42c551
We recently removed nenutron.common.rpc [1] as the rpc module lives in
neutron-lib now. This project was missed because I didn't find
neutron.common.rpc as an import. This patch switches rpc uses over to
neutron-lib.
This also addresses an issue where toxenv fails when it encounters a
non-empty __pycache__ directory. This adjusts the options passed to
find so that it is tolerant of this scenario and allows tox runs to
proceed.
"rm -rf .tox/lower-constraints/*" in testenv command in tox.ini
is unnecessary, so it is dropped too.
[1] https://review.openstack.org/#/c/634790/
Change-Id: I95490cba503d3f3a61bdc28ef63edc82a3ae1be3
This commit converts the existing neutron-fwaas policy.json
into policy-in-code.
policy.json for testing is also removed. As a result, setup_config()
in neutron_fwaas.tests.base.NeutronDbPluginV2TestCase is no longer
required now (as the content of setup_config() is now same as that
in neutron).
Partially Implements: blueprint neutron-policy-in-code
Change-Id: I67be3a21f19e3f793312d64d358452ee4531c080
This is a mechanically generated patch to add a unit test job running
under Python 3.6 as part of the python3-first goal.
See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html
Change-Id: I57b0799ad3ee590fe3026734259556717a5e57b9
This patch adds local tox targets for pep8 and python 3 as per [1]
that will install dependencies in editable mode.
To run them use the pep8-dev and py3-dev targets respectively.
[1] https://etherpad.openstack.org/p/neutron-sibling-setup
Change-Id: Ia4dc72581e4c0bce7c452969078c7abf18abdd4c
Sphinx version 1.7.5 is raised doc build failures. Maybe deps are not
suitable with current sphinx version.
This patch fixes functional test, due to neutron out of date
version and setns() of pynetns doesn't return any open FD anymore [2].
[1] http://lists.openstack.org/pipermail/openstack-dev/2018-April/128986.html
[2] 2e7964f498
Co-Authored-By: Nguyen Phuong An <AnNP@vn.fujitsu.com>
Change-Id: I44c89a4637a6c6b10f374f83ff76fb1225b603b7
Currently, pep8 ignores D000 check because of error:
"D000 Cannot analyze code. Pygments package not found."
Pygments is supported from:
https://review.openstack.org/#/c/568729/
This patch also changed code-block type from "none" to "ini"
as D000 check does not allow the "none" type.
Change-Id: I05d1d41160ad86589308912ff81c4294983069ff
Add a fullstack testing framework for neutron-fwaas. This is a basic
first pass just to get the framework deployed; detailed non-plagiaristic
tests will be added after. For more information on what fullstack
testing is, see:
http://git.openstack.org/cgit/openstack/neutron/tree/TESTING.rst#n213
Includes definition of fullstack job in new zuul syntax.
Co-Authored-By: Reedip Banerjee <reedip14@gmail.com>
Change-Id: I16cd2432606ef9aa6b7bf3e08efe82882e5585d9
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
Change-Id: I2d6ce9ddd15e5816be5c888daa907039c66507fa
Depends-On: https://review.openstack.org/555034
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Instead of using tox-install.sh, we can install horizon and neutron
now directly from pypi - or use the current branch in CI system using
tox-siblings.
Update tox.ini for this change and add neutron to requirements file.
Change-Id: I29c17d51f2648e4bdef1a8c9799ca5e785aa3423
This patch enable extensions:
-[H204] Use assert(Not)Equal to check for equality.
-[H205] Use assert(Greater|Less)(Equal) for comparison.
Change-Id: I375c61e09a76e8b195b19c962b1c561fcbe5ffb0
This patch adds a doc8 check of .rst files to the current pep8 check.
It includes fixes to the .rst files that didn't pass the check.
Change-Id: I9d6d604e7a21540728c4f44afc9be5577d02805f
This PS is going to following item:
- Remove dependency oslo.serialization which only use at one test-case
and use build-in python package that is json[1] in the code-base.
- Ignore N521 check in the flake which no longer need to check when we
change into json.
[1] https://docs.python.org/3.6/library/json.html
Change-Id: I22cf66d1ea5666a072a06456213a7964c5deced8