Add WebTest to test-requirements which used to be imported as a
transitive requirement via pecan, but the latest release of
pecan dropped this dependency. So make this requirement explicit.
Related-Bug: #1982110
Change-Id: I55c8ef4bd0e6f71ee058083708bbac4aa9fa56a0
The latest pip resolver started to check requirements strictly
and it detects many inconsistencies in neutron-vpnaas requirements.
Also applies the practices discussed in the mailing list [1][2].
* Drop pyflakes from requirements.txt as it is not used.
* Move document dependencies to doc/requirements.txt [1]
and drop them from lower-constriants.txt.
* Bump MarkupSafe lower-constraint to 1.1.1
to make it work with newer setuptools.
* Bump the minimum neutron requirement to 17.0.0 (victoria release)
as the previous min version 13.0.0.0b2 is too old.
Wallaby and Victoria neutron are not different much, so I think
it is no problem to use the latest released version here.
* Dependenicy related to neutron min version bump are updated
in requirements and lower-constraints.
Note that eventlet 0.22.0 is used as lower-constraints as 0.21.0
(the min requirement in neutron 17.0.0) is blocked in several libs.
* Move linter dependencies to tox.ini and drop them from
lower-constraints.txt (pylint, pyflakes, astroid, isort)
* Drop psutil from neutron_vpnaas/tests/functional/requirements.txt
as the specified version of psutil is too old and psutil is a dependency
of neutron so we don't need to install it explicitly here.
In addition, hacking version is updated as hacking 0.12.0 is not compatible
with python 3.8. W504 and I202 are ignored as we do in the neutron repo.
Other new flake8 violations are fixed.
[1] http://lists.openstack.org/pipermail/openstack-discuss/2021-January/019611.html
[2] http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019362.html
Change-Id: I47f6d39379b68c4d71fc4d85ebb06d97cb5a6ce2
This patch fixes multiple issues to unblock gate:
1. With new isort releases (5.X.X) pylint started to fail, with error:
AttributeError: module 'isort' has no attribute 'SortImports'
This patch pin isort to 4.3.21, the last version before 5.0.0.
2. lower-constraints of appdirs and pytz need to be updated as
currently lower-constraints job fails.
Since patch Ia012a8e116a276a6674f86366c803e0e2d8ff704 modified the
NEUTRON_PATH variable the functional test fails with:
[..]neutron/tools/configure_for_func_testing.sh: line 113: /home/zuul/src/opendev.org/openstack/neutron-vpnaas/devstack/lib/ovs: No such file or directory
3. Functional job fails, because during tox run the latest released
neutron is installed and it requires mock to be installed. This
patch adds mock to functional test requirements. Note: this needs
to be deleted as soon as new neutron will be released as on
development branch neutron does not depend on mock anymore.
Change-Id: Ibc4cd7f8a055457b288ef101893c252cf0464a28
Switch to openstackdocstheme 2.2.1 and reno 3.1.0 versions. Using
these versions will allow especially:
* Linking from HTML to PDF document
* Allow parallel building of documents
* Fix some rendering problems
Update Sphinx version as well.
Set openstackdocs_pdf_link to link to PDF file. Note that
the link to the published document only works on docs.openstack.org
where the PDF file is placed in the top-level html directory. The
site-preview places the PDF in a pdf directory.
Disable openstackdocs_auto_name to use 'project' variable as name.
Change pygments_style to 'native' since old theme version always used
'native' and the theme now respects the setting and using 'sphinx' can
lead to some strange rendering.
openstackdocstheme renames some variables, so follow the renames
before the next release removes them. A couple of variables are also
not needed anymore, remove them.
See also
http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html
Change-Id: Ibeec55164eaa9985b3e9281bc23ecdad232e4fff
Make a few cleanups:
- Remove python 2.7 stanza from setup.py
- Remove obsolete sections from setup.cfg:
* Wheel is not needed for python 3 only repo
* Some other sections are obsolete
- Update classifiers
- Update requirements, no need for python_version anymore
Change-Id: I79cf58adf35726999a0791525dd28a7e70de4591
We're only support py3 now, so using the standard library
unittest.mock instead of the mock module.
Change-Id: Ie827780a950cf66030ee1a688674e66ca7f3479c
While running PEP8 in python3.7 environment, will met the
following exception:
"RuntimeError: generator raised StopIteration"
This is an known issue in py3.7, and had been fixed in Pylint 2.x.
After upgrade Pylint to 2.2.0, the issue is:
"AttributeError: 'Import' object has no
attribute 'infer_name_module' on import"
This issue was fixed in Pylint 2.3.0.
So upgrades Pylint to 2.3.0, this patch also
adds some refactor recommendations in .pylintrc[1]
[1] http://paste.openstack.org/show/789057/
Change-Id: I2b3983e3653d92c5b12f233b57fb4467df1da83d
Patch [1] introduced need to explicity set with "is_sort_key"
flag to attributes which attribute can be used as sort key.
This patch adds it to base attributes in vpnaas resources, like:
* id,
* tenant_id,
* name,
* subnet_id,
* router_id
This commit also updates sphinx requirements to make requirements
jobs passing.
[1] https://review.opendev.org/#/c/653903/
Change-Id: Ibe1aee0346e3fc21215d1b3be8752224aa2c162d
Closes-Bug: #1832225
This patch adds the pep8-dev tox target for running pep8 locally as per
[1]. In addition it updates the pylint version to work with python 3.x
and addresses some pylint errors in the code.
[1] https://etherpad.openstack.org/p/neutron-sibling-setup
Change-Id: I7bd4d8e75601a7291692d6256925f46fb4fa5464
According to Openstack summit session [1] stestr is
maintained project to which all Openstack projects
should migrate.
Let's switch it then.
[1] https://etherpad.openstack.org/p/YVR-python-pti
Change-Id: Ia4c71631e4c51ec814bcefc115d4f5690c11e37b
python-subunit is not used directly anywhere at the moment.
No need to keep it at the requirement dependency.
Change-Id: I37aa91f07bed9ae6fd9e53eb92805fb20516a009
1. In reviews we usually check import grouping but it is boring.
By using flake8-import-order plugin, we can avoid this.
It enforces loose checking so it sounds good to use it.
This flake8 plugin is already used in tempest.
Note that flake8-import-order version is pinned to avoid unexpected
breakage of pep8 job.
Setup for unit tests of hacking rules is tweaked to disable
flake8-import-order checks. This extension assumes an actual file
exists and causes hacking rule unit tests.
2. This patch is also intend to clean up exceptions to avoid
confusing for other developers and the maintenance-ability as well.
Change-Id: I032892f08e073feb5b822d27d092f041b17d57e1
As part of the docs migration work[0] for Pike we need to switch to use
the openstackdocstheme.
[0]https://review.openstack.org/#/c/472275/
Change-Id: Icb985379c263d7d06544d69bae11282a18a7fc52
This makes tox use the latest version of the tool from os-testr repo,
which contains some valuable changes, like the one making the gate fail
if for some reason no tests are executed because all of them are
skipped.
Change-Id: If88be4b310d746ccc885e3d0c1db8a4dfabb2a28
Since pbr already landed and the old version of hacking seems not
work very well with pbr>=2, we should update it to match global
requirement.
Partial-Bug: #1668848
Change-Id: I2b5b3ff519c2a956d65be8503aac7e5d05793295
Since I516b37d45200cc120a929ecd9011ff8bb4c45d9f tempest-lib has
not been used in tests. In addition, tempest-lib itself is marked
as deprecated.
So this patch removes tempest-lib from test-requirements.txt and
add tempest to have right version of that for used interfaces.
Change-Id: Ic9e93944e3480da5ee411a46b062f2e0afef7a93
Takashi Kajinami