openstack
/
neutron
Code Issues Proposed changes

Update some l3-agent log messages 

A warning message in process_delete() had an unnecessary
period since the method was wrapped with exception_logger():

 "...no router namespace found.: FloatingIpSetupException..."

Also, two debug messages were not printing the router ID,
so were pretty useless.

Trivialfix

Change-Id: Ib007d81d53823b665f4f16d23c87bc887749d252
This commit is contained in:
Brian Haley 2017-12-14 09:24:39 -05:00
parent 78189ef987
commit 77fc89b675
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
neutron/agent/l3/router_info.py
View File

@ -1112,14 +1112,14 @@ class RouterInfo(object):
:param agent: Passes the agent in order to send RPC messages.
"""
LOG.debug("process router delete")
LOG.debug("Process delete, router %s", self.router['id'])
if self.router_namespace.exists():
self._process_internal_ports()
self.agent.pd.sync_router(self.router['id'])
self._process_external_on_delete()
else:
LOG.warning("Can't gracefully delete the router %s: "
"no router namespace found.", self.router['id'])
"no router namespace found", self.router['id'])
@common_utils.exception_logger()
def process(self):
@ -1130,7 +1130,7 @@ class RouterInfo(object):
:param agent: Passes the agent in order to send RPC messages.
"""
LOG.debug("process router updates")
LOG.debug("Process updates, router %s", self.router['id'])
self._process_internal_ports()
self.agent.pd.sync_router(self.router['id'])
self.process_external()