openstack
/
neutron
Code Issues Proposed changes

Merge "Fixing the filter in get MTU by network list query."

This commit is contained in:
Zuul 2018-02-15 07:26:36 +00:00 committed by Gerrit Code Review
parent 114712ef59 d15244ab4f
commit aa1e4d63c4
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/db/l3_db.py
View File

@ -1716,7 +1716,7 @@ class L3_NAT_dbonly_mixin(l3.RouterPluginBase,
def _get_mtus_by_network_list(self, context, network_ids):
if not network_ids:
return {}
filters = {'network_id': network_ids}
filters = {'id': network_ids}
fields = ['id', 'mtu']
networks = self._core_plugin.get_networks(context, filters=filters,
fields=fields)

16
neutron/tests/unit/db/test_l3_db.py
View File

@ -85,6 +85,22 @@ class TestL3_NAT_dbonly_mixin(base.BaseTestCase):
'address_scope_id': mock.sentinel.address_scope_id,
'network_id': mock.sentinel.network_id}]}, subnets)
def test__get_mtus_by_network_list(self):
"""Basic test that the query get_networks is correctly"""
network = {'id': mock.sentinel.network_id,
'name': mock.sentinel.name,
'mtu': mock.sentinel.mtu}
with mock.patch.object(directory, 'get_plugin') as get_p:
get_p().get_networks.return_value = [network]
result = self.db._get_mtus_by_network_list(
mock.sentinel.context, [mock.sentinel.network_id])
get_p().get_networks.assert_called_once_with(
mock.sentinel.context,
filters={'id': [mock.sentinel.network_id]},
fields=['id', 'mtu'])
self.assertEqual({mock.sentinel.network_id: mock.sentinel.mtu},
result)
def test__populate_ports_for_subnets_none(self):
"""Basic test that the method runs correctly with no ports"""
ports = []