Commit Graph

28133 Commits

Author SHA1 Message Date
Zuul 0534f5dea7 Merge "Do not fail on missing logical router ports" 2024-05-23 04:00:40 +00:00
Zuul 2718a7da47 Merge "Bump port revision if binding_levels changed" 2024-05-22 23:33:39 +00:00
Zuul 147dc93eff Merge "tests: Use `del_fake_chassis` when deleting a chassis" 2024-05-22 22:19:40 +00:00
Ihar Hrachyshka 60167cbb6e tests: Use `del_fake_chassis` when deleting a chassis
This will guarantee that regardless of ovsdbapp version, Chassis_Private
will be deleted. This allows us to wait for a single event (DELETE) and
test the same behavior for all ovsdbapp versions. (Behavior of agent
listing when both Chassis and Chassis_Private records are deleted from
ovn db.)

Depends-On: https://review.opendev.org/c/openstack/requirements/+/920062
Change-Id: I0dfa21a927067afb532d7632f7e05427623327f5
2024-05-22 05:40:01 +00:00
yatinkarel 7967627035 Do not fail on missing logical router ports
set_gateway_mtu runs for all the gateway ports for a network
and if one of the ports get's deleted in meanwhile
whole transaction fails. Added if_exists=True so the
transaction do not fail for such deleted ports.

Also update minimal version of "ovsdbapp" required for
this.

Depends-On: https://review.opendev.org/c/openstack/ovsdbapp/+/919696
Depends-On: https://review.opendev.org/c/openstack/requirements/+/920062
Closes-Bug: #2065701
Related-Bug: #2060163
Change-Id: Ie0ce420414f1e6056d9df2733b7446d02c89fcfc
2024-05-22 09:17:07 +05:30
Zuul c89b50c639 Merge "Remove the Windows OS libraries" 2024-05-21 19:40:11 +00:00
Zuul 1bb01f0095 Merge "[functional tests] compatibility with ovsdbapp>=2.7.0" 2024-05-21 18:22:45 +00:00
yatinkarel 20b9893e34 [functional tests] compatibility with ovsdbapp>=2.7.0
ovsdbapp>=2.7.0 handles cleanup of Chassis_Private record
with chassis delete so we don't need explicit delete.
The compatibility part can be dropped when we update
requirements.txt to ovsdbapp>=2.7.0.

Closes-Bug: #2066263
Change-Id: I45c6e6a1c3536cf4f2d90b01a3577eec9eaf3743
2024-05-21 14:31:36 +00:00
yatinkarel 2beb20f92b Update grenade_from_branch for skip level jobs
Skip level jobs were wrongly upgrading from stable/2023.1.
As master is currently 2024.2, upgrade from branch should
be 2023.2, this patch fixes it.

Related-Bug: #2066221
Change-Id: I568ebb93bc009951ca113a09ee750982f580b40d
2024-05-21 11:49:47 +05:30
Zuul e0442afa9b Merge "Remove the restriction on empty cidr's update events" 2024-05-20 11:45:15 +00:00
Zuul 5bec5c54ac Merge "Remove string support in install_instructions" 2024-05-20 11:45:11 +00:00
Zuul 2cb47b2a36 Merge "Make common Metadata Proxy classes" 2024-05-20 11:27:11 +00:00
Zuul dcfe7c4a4d Merge "Rename create_flows_for_ip_address to reflect it accepts (ip, mac)" 2024-05-20 11:27:06 +00:00
Zuul 527e712a18 Merge "Increase code coverage for ip_lib sysctl()" 2024-05-20 09:44:29 +00:00
Zuul d11cda46b0 Merge "Remove and modify outdated options in DHCP HA documentation" 2024-05-17 18:21:47 +00:00
Zuul bd11b838ff Merge "Increase code coverage for cidr_broadcast_address_alternative()" 2024-05-17 18:12:43 +00:00
Zuul dac655c643 Merge "Increase code coverage for floating_mangle_rules()" 2024-05-17 18:12:39 +00:00
Zuul ad18963e04 Merge "Update the OVN manual install doc" 2024-05-17 18:12:33 +00:00
Zuul 31427e7432 Merge "Increase code coverage for plugin _get_network_mtu()" 2024-05-17 18:12:30 +00:00
LIU Yulong 80577381d9 Bump port revision if binding_levels changed
Related-Bug: #2065577
Change-Id: I0d04c3a1dae86a2b6b4ba70c0e9595b2527b4f71
2024-05-17 11:43:53 +08:00
Zuul cb78c7e973 Merge "Add pre-commit configuration" 2024-05-16 17:49:38 +00:00
Zuul f785038c3c Merge "Fix trailing whitespaces and replace tabs with 4 spaces" 2024-05-16 16:09:35 +00:00
Zuul 6c5a052ac0 Merge "Put monitors dictionary back in MetadataDriverBase class" 2024-05-16 01:32:41 +00:00
Zuul 2fc5f37669 Merge "Increase code coverage for OVN SG update" 2024-05-15 22:03:31 +00:00
Ihar Hrachyshka d040a38f49 Rename create_flows_for_ip_address to reflect it accepts (ip, mac)
The semantics changed since I2e3aa7c400d7bb17cc117b65faaa160b41013dde
but the name was not updated.

This patch also revealed a number of issues in unit tests where
mock flow_states were using the old key format (bare ip) instead of the
new (ip, mac) tuple. These are also now fixed.

Change-Id: Ic96b5ce6576c31075602e0f033fd74acbae333ee
2024-05-15 15:10:39 +00:00
Takashi Kajinami 11255ede97 Fix the broken neutron gate
There are currently two issues affecting the neutron gate, one
for pep8 job and the other for fullstack. We need to fix them
both together since they cannot merge separately.

Bump pylint to the latest version to fix pep8 job - it was
pinned to an old version which is causing the job to hang.

Do not use str(url) to stringify a URL for subsequent use
to fix  the fullstack job. The str(url) function in SQLAlchemy
hides the password. For a URL string that is to be re-used, use
render_as_string(hide_password=False).

Co-authored-by: Mike Bayer <mike_mp@zzzcomputing.com>

Closes-Bug: #2065779
Change-Id: I8d04db91ddc2995fbff05b4c4c48baebcc418522
2024-05-15 16:13:38 +02:00
Zuul 35daa2d868 Merge "Optimize deletion of static routes" 2024-05-13 12:11:58 +00:00
Ihtisham ul Haq 305153883b Optimize deletion of static routes
Instead of having a separate OVN command for deletion of each
static route, send out the deletion as a single command.

Which significantly improves the performance. Previously
deletion of 1000 routes took >1m30s and >6m30s for 2000 routes,
with this change it takes ~5s and ~8s, respectivily.

Closes-Bug: #2060054
Change-Id: Iaa5204e2e48795c31c502160041bd128189eef5a
2024-05-12 18:21:30 +02:00
Brian Haley 5b62e27154 Put monitors dictionary back in MetadataDriverBase class
When the common Metadata Driver was created in [0], the
monitors dictionary was dropped accidentally. This causes
tracebacks in the fullstack L3-HA tests when
after_router_updated() is called. Put it back along with
its related tests.

[0] https://review.opendev.org/c/openstack/neutron/+/894399

Closes-bug: #2065145
Change-Id: I137ed7cec9e0eafdb3a351e5a414f5a0c16f33e5
2024-05-08 17:31:55 -04:00
Ihar Hrachyshka a3d0fb6673 tests: Don't use neutron object where db model is expected
Change-Id: I5f99153c105e7f86638356a75a955504ed42e288
2024-05-07 22:16:18 -04:00
Jakub Libosvar 5795c192b8 Don't update revision number if object was not modified
If there were not changes made to data in the database there is no
reason to bump revision numbers because the underlying drivers won't
change too. This saves cycles in case empty updates are incoming to the
API.

Co-Authored-By: Ihar Hrachyshka <ihar@redhat.com>

Closes-bug: #2065094
Change-Id: Ib74fdab7a8927ef9cc24ef7810e9cf2c264941eb
2024-05-07 22:16:14 -04:00
Slawek Kaplonski cdb644574a Remove info about QoS and L3 meetings from the contributing guide
We don't have those meetings anymore.

Change-Id: I9957124609114540812b0141b09cd41026801f03
2024-05-06 08:50:25 +02:00
Zuul 7f56084c88 Merge "Start trunk plugin RPC via service framework" 2024-05-03 01:49:43 +00:00
Slawek Kaplonski af7c98a908 Add pre-commit configuration
'pre-commit' tool [1] provides an extensible way to configure hooks
which can be run automatically before each commit. That way we can make
sure that code send to review is passing base static analysis checks
like e.g. bandit, flake8 or hacking.

For now this is optional to use and not integrated in e.g. tox.ini file
but we can integrate it there too as next step.

[1] https://pre-commit.com/

Change-Id: Ia3bc21ccacacbcb8a529163533557312cbbf25bd
2024-05-02 10:46:27 +00:00
Slawek Kaplonski aeae6780a0 Fix trailing whitespaces and replace tabs with 4 spaces
Those changes are done just to make pre-commit hook happy.

TrivialFix

Change-Id: I60e646df0a109c4ff67a25fafebec71b81599adb
2024-05-02 12:45:51 +02:00
Zuul 305d9ea0c7 Merge "Add tox.ini testenv descriptions" 2024-05-02 10:04:47 +00:00
Sebastian Lohff ffcaeda32a Start trunk plugin RPC via service framework
Instead of each individual driver setting up the RPC server (and setting
the _rpc_backend attribute on the TrunkPlugin) we now check in the
TrunkPlugin if any driver requires the RPC backend to be started.
Additionally, we only start it when this is requested by Neutron via
start_rpc_listeners(). This is required when running neutron-server and
neutron-rpc-server separately to run RPC only in neutron-rpc-server.

As we still need the notifiers of ServerSideRpcBackend to be
created/started, we separate TrunkSkeleton (which is the RPC server
implementation) and ServerSideRpcBackend (which is essentially only a
notifier). In case RPC is required by a driver, we always start the
notifier, but the RPC server only when requested via
start_rpc_listeners().

Change-Id: I2c6362b3320e534a6e65bd7701b5ac2feca42a49
Closes-Bug: #2015275
Closes-Bug: #2062009
2024-04-30 16:18:53 +02:00
OpenStack Release Bot a35858b053 reno: Update master for unmaintained/zed
Update the zed release notes configuration to build from
unmaintained/zed.

Change-Id: I4f862c25bc4f6b7181b1e84a3128d93aca0c9d01
2024-04-30 08:54:02 +00:00
Brian Haley a5ee7497b0 Add tox.ini testenv descriptions
Add descriptions for each test that can be run.

TrivialFix

Change-Id: I7314e4c1ee82182cdd6ae12734e8a5f9cadae0e2
2024-04-29 17:23:56 -04:00
JangYeHoon 5cee4b34fa Remove and modify outdated options in DHCP HA documentation
A database option has been added to neutron.conf.
Removed the old options rabbit_host and rabbit_password in neutron.conf.

Removed outdated options use_neutron and firewall_driver from linuxbridge_conf.ini.
The admin_ option used in the neutron part of linuxbridge_conf.ini has been updated to the latest.
Modify tenant_name to project_name in the neutron part of linuxbridge_conf.ini

Closes-Bug: #2042647
Change-Id: I3f4538e1e63fb316425ef7c6ab5c53a0a74f739f
2024-04-29 03:58:31 +00:00
Ihar Hrachyshka a69bd0dd60 Make it explicit ovs_firewall operates with ip, mac pairs
The semantics changed since I2e3aa7c400d7bb17cc117b65faaa160b41013dde
but the code was not updated to reflect it explicitly.

This patch modifies _update_flows_for_vlan_subr.

Change-Id: Id5e0d8bcc379f19dc85b23b4602be4e0e82f3d00
2024-04-26 22:50:29 -04:00
Ihar Hrachyshka ae704369b5 tests: fix invalid `addr` mock values in ovs firewall suite
The tests were passing a string of IPv4 address where the actual code
was expecting a tuple of (IPv4 address, MAC address). The type of the
`addr` changed from a string to a tuple in:

I2e3aa7c400d7bb17cc117b65faaa160b41013dde

but the names of variables and the test cases were not.

Tests still didn't fail till recently because addr[0] resulted in the
first character of the IPv4 address string (e.g. `1`), and was then
interpreted by `netaddr` library as an address. This worked until
`netaddr>=1.0` started to enforce proper formats for passed IPv4
addresses - which broke the tests.

Closes-Bug: #2054435
Change-Id: Ib9594bc0611007efdbaf3219ccd44bbb37cfc627
2024-04-26 22:50:29 -04:00
Zuul 22a3384194 Merge "Fix assignment-from-no-return error" 2024-04-25 17:31:42 +00:00
Zuul 484b04cf01 Merge "Register root_helper config for state change" 2024-04-23 22:55:06 +00:00
Zuul 72c8ce2c1a Merge "Start logging plugin RPC via service framework" 2024-04-23 21:23:03 +00:00
Zuul a02b46b5b7 Merge "dhcp: fix auto_scheduler_network understanding dhcp_agents_per_network" 2024-04-23 21:02:27 +00:00
Zuul c21a9169c6 Merge "Bandit: Remove bandit B604 from skip list" 2024-04-23 16:10:51 +00:00
Zuul 34a0e88dce Merge "Bandit: Remove bandit B324 from skip list" 2024-04-23 15:51:38 +00:00
Zuul 135cfa3215 Merge "Ensure [designate] url is a valid URI" 2024-04-23 05:31:28 +00:00
Zuul 890bb3904d Merge "Switch to cirros uec image in singlenode jobs" 2024-04-22 16:17:48 +00:00