Commit Graph

20618 Commits

Author SHA1 Message Date
Miguel Lavalle 8ff8203fd7 Enable HA for OVN router flavors
In this change, we add the ability to create high availability
user defined router flavors under the ML2/OVN L3 service
plugin.

Closes-Bug: #2020823

Change-Id: I0d26f672d6239d840d3cf817a2553a06ef00a854
2024-03-26 20:07:52 -05:00
Zuul 01a6684dd0 Merge "Don't delete already deleted extra router routes" 2024-03-26 17:34:23 +00:00
Zuul 0590bcda68 Merge "Fixing the 500 HTTP code in the metadata service if Nova is down" 2024-03-26 16:42:10 +00:00
Anton Kurbatov 6395b4fe8e Fixing the 500 HTTP code in the metadata service if Nova is down
If the Nova metadata service is unavailable, the requests.request()
function may raise a ConnectionError. This results in the upper code
returning a 500 HTTP status code to the user along with a traceback.
Let's handle this scenario and instead return a 503 HTTP status code
(service unavailable).

If the Nova service is down and is behind another proxy (such as
Nginx), then instead of a ConnectionError, the request may result in
receiving a 502 or 503 HTTP status code. Let's also consider this
situation and add support for an additional 504 code.

Closes-Bug: #2059032
Change-Id: I16be18c46a6796224b0793dc385b0ddec01739c4
2024-03-26 12:14:08 +00:00
Miguel Lavalle 9d729bda20 Check unspecified flavor in user defined driver
In order to decide whether to process a router related
request, the user defined router flavor OVN driver needs to
check the flavor_id specified in the request. This change adds
the code to test the case when the API passed the flavor_id as
unspecified.

Change-Id: I4d7d9d5582b97246cad63ef7f5511b159d6c6791
Closes-Bug: #2059051
2024-03-25 17:30:01 -05:00
Zuul e003fd73f6 Merge "Clean up state VRRP PID file" 2024-03-25 16:12:28 +00:00
Zuul 4e9d03d29f Merge "Fix used-before-assignment warnings" 2024-03-22 01:27:48 +00:00
Zuul 57f48b03ac Merge "Fix disallowed-name warnings" 2024-03-22 01:27:40 +00:00
Rodolfo Alonso Hernandez 70ddf4eef5 Add "socket" NUMA affinity policy
This new extension adds a new parameter to the NUMA affinity policy
list: "socket". The "socket" NUMA affinity policy has been supported
in Nova since [1].

[1]https://review.opendev.org/c/openstack/nova/+/773792

Closes-Bug: #2052786
Change-Id: Iad2d4c461a2aceef6ed2d5e622cce38362d79687
2024-03-21 16:04:24 +00:00
Zuul ca479b9e22 Merge "Open the 2024.2 (Dalmatian) DB branch" 2024-03-21 15:53:43 +00:00
Zuul e5d0877045 Merge "Enhance IptablesFirewallDriver with remote address groups" 2024-03-21 10:08:15 +00:00
Robert Breker 5e1188ef38 Enhance IptablesFirewallDriver with remote address groups
This change enhances the IptablesFirewallDriver with support for remote
address groups. Previously, this feature was only available in the
OVSFirewallDriver. This commit harmonizes the capabilities across both
firewall drivers, and by inheritance also to OVSHybridIptablesFirewallDriver.

Background -
The Neutron API allows operators to configure remote address groups [1],
however the OVSHybridIptablesFirewallDriver and IptablesFirewallDriver do
not implement these remote group restrictions. When configuring security
group rules with remote address groups, connections get enabled
based on other rule parameters, ignoring the configured remote address
group restrictions.
This behaviour undocumented, and may lead to more-open-than-configured network
access.

Closes-Bug: #2058138
Change-Id: I76b3cb46ee603fa5e829537af41316bb42a6f30f
2024-03-20 22:20:45 +00:00
Rodolfo Alonso Hernandez 8830fed191 Open the 2024.2 (Dalmatian) DB branch
According to the TC resolution [1] and the release identification
document [2], the release number will be used as primary identifier in
the development cycle. Release name will be used in marketing.

[1]https://governance.openstack.org/tc/resolutions/20220524-release-identification-process.html
[2]https://governance.openstack.org/tc/reference/release-naming.html

Change-Id: I6fc7a154fa77a8792f93eb40c9b4497c0e67ae2f
2024-03-20 10:00:19 +00:00
Zuul 4c9962e280 Merge "Fix making all user defined flavor routers HA" 2024-03-20 00:21:55 +00:00
Zuul 95e4e3b092 Merge "Use oslo_service's SignalHandler for signals" 2024-03-20 00:21:51 +00:00
Miguel Lavalle 26ff51bf05 Fix making all user defined flavor routers HA
Since [1] was merged, user defined flavor routers with the HA
attribute set to False cannot be created. This change fixes
it.

Closes-Bug: #2057983

[1] https://review.opendev.org/c/openstack/neutron/+/910889

Change-Id: Ic72979cfe535c1bb8cba77fb82a380c167509060
2024-03-18 19:20:03 -05:00
Takashi Kajinami 446a7acf2c Add metadata options to generated ovn_agent.ini
The ovn-agent process now loads these options for metadata extension.

Change-Id: I3fcacc9d54e34746fd0ef55f5f74c9f4bd6fbf97
2024-03-16 16:32:32 +09:00
Zuul 00355e092d Merge "[OVN] Use the LSP update event to update the LRP" 2024-03-15 10:30:43 +00:00
Zuul 24a7f20a5e Merge "[OVN] Add the network type to the ``Logical_Switch`` register" 2024-03-15 10:30:38 +00:00
Zuul c0f113073d Merge "[OVN] Implement OVN agent metadata extension" 2024-03-14 16:49:40 +00:00
Sebastian Lohff 27b2f22df1 Don't delete already deleted extra router routes
When handling the deletion of extra routes we need to handle the case
that the route is already deleted by another call in the time we have
fetched the extra routes and try to delete it. This is a classic race
condition when two calls try to update the routes of a router at the
same time. The default MariaDB/MySQL transaction isolation level does
not suffice to prevent this scenario. Directly deleting the route
without fetching it solves this problem.

Change-Id: Ie8238310569eb7c1c53296195800bef5c9cb92a3
Closes-Bug: #2057698
2024-03-13 11:21:32 +01:00
Rodolfo Alonso Hernandez f82c650c8c [OVN] Add the network type to the ``Logical_Switch`` register
Now the ``Logical_Switch`` register (that represents an OVN network),
stored the network type in the "external_ids" field.

Related-Bug: #2056558
Change-Id: I9e55a7412d841b7b59602c56c3a4e2f9c954aeed
2024-03-13 07:38:03 +00:00
Arnau Verdaguer 2a196fefd4 Fix TestOVNMechanismDriver ipv6 tests
- test_update_subnet_dhcp_options_in_ovn_ipv6_not_change
- test_enable_subnet_dhcp_options_in_ovn_ipv6
This tests will fail if host where unit tests has ipv6 dns_servers
configured. This patch mocks get_system_dns_servers to avoid tests
to look at the host configuration.

Closes-Bug: #2056778
Change-Id: I2e703ab4b63c90d7a14f0dc41d37b0a98163bce0
2024-03-11 17:30:11 +01:00
Arefiev Anton d3a8c9ca0f Clean up state VRRP PID file
Change Id62bf18067d0b144c3e8825c7603cc1e51dca052 removes explicit
PID files clean up for keepalived and brings regression as
there is no 'process enable' for VRRP.

Always delete stale PID file if exists

Related-Bug: 1561046
Change-Id: I95a004a3acbe6a9160a19053a37fc0dd2b1875a5
2024-03-11 13:14:05 +02:00
Rodolfo Alonso Hernandez 0fd654f592 [OVN] Use the LSP update event to update the LRP
Now the "Logical_Router_Port" is updated when a "Logical_Switch_Port"
event is received. When the event is received, it is first checked that
the "Logical_Switch_Port" belongs to a router; if that check is
possitive, the router port update method is called.

Closes-Bug: #2056558
Change-Id: I13b4c804ea6a9f8a89d3796c1cec88ffa1de6ded
2024-03-10 04:39:40 +00:00
Terry Wilson a4e49b6b8f Use oslo_service's SignalHandler for signals
When Neutron is killed with SIGTERM (like via systemctl), when using
ML2/OVN neutron workers do not exit and instead are eventually killed
with SIGKILL when the graceful timeout is reached (often around 1
minute).

This is happening due to the signal handlers for SIGTERM. There are
multiple issues.

1) oslo_service, ml2/ovn mech_driver, and ml2/ovo_rpc.py all call
   signal.signal(signal.SIGTERM, ...) overwriting each others signal
   handlers.
2) SIGTERM is handled in the main thread, and running blocking code
   there causes AssertionErrors in eventlet which also prevents the
   process from exiting.
3) The ml2/ovn cleanup code doesn't cause the process to end, so it
   interrupts the killing of the process.

oslo_service has a singleton SignalHandler class that solves all of
these issues

Closes-Bug: #2056366
Depends-On: https://review.opendev.org/c/openstack/oslo.service/+/911627
Change-Id: I730a12746bceaa744c658854e38439420efc4629
Signed-off-by: Terry Wilson <twilson@redhat.com>
2024-03-06 23:20:07 +00:00
Rodolfo Alonso Hernandez b8953b543a [OVN] Enable "ha" API flag for OVN routers
The "ha" API flag is now enabled for the OVN routers. Because of the
current implementation, this flag must be always "True". When a new
router is created, this flag is always set. If an OVN router is
explicitly created or updated with "--no-ha" (ha=False), the server
will raise an InvalidInput exception.

Depends-On: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/911081

Closes-Bug: #2020823
Change-Id: I60ff33680dd5397a226a9051d51bfb0701f862b5
2024-03-06 18:42:29 +00:00
Zuul 705f9bacdd Merge "``OvnDriver`` and ``DvrHaDriver`` to use "distributed_support" variable" 2024-03-06 22:56:05 +00:00
Zuul 5de90ff9c4 Merge "Use the system-dependent string for IP protocol 4" 2024-03-06 18:28:59 +00:00
Zuul c6b9106784 Merge "[FT] Check "Port_Binding" register exists before checking type" 2024-03-06 12:25:42 +00:00
Zuul 91ec092987 Merge "Fix pointless-string-statement warnings" 2024-03-06 12:25:26 +00:00
Zuul 3d1abd3343 Merge "Fix misplaced-bare-raise warning" 2024-03-06 12:25:18 +00:00
Zuul ecbe2a2059 Merge "Fix import-outside-toplevel warnings" 2024-03-06 12:12:54 +00:00
Zuul cd1cd3d534 Merge "Remove unneeded check in dhcp.py" 2024-03-06 12:12:48 +00:00
Zuul 36c6da46e5 Merge "Allow HA routers to have automatic l3agent failover" 2024-03-06 09:32:43 +00:00
Brian Haley cd1d191e33 Use the system-dependent string for IP protocol 4
iptables-save uses a system-dependent value, usually that
found in /etc/protocols, when 'ipip' is given as the
security group protocol. The intent is to always use the
string value for IP protocol '4', as iptables-save has no
'-n' flag to print values numerically.

This updates a previous change (793dfb04d) that hard-coded
that string to 'ipencap', which broke CentOS/Fedora, which
uses 'ipv4'.

For this reason we cannot hard-code anything in neutron-lib,
this needs to be added dynamically, so this one-line change
needs to stay here, and effectively closes the bug.

Closes-bug: #2054324
Change-Id: Ic40b539c9ef5cfa4cbbd6575e19e653342e8342b
2024-03-05 15:36:17 -05:00
Rodolfo Alonso Hernandez fe31f4fe02 [OVN] Implement OVN agent metadata extension
This patch is implementing the OVN agent metadata extension, by reusing
the OVN metadata class. The class ``MetadataAgent`` is inherited in the
``MetadataExtension`` class. The goal is to use the same code in both
implementations (until the OVN metadata agent is deprecated).

The OVN agent metadata extension has a different initialization
process. The OVN and OVS IDL connections are created during the
extension initialization but are not accessible. The ``start`` method
is used to load the configuration, execute the sync process and
register the metadata extension.

This extension will replace the need of the OVN metadata agent. The
deprecation of this agent will imply the refactor of the existing code
that now is shared between both agents.

This new OVN agent will be tested in the "neutron-tempest-plugin-ovn"
CI job, after the change done in the following patch.

Needed-By: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/909860

Partial-Bug: #2017871
Change-Id: I4381a67648a9b6198a8d936db784964d74dc87a1
2024-03-05 16:44:34 +00:00
Zuul c4c14f9589 Merge "[OVN] Set MTU of the VETH interfaces between OVS and metadata" 2024-03-05 09:48:42 +00:00
Rodolfo Alonso Hernandez 06d48cb980 ``OvnDriver`` and ``DvrHaDriver`` to use "distributed_support" variable
``OvnDriver`` and ``DvrHaDriver`` classes were using an incorrect
variable name to define the DVR support, that should be
"distributed_support" instead of "dvr_support".

Closes-Bug: #2056199
Change-Id: Id2ee080dde8cd094995e94564f2877a89e9cc5aa
2024-03-05 02:34:30 +00:00
Zuul 729937f6d2 Merge "[OVN] Make mandatory the router name in the LRP.external_ids" 2024-03-04 14:23:07 +00:00
Rodolfo Alonso Hernandez 8b007e6366 [FT] Check "Port_Binding" register exists before checking type
In "test_virtual_port_host_update_upon_failover", it is needed to check
if the "Port_Binding" register exists before checking the type.

Closes-Bug: #2055886
Change-Id: I8a6b3498803bcba592a82dfbe43a39137dd12fa2
2024-03-04 14:00:07 +00:00
Zuul 96558ac77a Merge "Fix iptables mapping of 'ipip' protocol" 2024-03-04 10:44:58 +00:00
Rodolfo Alonso Hernandez b5aecfeff8 [OVN] Make mandatory the router name in the LRP.external_ids
The router name will be always defined in the "Logical_Router_Port"
external_ids field.

Related-Bug: #2052821
Change-Id: Ia2f70363963dca9f035eff8d1ff0c399dc8b9239
2024-03-04 08:10:48 +00:00
Zuul 310a96a302 Merge "[ovn] Add support for enable_default_route_bfd attribute" 2024-03-01 23:04:54 +00:00
Zuul 40815c7086 Merge "Make common Metadata Driver classes" 2024-03-01 20:59:48 +00:00
Zuul afe001cf63 Merge "[OVN] Remove OVN_GATEWAY_INVALID_CHASSIS artifact" 2024-03-01 20:38:48 +00:00
Vasyl Saienko af91252646 Remove unneeded check in dhcp.py
We know what all list items are dicts, so remove isninstance
check in next line of code.

Change-Id: I51a95a351cc4322d4a53543f6ee3dcfa141eeadd
2024-03-01 17:36:32 +00:00
Zuul fffcab9f68 Merge "[ovn] Ensure OVN DB update on change of number of GW ports" 2024-03-01 12:43:55 +00:00
Zuul 6106eefdf8 Merge "[OVN][FT] Check ``WaitForCreatePortBindingEvent`` wait result" 2024-03-01 11:03:06 +00:00
Zuul 44159ca659 Merge "[OVN] Identify the LR GW port with "external_ids:neutron:is_ext_gw"" 2024-03-01 07:53:15 +00:00