Commit Graph

391 Commits

Author SHA1 Message Date
Zuul 15a4402c89 Merge "Update hacking version" 2024-02-12 13:09:52 +00:00
Brian Haley 542c2ff463 Update hacking version
Update hacking to a more recent version, along with
flake8-import-order.

Remove N347 (import mock library) check as that is the
default with later hacking versions.

Update the builtins override of '_' to be the neutron.i18n
version due to the code triggering a false positive. This
is done in a couple of other projects as well.

Fix a number of new warnings it found.

Added some ignore directives for new whitespace issues
found in the test tree, can fix later.

TrivialFix

Change-Id: I5923255af86cf1fa11ab8e3b03bb9efac7dd7b58
2024-02-08 10:34:10 -05:00
Takashi Kajinami 94ea289600 tox: Drop envdir
tox now always recreates an env although the env is shared using envdir
options.
~~~
$ tox -e genpolicy
genpolicy: recreate env because env type changed from
{'name': 'genconfig', 'type': 'VirtualEnvRunner'} to
{'name': 'genpolicy', 'type': 'VirtualEnvRunner'}
~~~

According to the maintainer of tox, this functionality is not intended
to be supported.
https://github.com/tox-dev/tox/issues/425#issuecomment-1011944293

Change-Id: Ibbb4ab56ca84f5a8f9fe309a46469d49ff4ef9f7
2024-02-03 00:02:41 +09:00
Brian Haley bd0fec95fa Use convert_version_to_tuple() throughout tree
Most code uses convert_version_to_tuple() from
oslo_utils.versionutils to determine minimum version
numbers, but there were two places that used the
packaging.version class instead. Change to always
use the same code throughout the tree.

Also added a flake8 enforcement check for it so we
don't regress.

TrivialFix

Change-Id: Ida4dcd504562646f0a450160e57680a44c387b1d
2023-10-20 18:03:21 -04:00
Rodolfo Alonso Hernandez 26a2266cf4 [FT] Move ``BaseOVSTestCase`` class to concurrency 1 executor
Move the ``BaseOVSTestCase`` class tests to the stestr executor with
concurrency=1. That will prevent that the minimum bandwidth tests
interfere among them.

Closes-Bug: #2025740
Change-Id: Ia3741abe5fa0c8ff65cf36d1ec31c089a1759f05
2023-07-03 18:46:20 +00:00
Brian Haley ed274efcf7 Update pylint version
It has been over 2 years since we set the version of
pylint and associated tools in tox.ini, update to
something newer, specifically:

  bashate>=2.1.1
  bandit>=1.7.5
  flake8-import-order==0.18.2
  pylint==2.17.4

This required disabling additional checks for new
warnings that were found, and adding a directive to
add the "no-self-use" plugin that is now required
with the newer version.

Will work on fixing new warnings and re-enabling
checks in subsequent patches.

Trivialfix

Change-Id: I5d74d47ac1d8a085b447ff531d7abbecfb4cce6e
2023-05-17 23:04:24 -04:00
yatinkarel e374b82d8f [CI][fullstack/functional] Report slowest tests
Would be good to see the slowest tests in the
report after test finishes.

Change-Id: I59bf1e53d4b63e31494890fcb313380698d6f88d
2023-04-12 20:37:32 +05:30
Miro Tomaska 04d3f889ef Fix metadata agent intermittent test failures
Metadata agent has been experiencing intermittent failures
mostly because of test conccurency and how the metadata agent
code assumes its the only process running on the system and
operating on the ovnmeta-* namespaces. See comment#1 the
linked bug for more details. Although I dont like forcing
--concurrency 1 for this test class, I think that is going
to be the best solution and any new tests that will be added
in the future.

Closes-Bug: #2011377
Change-Id: Ie7f3b496de6b23be5739fbeba10f53602e8b300d
2023-03-16 11:09:10 -05:00
yatinkarel d59bf5ff6c Temporary update envlist for tox4
tox4 even when running specific env with -e option tries
to find python version for all envs defined in envlist[1]
when running with --skip-missing-interpreters=false and
fails if interpreter missing for any of the env.

With py38 in envlist it tries to find python3.8
which is not available in ubuntu-jammy by default
and fails, hence use generic version instead i.e py3
to handle it.

Once [1] is fixed we can update the list as per
default supported py3 version for a release.

[1] https://github.com/tox-dev/tox/issues/2811

Change-Id: I3afc539c59f223338920d7fd59f0df76e842ece1
2023-01-06 14:10:38 +05:30
Zuul 537ecce96c Merge "Remove deprecated "list_moved_globals" script" 2022-12-23 15:55:55 +00:00
Rodolfo Alonso Hernandez 44ad4bb517 Remove deprecated "list_moved_globals" script
This script was deprecated in 2016 [1].

[1]https://review.opendev.org/c/openstack/neutron/+/394201

Change-Id: I926d2a3ac0149c3e43dd14918521b088494afae8
2022-12-11 19:58:29 +01:00
Rodolfo Alonso Hernandez 8bcaf1632f Limit tox version to <4
This patch is a workaround until we find why fullstack job is failing
with tox 4.

Depends-On: https://review.opendev.org/c/zuul/zuul-jobs/+/866943

Related-Bug: #1999558
Change-Id: I9c62d429bb819336da05055fecd08e3816986bf8
2022-12-10 20:43:54 +01:00
Rodolfo Alonso Hernandez 405414772e Fix tox.ini for tox4
Execute shell scripts with bash.
Make sure passenv is line-separated.

Change-Id: I5bb5f8d0f534022917e3f62e45413c4ac7a4708a
2022-12-08 17:19:58 -05:00
Rodolfo Alonso Hernandez ff66ca9275 Execute functional test "test_get_all_devices" alone
Since [1], the functional tests are being executed in Ubuntu 22.04.
The test "test_get_all_devices" is failing frequently, maybe because
other tests are interfering and modifying the root namespace
interface list.

Because this test cannot be executed inside a temporary namespace,
this patch moves the execution of this test to the section of
"concurrency=1". That will ensure no other test interferes the
result.

Closes-Bug: #1997341

Change-Id: If0631bf0cdfd5f0989c60d40e31f89cee317e497
2022-11-16 01:40:03 +01:00
Brian Haley 9e2a0ac058 Use --exclude-regex in tox.ini
--black-regex has been deprecated and using it can sometimes
cause failures in the fullstack job.

Change-Id: Iac1d4c4004e1348ced388ee4dd44711f0e27bcc2
Closes-bug: #1995901
2022-11-07 18:46:30 -05:00
Slawek Kaplonski e2617ccbc2 Add dsvm-functional-gate tox environment
In the neutron gate we want to run functional tests in 2 steps:
* all tests except MySQL and PostgreSQL tests,
* MySQL and PostgreSQL tests runs serially

And that was done like that in the dsvm-functional tox environment.
But there is no really point to run it as such always when someone
e.g. runs some tests from the functional tests suite locally, using
dsvm-functional environment.
So this patch adds dsvm-functional-gate environment which will be used
in the Zuul jobs and will have this 2 steps configuration.
Regular dsvm-functional env will run all tests together.

Change-Id: Ic66d9961393d9dff64ebd14802ad38c18808b1da
2022-09-07 12:19:05 +02:00
elajkat 119b82f1b1 Test: mock out _check_netfilter_for_bridges in unit tests
_check_netfilter_for_bridges do some calls which are not for unit tests.
Specifically the call for sysctl -N net.bridge seems to be broken with
a recent kernel upgrade on bionic (see the irc log for this discussion
in [1]).
Add OS_TEST_TIMEOUT:180 to tox testenv, this can help to debug such
issues.
During the rootwrap to privsep change some of these mocks were added,
(see [2]) so backporting (before Wallaby mostly) can be done with
caution.

[1]: https://meetings.opendev.org/irclogs/%23openstack-infra/%23openstack-infra.2022-07-20.log.html#t2022-07-20T12:59:32
[2]: https://review.opendev.org/c/openstack/neutron/+/764015/12/neutron/tests/unit/agent/linux/openvswitch_firewall/test_iptables.py

Change-Id: Ic366d67770cc6e19a4412eaf2f1ab53780e98ee8
Closes-Bug: #1982206
2022-07-22 07:54:12 +02:00
Rodolfo Alonso Hernandez d3ce69b946 [FT] Run all .*MySQL and .*PostgreSQL tests in an isolated thread
Similar to [1], this patch moves the PostgreSQL tests to a second
test execution step, where all tests are executed with one single
worker, avoiding any parallel execution on the SQL tests.

[1]https://review.opendev.org/c/openstack/neutron/+/834746

Closes-Bug: #1980127
Related-Bug: #1962594
Change-Id: I3a9f665653c3e2a5f75175867a45391e6ad01176
2022-06-29 15:03:33 +00:00
yatinkarel 7f5fb86232 Switch Fips fullstack/functional tests to py3.8
Master has dropped py3.6 support so upper-constraints
requirements are not installable with python3.6
and due to this fips jobs which are running on py3.6
are failing. Let's run the functional/fullstack tests
with python3.8 on CentOS 8-Stream itself.

Also disable dbcounter installation as it's not
installing on python3.6.
The hacks can be cleaned up when these jobs are
switched to CentOS 9-Stream, currently have some
issues as mentioned in the Related Bug.

Depends-On: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/843989
Related-Bug: #1976323
Change-Id: I757dbf929cb1dc27027614bbb2147a61606f85a9
2022-05-31 06:03:49 +00:00
Ghanshyam Mann bc8e512b4a Drop lower-constraints.txt and its testing
As discussed in TC PTG[1] and TC resolution[2], we are
dropping the lower-constraints.txt file and its testing.
We will keep lower bounds in the requirements.txt file but
with a note that these are not tested lower bounds and we
try our best to keep them updated.

[1] https://etherpad.opendev.org/p/tc-zed-ptg#L326
[2] https://governance.openstack.org/tc/resolutions/20220414-drop-lower-constraints.html#proposal

Change-Id: If17736114adedf44b502fd7c91423a7822d7170b
2022-05-02 13:01:42 -05:00
yatinkarel 2a8187124b Docs build: Add NOTE to not remove requirements.txt
To avoid unintentionally remove requirements.txt
from deps list from docs env, add a NOTE.

Change-Id: I6ec150a8f31bf841f1c8829719a0f08df531e53a
2022-04-29 12:15:11 +05:30
yatinkarel f15baf16dd Docs build: Add requirements.txt to deps
Since we use usedevelop=True, as a result neutron
installation happens at 'develop-inst' phase and it installs
requirements from requirements.txt without considering
tox constraints, This can lead to issue where broken
requirements are installed in docs job and as a result
it will fail.

In order to get constraints be considered for this case, add
requirements.txt to deps for docs env.

Change-Id: Ic8f6472fe708d12f8fc129729465367083e1095a
2022-04-28 20:21:32 +05:30
yatinkarel 9b66e81d2e Also add B324 to bandit skip list for python3.9+
For Python>=3.9 we also need to skip B324[1] for
hashlib.sha1 usage. For older python3 versions
B303[2] was enough.

[1] https://github.com/PyCQA/bandit/commit/c4372a09
[2] https://review.opendev.org/c/openstack/neutron/+/592884

Closes-Bug: rhbz#2074383
Change-Id: If4e7e550fd63414226098af16d1cc155aaa6c57a
2022-04-12 12:23:05 +05:30
Rodolfo Alonso Hernandez 7d5ee7089b [FT] Run all .*MySQL tests in an isolated thread
This change in the "dsvm-functional" job definition will avoid the
parallel execution of any MySQL test.

Related-Bug: #1962594
Change-Id: I4fe6a6920b9b2711563e85b51f18a9d5a9086ceb
2022-03-23 15:24:51 +00:00
Rodolfo Alonso Hernandez 4a66adf94c Group execution of SQL functional tests
Functional SQL tests (MySQL and PostgreSQL) use the DB installed
backend. To avoid overloading the DB engine, the test cases are
grouped [1] together and executed by the same worker process.
That will ensure those tests are not executed in parallel,
interfering each other.

All test classes ended in "MySQL" or "PostgreSQL" are now grouped.
That means the tests implemented inside the same class are
executed in the same worker, not in parallel. **HOWEVER**, that
doesn't guarantee all test cases using the same database backend
will run in the same worker serially. The FT job can still execute
test cases from different classes, using the same DB backend,
in two workers at the same time.

This patch also fixes the ``TestReservation*`` classes to inherit
from the parent classes in the correct order. That sets the
"DRIVER" value to the expected one "mysql" or "postgresql".

[1]https://review.opendev.org/c/openstack/neutron/+/785568

Closes-Bug: #1962594
Related-Bug: #1687027
Change-Id: I6bca7daf4d3e46071686bb62d5988ae314af8e7e
2022-03-03 12:10:56 +00:00
shanyunfan33 374aac1cbd Use TOX_CONSTRAINTS_FILE
UPPER_CONSTRAINTS_FILE is old name and deprecated
This allows to use upper-constraints file as more
readable way instead of UPPER_CONSTRAINTS_FILE=<lower-constraints file>.

Change-Id: Iae53ccf077796eb0d2518b41d0e262d564e7af10
2021-12-24 10:44:01 +08:00
Rodolfo Alonso Hernandez a27bb19e74 Reduce the fullstack concurrency to 2
In order to mitigate the OOM problems in the CI, this patch reduces
the fullstack concurrency to 2. That should reduce the memory
consumption and will avoid those nasty OOM exceptions.

Closes-Bug: #1938455
Change-Id: I4de4b089e615353b7fde82bd54e0abefa244c8ab
2021-07-29 15:45:38 +00:00
Rodolfo Alonso Hernandez a660f77d38 Remove "mitogen" library installation from "docs" job
Since pyroute 0.6.2, this dependency is not needed anymore. The
pyroute version is bumped both in requirements and doc/requirements.

This patch bumps the pyroute2 version to 0.6.4 (newest version
provided in upper-requirements).

Change-Id: I627e902e32fe59c6829c3bc92af19abff4b70f9a
Related-Bug: #1928913
2021-06-07 12:39:28 +00:00
Takashi Natsume 05ee23ea15 Follow up for replacing assertItemsEqual
The assertItemsEqual has been replaced with assertCountEqual
since I7c20fec08e5dc9f67b34100c925ea6724bbd25f0 .
However the hacking check has not been enabled.

This patch enables the hacking check
and replace remaining assertItemsEqual with assertCountEqual.

Signed-off-by: Takashi Natsume <takanattie@gmail.com>
Change-Id: I86202f36f1b7c0bce8b29558ad1e377c336b7258
2021-06-03 16:04:07 +00:00
Takashi Natsume ab0895fdf4 Change minversion of tox to 3.18.0
The patch bumps min version of tox to 3.18.0 in order to
replace whitelist_externals with allowlist_externals option.
https://github.com/tox-dev/tox/blob/master/docs/changelog.rst#v3180-2020-07-23

Signed-off-by: Takashi Natsume <takanattie@gmail.com>
Change-Id: If304d7c277850470448ca9bcd0f0bfd250ec001d
2021-05-21 08:06:40 +00:00
Slawek Kaplonski a75fc891bc Add mitogen to the docs requirements
Mitogen is dependency of the pyroute2 and was added link to it
the docs in pyroute2 0.6.1. Due to the missing mitogen in our
docs venv, docs job was failing.
So let's install mitogen as docs env requirement, at least for now
to unblock our gate.
Later we can think about better solution as e.g. adding it properly to
the requirements or report and fix the issue in the pyroute2.

Change-Id: Iba37581916842bb5fc9f42f7f483d3431747bf8d
Closes-Bug: #1928913
2021-05-20 09:00:40 -04:00
Rodolfo Alonso Hernandez 7326fd622f Group execution of SQL functional tests
Functional SQL tests (MySQL and PostgreSQL) use the DB installed
backend. To avoid overloading the DB engine, the test cases are
grouped [1] together and executed by the same worker process. That
will ensure those tests are not executed in parallel, interfering
each other.

Classes that are grouped:
- TestModelsMigrationsMysql
- TestModelsMigrationsPsql

[1]https://stestr.readthedocs.io/en/latest/MANUAL.html#group-regex

Related-Bug: #1687027

Change-Id: If04e360c01cdb16e956d16357e2181db55445137
2021-04-09 09:52:11 +00:00
Zuul 1f74030e66 Merge "Follow-up: Move linters dependencies to tox.ini" 2021-03-08 17:44:12 +00:00
Zuul 6571ff2286 Merge "Ignore python warnings in the fullstack job" 2021-03-03 21:38:44 +00:00
Slawek Kaplonski 14955f93f6 Ignore python warnings in the fullstack job
If there is too much output produced to the stdout/stderr during the
tests, stestr can hangs and job will then time out.
To avoid that in fullstack job, this patch is doing the same what
was already done for functional job as well - set PYTHONWARNINGS
variable to "ignore" to ignore all warnings and not send them to stdout.
All info really needed to debug tests is still in the tests' logs in
specific directories.

Change-Id: I080381cb8a88a27130ac21c0e27fc915e38bdedd
2021-03-02 15:34:21 +01:00
Slawek Kaplonski d9542b6a01 Reduce number of the workers in fullstack gate job
Fullstack job is using different tox env in the gate
(dsvm-fullstack-gate). To reduce memory usage in that job, some
time ago, in patch [1] we reduced number of test workers from 4
to 3. But it was done for "dsvm-fullstack" tox env, not for
"dsvm-fullstack-gate" thus it had no effect on our CI runs.
Now it is changed also in the CI job's tox env.

[1] https://review.opendev.org/c/openstack/neutron/+/764907

Change-Id: Iec949922be0779a00bf405c2f1d5646c588d323c
Related-Bug: #1906366
2021-03-02 09:47:08 +01:00
Akihiro Motoki d64c25c019 Follow-up: Move linters dependencies to tox.ini
After commit 89e2fad8ef,
pep8/bandit/bashate tox envs have different dependencies than
the default tox env. If tox envs with different dependencies share
some common envdir, tox env will be recreated every time a different
tox env is specified. (For example, "tox -e cover" after "tox -e pep8"
recreates the tox env.)

To address it, this commit introduces a new common envdir for linters
(envdir = {toxworkdir}/lint). It also moves deependencies of bashate
and bandit envs to pep8 env to ensure these three tox envs have the
same dependencies.

Cleanups are also made in test-requirements and lower-constraints.
* astroid and isort can be dropped from test-requirements.txt
  as pylint has proper version cappings for astroid and isort.
  (These cappings are available in pylint 2.5 and later.)
* reno is a document dependency, so it is unnecessary in test-requirements.
* reno, astroid and isort are dropped from lower-constraints
  as they are not installed in lower-constraints tests.

Change-Id: Iaa3168764d050875e3d08784aee2dfba809e53be
2021-01-07 04:26:07 +09:00
Bernard Cafarelli 89e2fad8ef
Move linters dependencies to tox.ini
Another item noted with the new pip resolver [1], linters dependencies
in test-requirements.txt may cause resolver issues (trying to pull in
enum34), conflicting requirements and cause them to be installed for all
test jobs. Move them to tox.ini as was done for some projects already
(this may be backported/squashed with pip resolver fix in stable
branches depending on how fixing these will go).

[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019362.html

Change-Id: I0111c41bea6a6caf5ffba1f5c34489854d9c9747
2020-12-17 11:32:03 +01:00
Slawek Kaplonski f63dc09206 Limit usage of resources in the fullstack tests job
To limit usage of resources (mostly memory) in the fullstack job and
to avoid oom killer to kill e.g. mysqld service, this patch:

* Makes number of API workers changeable by tests, as a parameter to
  EnvironmentDescription and defaults its value to 1. As neutron server
  is spawned separately for each test and is used only to process just
  few API requests during that single test so this should be still
  enough there, and where more API workers are needed (like some dhcp HA
  tests: TestDhcpAgentHARaceCondition) it can be changed,
* reduces number of test run workers from 4 to 3 - job will run slower
  but hopefully more stable,
* in the functional and fullstack tests job definition disable etcd3
  service - this will not save us a lot of memory but still it's not
  needed at all so why to run it there.

Change-Id: If19803ab6db144e2d17d6805d379c1c76d8fa343
Closes-Bug: #1906366
2020-12-10 10:10:01 +00:00
Bernard Cafarelli 8d6c301301
Update requirements for recent pip failures
Bump astroid test requirement to 2.4.0
Older versions trigger an error on wrapt dependency:
https://github.com/PyCQA/astroid/issues/755

Bump pylint accordingly to new astroid

Fix some new PEP8 warnings appearing with new versions, and filter out
the larget I202 "Additional newline in a group of imports" one for now

Drop psutil from functional requirements, it indicated an old version
and we have it in common requirements now

Bump a series of lower-constraints and requirements to work with new pip
resolver, testing with steps outlined at:
http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019285.html
This includes eventlet 0.22.1, previous versions triggered a hard to
track error on enum34
Cap cryptography in lower-constraints to prevent discovery failure in
relevant job (other jobs have it capped via upper-constraints)

Change-Id: Ie74ea517a403e6e2a7a4e0a245dd20e5281339e8
Closes-Bug: #1907242
2020-12-09 13:17:51 +01:00
wu.shiming a1d89e6f0e Remove install unnecessary packages
The docs and releasenotes requirements migrated to doc/requirements.txt
we need not install things from requirements.txt.

Change-Id: I207be0b861c13bc6cf954b2247bb00546990bbf0
2020-09-14 12:03:43 +08:00
Brian Haley 055036ba2b Improve terminology in the Neutron tree
There is no real reason we should be using some of the
terms we do, they're outdated, and we're behind other
open-source projects in this respect. Let's switch to
using more inclusive terms in all possible places.

Change-Id: I99913107e803384b34cbd5ca588451b1cf64d594
2020-08-19 16:47:53 -04:00
Rodolfo Alonso Hernandez ddd5832323 Remove "six" library
Last step to remove "six" library usage in Neutron.

Change-Id: Idd42e0c51c8c3bd598c9cf91602596be238bccae
2020-07-28 16:55:52 +00:00
Hervé Beraud 3df1679658 Use unittest.mock instead of mock
The mock third party library was needed for mock support in py2
runtimes. Since we now only support py36 and later, we can use the
standard lib unittest.mock module instead.

Also enabled the hacking check that should have caught this, it
was missing from tox.ini along with most of the other in-tree
hacking checks we have added over the years.

Change-Id: Id91175d0db8b8edc72f0dd98925ddbf7415bb881
2020-06-17 14:42:03 +00:00
Akihiro Motoki 52e3fee5ef Switch to hacking 3.0.1
In hacking 2.0 or later, local-check-factory was removed as it is not
compatible with flake8 3.x and it is advised to use flake8's local
plugins [1]. neutron-lib provided a factory to register common hacking
rules, but it no longer works with hacking 2, so we need to define rules
defined in neutron-lib as flake8 local check plugin [2] explicitly.
This needs to be done in each neutron related project, so it is the
downside of the migration to hacking 2.x (I explored a way to continue
to use the factory but failed to find a good way to achieve this) but
I believe it is good to migrate the newer libraries.

* flake8ext decorator in neutron/hacking/checks.py is also replaced with
  hacking.core.flake8ext to avoid the copy-and-paste code.
* neutron-lib dependency is updated as neutron-lib 2.3 added hacking 3 support.
* Python modules related to coding style checks (listed in blacklist.txt in
  openstack/requirements repo) are dropped from lower-constraints.txt
  as they are not actually used in tests (other than pep8).
* HackingDocTestCase is now converted into normal test cases.
  HackingDocTestCase depends on the internal of hacking and pycodestyle
  so it looks better to use normal style of writing tests.

[1] https://docs.openstack.org/releasenotes/hacking/unreleased.html#relnotes-2-0-0
[2] https://flake8.pycqa.org/en/3.7.0/user/configuration.html#using-local-plugins

Change-Id: I92cf50a84bb587a0649a7cffee15cce4ce37d086
2020-05-12 16:58:41 -04:00
Sean McGinnis 783441ef1f
Bump default tox env from py37 to py38
Python 3.8 is now our highest level supported python runtime.
This updates the default tox target environments to swap out
py37 for py38 to make sure local development testing is
covering this version.

This does not impact zuul jobs in any way, nor prevent local
tests against py37. It just changes the default if none is
explicitly provided.

Change-Id: I4c60a7474da79da30122327ef3a6d8e87ccc4371
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2020-04-24 10:25:46 -05:00
Slawek Kaplonski 8456240e7d Run fullstack security group test always serially
Security groups are based on iptables in many cases and can interfere
between other tests. So it means that if some other test will manipulate
with iptables on host during SG related test is run, this SG related
test may fail without any obvious reason.
So lets try to run those test serially to be sure that no other agents
will manipulate iptables/openflow rules in same time.

Change-Id: I4d19f2a457e004306fdf40980a943073f1b8704a
Closes-Bug: #1779328
2020-03-03 15:18:18 +01:00
Daniel Bengtsson f8a3b2c589 Stop configuring install_command in tox.
Currently, we are overriding 'install_command' to use 'pip'. This is
considered poor behavior and 'python -m pip' should be used instead:

https://snarky.ca/why-you-should-use-python-m-pip/

It turns out that this is the the default value provided by tox:

https://tox.readthedocs.io/en/latest/config.html#conf-install_command

So we can remove the line and simply use the default value.
This change showed we needed a newer version of debtcollector in lower
constraints, aliging with the version required by os-vif. This change
showed we needed also a newer version of cffi and keystoneauth1 in lower
constraints. Update also the requirements file for debtcollector and
keystoneauth1.

Change-Id: I5e190c3db8bed0a264b911cdf425aa4c9b51f768
2020-01-28 11:07:40 +01:00
Zuul cfe31e8b47 Merge "Add a tox requirements target" 2019-12-18 18:19:19 +00:00
Elod Illes 07be793435 Use constraints for docs tox target
In Stein the docs target started to fail when new release of
neutron-lib appeared. This is because tox installs neutron and its
requirements without any constraints. To fix this both the upper
constraints and neutron requirements needs to be added to dependencies
of docs target.

Closes-Bug: #1856156
Change-Id: Iea61238f37fdf24c0264f96d104ee0b3b6aec8e2
2019-12-12 11:14:10 +01:00