openstack
/
nova
Code Issues Proposed changes

Merge "Convert delete_on_termination from string to boolean"

This commit is contained in:
Zuul 2020-04-09 10:28:58 +00:00 committed by Gerrit Code Review
parent 874c2fe329 98fbff8b4c
commit 2032fed94d
2 changed files with 50 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nova/api/openstack/compute/volumes.py
View File

@ -452,7 +452,8 @@ class VolumeAttachmentController(wsgi.Controller):
raise exc.HTTPBadRequest(explanation='The tag property is '
'not mutable')
if 'delete_on_termination' in att:
bdm.delete_on_termination = att['delete_on_termination']
bdm.delete_on_termination = strutils.bool_from_string(
att['delete_on_termination'], strict=True)
bdm.save()
except exception.VolumeBDMNotFound as e:
raise exc.HTTPNotFound(explanation=e.format_message())

48
nova/tests/unit/api/openstack/compute/test_volumes.py
View File

@ -1233,6 +1233,54 @@ class UpdateVolumeAttachTests(VolumeAttachTestsV279):
mock_bdm_save.assert_called_once()
self.assertTrue(vol_bdm['delete_on_termination'])
@mock.patch.object(compute_api.API, 'swap_volume')
@mock.patch.object(objects.BlockDeviceMapping,
'get_by_volume_and_instance')
@mock.patch.object(block_device_obj.BlockDeviceMapping, 'save')
def test_update_volume_with_bool_from_string(
self, mock_bdm_save, mock_get_vol_and_inst, mock_swap):
vol_bdm = objects.BlockDeviceMapping(
self.context,
id=1,
instance_uuid=FAKE_UUID,
volume_id=FAKE_UUID_A,
source_type='volume',
destination_type='volume',
delete_on_termination=True,
connection_info=None,
tag='fake-tag',
device_name='/dev/fake0',
attachment_id=uuids.attachment_id)
mock_get_vol_and_inst.return_value = vol_bdm
body = {'volumeAttachment': {
'volumeId': FAKE_UUID_A,
'tag': 'fake-tag',
'delete_on_termination': 'False',
'device': '/dev/fake0',
}}
self.attachments.update(self.req, FAKE_UUID,
FAKE_UUID_A, body=body)
mock_swap.assert_not_called()
mock_bdm_save.assert_called_once()
self.assertFalse(vol_bdm['delete_on_termination'])
# Update delete_on_termination to False
body['volumeAttachment']['delete_on_termination'] = '0'
self.attachments.update(self.req, FAKE_UUID,
FAKE_UUID_A, body=body)
mock_swap.assert_not_called()
mock_bdm_save.assert_called()
self.assertFalse(vol_bdm['delete_on_termination'])
# Update delete_on_termination to True
body['volumeAttachment']['delete_on_termination'] = '1'
self.attachments.update(self.req, FAKE_UUID,
FAKE_UUID_A, body=body)
mock_swap.assert_not_called()
mock_bdm_save.assert_called()
self.assertTrue(vol_bdm['delete_on_termination'])
@mock.patch.object(compute_api.API, 'swap_volume')
@mock.patch.object(objects.BlockDeviceMapping,
'get_by_volume_and_instance')