openstack
/
nova
Code Issues Proposed changes

Merge "Fix listing deleted servers with a marker" into stable/train

This commit is contained in:
Zuul 2019-10-24 22:39:49 +00:00 committed by Gerrit Code Review
parent 9eece6b117 03a2508362
commit 390db631ff
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
nova/objects/build_request.py
View File

@ -372,14 +372,16 @@ class BuildRequestList(base.ObjectListBase, base.NovaObject):
@base.remotable_classmethod
def get_by_filters(cls, context, filters, limit=None, marker=None,
sort_keys=None, sort_dirs=None):
if limit == 0:
return cls(context, objects=[])
# Short-circuit on anything that will not yield results.
# 'deleted' records can not be returned from here since build_requests
# are not soft deleted.
if filters.get('deleted', False):
return cls(context, objects=[])
# 'cleaned' records won't exist as they would need to be deleted.
if filters.get('cleaned', False):
if (limit == 0 or
filters.get('deleted', False) or
filters.get('cleaned', False)):
# If we have a marker honor the MarkerNotFound semantics.
if marker:
raise exception.MarkerNotFound(marker=marker)
return cls(context, objects=[])
# Because the build_requests table stores an instance as a serialized

4
nova/tests/functional/regressions/test_bug_1849409.py
View File

@ -59,6 +59,4 @@ class ListDeletedServersWithMarker(test.TestCase,
servers = self.api.get_servers(detail=False,
search_opts={'deleted': True,
'marker': server['id']})
# FIXME(mriedem): This is bug 1849409 where the marker param is not
# honored correctly when using deleted=True.
self.assertEqual(1, len(servers), servers)
self.assertEqual(0, len(servers), servers)