Merge "Add test coverage of existing security groups policies"
This commit is contained in:
commit
e4ac401d1a
|
@ -13,7 +13,6 @@
|
|||
# License for the specific language governing permissions and limitations
|
||||
# under the License.
|
||||
|
||||
import fixtures
|
||||
import mock
|
||||
from neutronclient.common import exceptions as n_exc
|
||||
from oslo_config import cfg
|
||||
|
@ -35,7 +34,6 @@ from nova import objects
|
|||
from nova.objects import instance as instance_obj
|
||||
from nova import test
|
||||
from nova.tests.unit.api.openstack import fakes
|
||||
from nova.tests.unit import fake_instance
|
||||
|
||||
CONF = cfg.CONF
|
||||
FAKE_UUID1 = 'a47ae74e-ab08-447f-8eee-ffd43fc46c16'
|
||||
|
@ -1579,90 +1577,6 @@ class SecurityGroupsOutputTest(test.TestCase):
|
|||
self.assertEqual(res.status_int, 404)
|
||||
|
||||
|
||||
class PolicyEnforcementV21(test.NoDBTestCase):
|
||||
|
||||
def setUp(self):
|
||||
super(PolicyEnforcementV21, self).setUp()
|
||||
self.req = fakes.HTTPRequest.blank('')
|
||||
self.rule_name = "os_compute_api:os-security-groups"
|
||||
self.rule = {self.rule_name: "project:non_fake"}
|
||||
context = self.req.environ['nova.context']
|
||||
self.mock_get = self.useFixture(
|
||||
fixtures.MockPatch('nova.api.openstack.common.get_instance')).mock
|
||||
self.instance = fake_instance.fake_instance_obj(
|
||||
context, id=1, project_id=context.project_id)
|
||||
self.mock_get.return_value = self.instance
|
||||
|
||||
def _common_policy_check(self, func, *arg, **kwarg):
|
||||
self.policy.set_rules(self.rule)
|
||||
exc = self.assertRaises(
|
||||
exception.PolicyNotAuthorized, func, *arg, **kwarg)
|
||||
self.assertEqual(
|
||||
"Policy doesn't allow %s to be performed." % self.rule_name,
|
||||
exc.format_message())
|
||||
|
||||
|
||||
class SecurityGroupPolicyEnforcementV21(PolicyEnforcementV21):
|
||||
|
||||
def setUp(self):
|
||||
super(SecurityGroupPolicyEnforcementV21, self).setUp()
|
||||
self.controller = secgroups_v21.SecurityGroupController()
|
||||
|
||||
def test_create_policy_failed(self):
|
||||
self._common_policy_check(self.controller.create, self.req, {})
|
||||
|
||||
def test_show_policy_failed(self):
|
||||
self._common_policy_check(self.controller.show, self.req, FAKE_UUID1)
|
||||
|
||||
def test_delete_policy_failed(self):
|
||||
self._common_policy_check(self.controller.delete, self.req, FAKE_UUID1)
|
||||
|
||||
def test_index_policy_failed(self):
|
||||
self._common_policy_check(self.controller.index, self.req)
|
||||
|
||||
def test_update_policy_failed(self):
|
||||
self._common_policy_check(
|
||||
self.controller.update, self.req, FAKE_UUID1, {})
|
||||
|
||||
|
||||
class ServerSecurityGroupPolicyEnforcementV21(PolicyEnforcementV21):
|
||||
|
||||
def setUp(self):
|
||||
super(ServerSecurityGroupPolicyEnforcementV21, self).setUp()
|
||||
self.controller = secgroups_v21.ServerSecurityGroupController()
|
||||
|
||||
def test_index_policy_failed(self):
|
||||
self._common_policy_check(self.controller.index, self.req, FAKE_UUID1)
|
||||
|
||||
|
||||
class SecurityGroupRulesPolicyEnforcementV21(PolicyEnforcementV21):
|
||||
|
||||
def setUp(self):
|
||||
super(SecurityGroupRulesPolicyEnforcementV21, self).setUp()
|
||||
self.controller = secgroups_v21.SecurityGroupRulesController()
|
||||
|
||||
def test_create_policy_failed(self):
|
||||
self._common_policy_check(self.controller.create, self.req, {})
|
||||
|
||||
def test_delete_policy_failed(self):
|
||||
self._common_policy_check(self.controller.delete, self.req, FAKE_UUID1)
|
||||
|
||||
|
||||
class SecurityGroupActionPolicyEnforcementV21(PolicyEnforcementV21):
|
||||
|
||||
def setUp(self):
|
||||
super(SecurityGroupActionPolicyEnforcementV21, self).setUp()
|
||||
self.controller = secgroups_v21.SecurityGroupActionController()
|
||||
|
||||
def test_add_security_group_policy_failed(self):
|
||||
self._common_policy_check(
|
||||
self.controller._addSecurityGroup, self.req, FAKE_UUID1, {})
|
||||
|
||||
def test_remove_security_group_policy_failed(self):
|
||||
self._common_policy_check(
|
||||
self.controller._removeSecurityGroup, self.req, FAKE_UUID1, {})
|
||||
|
||||
|
||||
class TestSecurityGroupsDeprecation(test.NoDBTestCase):
|
||||
|
||||
def setUp(self):
|
||||
|
|
|
@ -0,0 +1,108 @@
|
|||
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
||||
# not use this file except in compliance with the License. You may obtain
|
||||
# a copy of the License at
|
||||
#
|
||||
# http://www.apache.org/licenses/LICENSE-2.0
|
||||
#
|
||||
# Unless required by applicable law or agreed to in writing, software
|
||||
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
||||
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
||||
# License for the specific language governing permissions and limitations
|
||||
# under the License.
|
||||
|
||||
import fixtures
|
||||
import mock
|
||||
from oslo_utils.fixture import uuidsentinel as uuids
|
||||
from oslo_utils import timeutils
|
||||
|
||||
from nova.api.openstack.compute import security_groups
|
||||
from nova.compute import vm_states
|
||||
from nova.policies import security_groups as policies
|
||||
from nova.tests.unit.api.openstack import fakes
|
||||
from nova.tests.unit import fake_instance
|
||||
from nova.tests.unit.policies import base
|
||||
|
||||
|
||||
class SecurityGroupsPolicyTest(base.BasePolicyTest):
|
||||
"""Test Security Groups APIs policies with all possible context.
|
||||
This class defines the set of context with different roles
|
||||
which are allowed and not allowed to pass the policy checks.
|
||||
With those set of context, it will call the API operation and
|
||||
verify the expected behaviour.
|
||||
"""
|
||||
|
||||
def setUp(self):
|
||||
super(SecurityGroupsPolicyTest, self).setUp()
|
||||
self.controller = security_groups.ServerSecurityGroupController()
|
||||
self.action_ctr = security_groups.SecurityGroupActionController()
|
||||
self.req = fakes.HTTPRequest.blank('')
|
||||
user_id = self.req.environ['nova.context'].user_id
|
||||
self.mock_get = self.useFixture(
|
||||
fixtures.MockPatch('nova.api.openstack.common.get_instance')).mock
|
||||
uuid = uuids.fake_id
|
||||
self.instance = fake_instance.fake_instance_obj(
|
||||
self.project_member_context,
|
||||
id=1, uuid=uuid, project_id=self.project_id,
|
||||
user_id=user_id, vm_state=vm_states.ACTIVE,
|
||||
task_state=None, launched_at=timeutils.utcnow())
|
||||
self.mock_get.return_value = self.instance
|
||||
|
||||
# Check that admin or and server owner is able to operate
|
||||
# server security groups.
|
||||
self.admin_or_owner_authorized_contexts = [
|
||||
self.legacy_admin_context, self.system_admin_context,
|
||||
self.project_admin_context, self.project_member_context,
|
||||
self.project_reader_context, self.project_foo_context]
|
||||
# Check that non-admin/owner is not able to operate
|
||||
# server security groups.
|
||||
self.admin_or_owner_unauthorized_contexts = [
|
||||
self.system_member_context, self.system_reader_context,
|
||||
self.system_foo_context,
|
||||
self.other_project_member_context
|
||||
]
|
||||
|
||||
@mock.patch('nova.network.security_group_api.get_instance_security_groups')
|
||||
def test_get_security_groups_policy(self, mock_get):
|
||||
rule_name = policies.BASE_POLICY_NAME
|
||||
self.common_policy_check(self.admin_or_owner_authorized_contexts,
|
||||
self.admin_or_owner_unauthorized_contexts,
|
||||
rule_name,
|
||||
self.controller.index,
|
||||
self.req, self.instance.uuid)
|
||||
|
||||
@mock.patch('nova.network.security_group_api.add_to_instance')
|
||||
def test_add_security_groups_policy(self, mock_add):
|
||||
rule_name = policies.BASE_POLICY_NAME
|
||||
self.common_policy_check(self.admin_or_owner_authorized_contexts,
|
||||
self.admin_or_owner_unauthorized_contexts,
|
||||
rule_name,
|
||||
self.action_ctr._addSecurityGroup,
|
||||
self.req, self.instance.uuid,
|
||||
body={'addSecurityGroup':
|
||||
{'name': 'fake'}})
|
||||
|
||||
@mock.patch('nova.network.security_group_api.remove_from_instance')
|
||||
def test_remove_security_groups_policy(self, mock_remove):
|
||||
rule_name = policies.BASE_POLICY_NAME
|
||||
self.common_policy_check(self.admin_or_owner_authorized_contexts,
|
||||
self.admin_or_owner_unauthorized_contexts,
|
||||
rule_name,
|
||||
self.action_ctr._removeSecurityGroup,
|
||||
self.req, self.instance.uuid,
|
||||
body={'removeSecurityGroup':
|
||||
{'name': 'fake'}})
|
||||
|
||||
|
||||
class SecurityGroupsScopeTypePolicyTest(SecurityGroupsPolicyTest):
|
||||
"""Test Security Groups APIs policies with system scope enabled.
|
||||
This class set the nova.conf [oslo_policy] enforce_scope to True
|
||||
so that we can switch on the scope checking on oslo policy side.
|
||||
It defines the set of context with scoped token
|
||||
which are allowed and not allowed to pass the policy checks.
|
||||
With those set of context, it will run the API operation and
|
||||
verify the expected behaviour.
|
||||
"""
|
||||
|
||||
def setUp(self):
|
||||
super(SecurityGroupsScopeTypePolicyTest, self).setUp()
|
||||
self.flags(enforce_scope=True, group="oslo_policy")
|
Loading…
Reference in New Issue