summaryrefslogtreecommitdiff
path: root/nova/tests/functional/api/openstack/placement/gabbits/resource-classes-1-6.yaml
diff options
context:
space:
mode:
authorChris Dent <cdent@anticdent.org>2017-10-31 12:54:17 +0000
committerChris Dent <cdent@anticdent.org>2017-10-31 12:54:17 +0000
commitf974e3c3566f379211d7fdc790d07b5680925584 (patch)
tree738a33f38ac9b1063048da6c5570696b14a0df3c /nova/tests/functional/api/openstack/placement/gabbits/resource-classes-1-6.yaml
parent39e7ca322626f4b197de54e1ed83ce046c5fef26 (diff)
[placement] avoid case issues microversions in gabbits
If a gabbi file sets a default microversion by setting a header 'OpenStack-API-Version' with a value like 'placement latest' and then later overrides that in an individual test with a header of 'openstack-api-version' the difference in case can lead to failure. In the best case the failure is consistent. In the worst case it can sometimes work, because the header shows up twice in the request, and the last header wins, order in the headers and the resulting list dependent on the vagrancies of python ordering. The solution is to always use the same case, so this change updates all use to be lowercase, to establish a precedent that future people will be able to use as an example. Note that gabbi is case sensitive here in part because of the implementation but also because it provides the control and possibility to test exactly this problem. Change-Id: I1e89e231cf0d46d211d360cda091b33520f85027 Closes-Bug: #1728934
Notes
Notes (review): Code-Review+1: Eric Fried <efried@us.ibm.com> Code-Review+2: Balazs Gibizer <balazs.gibizer@ericsson.com> Code-Review+2: Jay Pipes <jaypipes@gmail.com> Workflow+1: Jay Pipes <jaypipes@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 01 Nov 2017 01:26:45 +0000 Reviewed-on: https://review.openstack.org/516662 Project: openstack/nova Branch: refs/heads/master
Diffstat (limited to 'nova/tests/functional/api/openstack/placement/gabbits/resource-classes-1-6.yaml')
-rw-r--r--nova/tests/functional/api/openstack/placement/gabbits/resource-classes-1-6.yaml2
1 files changed, 1 insertions, 1 deletions
diff --git a/nova/tests/functional/api/openstack/placement/gabbits/resource-classes-1-6.yaml b/nova/tests/functional/api/openstack/placement/gabbits/resource-classes-1-6.yaml
index 30f250d..9975aa6 100644
--- a/nova/tests/functional/api/openstack/placement/gabbits/resource-classes-1-6.yaml
+++ b/nova/tests/functional/api/openstack/placement/gabbits/resource-classes-1-6.yaml
@@ -8,7 +8,7 @@ defaults:
8 x-auth-token: admin 8 x-auth-token: admin
9 accept: application/json 9 accept: application/json
10 content-type: application/json 10 content-type: application/json
11 OpenStack-API-Version: placement 1.6 11 openstack-api-version: placement 1.6
12 12
13tests: 13tests:
14 14