Adjust the fixtures used by the functional tests so they
use placement database and web fixtures defined by placement
code. To avoid making redundant changes, the solely placement-
related unit and functional tests are removed, but the placement
code itself is not (yet).
openstack-placement is required by the functional tests. It is not
added to test-requirements as we do not want unit tests to depend
on placement in any way, and we enforce this by not having placement
in the test env.
The concept of tox-siblings is used to ensure that the
placement requirement will be satisfied correctly if there is a
depends-on. To make this happen, the functional jobs defined in
.zuul.yaml are updated to require openstack/placement.
tox.ini has to be updated to use a envdir that is the same
name as job. Otherwise the tox siblings role in ansible cannot work.
The handling of the placement fixtures is moved out of nova/test.py
into the functional tests that actually use it because we do not
want unit tests (which get the base test class out of test.py) to
have anything to do with placement. This requires adjusting some
test files to use absolute import.
Similarly, a test of the comparison function for the api samples tests
is moved into functional, because it depends on placement functionality,
TestUpgradeCheckResourceProviders in unit.cmd.test_status is moved into
a new test file: nova/tests/functional/test_nova_status.py. This is done
because it requires the PlacementFixture, which is only available to
functional tests. A MonkeyPatch is required in the test to make sure that
the right context managers are used at the right time in the command
itself (otherwise some tables do no exist). In the test itself, to avoid
speaking directly to the placement database, which would require
manipulating the RequestContext objects, resource providers are now
created over the API.
Co-Authored-By: Balazs Gibizer <balazs.gibizer@ericsson.com>
Change-Id: Idaed39629095f86d24a54334c699a26c218c6593
The tests are very straightforward and do not require any of the setup
and fixtures that nova.test.NoDBTestCase supplies. Also, in the future
of placement extraction we don't want the dependecy.
Partially implements blueprint placement-extract
Change-Id: Ib917601a61b896e7ed86e0cd189c442ffaf883b3
In the review of I4215cc69cedae5637102b75e0b54fd26acb1826c there
were some suggested improvements that did not get implemented
because we needed the better logging sooner than later.
This change implements those cleanups including:
* use ',' instead of '%' for string interpolation in calls to LOG
* add microversion information to log string, if present
Change-Id: I6682215d72b644217b5122073d993a99f7830e5b
Closes-Bug: #1619690
This change moves the request logging in the placement api to
middleware that is the outermost piece of middleware in the system.
Without this we end up with a situation where some requests which
are not successful appear to be logged with success and other
request do not get logged at all.
By using middleware we assure that the logging of the beginning of
the request and _any_ exit of the request will be logged because the
middleware can be the first and last thing the request interacts
with.
Change-Id: I4215cc69cedae5637102b75e0b54fd26acb1826c
Closes-Bug: #1619690
Chris Dent