openstack
/
octavia-tempest-plugin
Code Issues Proposed changes

Fix timezones in certificate revocation list dates 

While generating certificate revocation list, dates were generated with
an incorrect TZ information. Depending on the TZ of host, some tests
failed because last update was in the future.

Using datetime.utcnow() for dates fixes the issue.

Change-Id: I2ff30c1a65e07b409aba211d1c60760355bfebbe
This commit is contained in:
Gregory Thiemonge 2019-12-10 19:24:10 +01:00
parent 360d697c8d
commit e474c3e6ff
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
octavia_tempest_plugin/common/cert_utils.py
View File

@ -202,14 +202,14 @@ def generate_certificate_revocation_list(ca_cert, ca_key, cert_to_revoke):
"""
crl_builder = x509.CertificateRevocationListBuilder()
crl_builder = crl_builder.issuer_name(ca_cert.subject)
crl_builder = crl_builder.last_update(datetime.datetime.today())
crl_builder = crl_builder.next_update(datetime.datetime.today() +
crl_builder = crl_builder.last_update(datetime.datetime.utcnow())
crl_builder = crl_builder.next_update(datetime.datetime.utcnow() +
datetime.timedelta(1, 0, 0))
revoked_cert = x509.RevokedCertificateBuilder().serial_number(
cert_to_revoke.serial_number
).revocation_date(
datetime.datetime.today()
datetime.datetime.utcnow()
).build(default_backend())
crl_builder = crl_builder.add_revoked_certificate(revoked_cert)