openstack
/
openstack-ansible-os_ceilometer
Code Issues Proposed changes

Remove unnecessary package install duplication 

Currently the devel packages are installed everywhere,
but they only need to be where the wheels are built.

Also, there is already a task to install the packages
needed on the target hosts when installing - so we do
not need to give the same list to the venv install role
because they will already have been installed.

Change-Id: I8d13d6c59cdce3f9ff7642a6b92444b473ccec6d
This commit is contained in:
Jesse Pretorius 2018-10-30 19:19:08 +00:00
parent 6966132007
commit eaf29823b4
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tasks/ceilometer_install_source.yml
View File

@ -42,7 +42,6 @@
vars:
venv_build_distro_package_list: "{{ ceilometer_devel_distro_packages }}"
venv_install_destination_path: "{{ ceilometer_bin | dirname }}"
venv_install_distro_package_list: "{{ ceilometer_distro_packages }}"
venv_pip_install_args: "{{ ceilometer_pip_install_args }}"
venv_pip_packages: "{{ (ceilometer_oslomsg_amqp1_enabled | bool) | ternary(ceilometer_pip_packages + ceilometer_optional_oslomsg_amqp1_pip_packages, ceilometer_pip_packages) }}"
venv_facts_when_changed:

2
vars/source_install.yml
View File

@ -14,7 +14,7 @@
# limitations under the License.
ceilometer_package_list: |-
{% set packages = (ceilometer_distro_packages + ceilometer_devel_distro_packages) %}
{% set packages = (ceilometer_distro_packages) %}
{% if ceilometer_oslomsg_amqp1_enabled | bool %}
{% set _ = packages.extend(ceilometer_oslomsg_amqp1_distro_packages) %}
{% endif %}