ansible-linters fixes

https://review.openstack.org/#/c/485259/ is throwing linters problems related
to this role. I think all of them are fixed with this patch

Change-Id: If3924bb1b7823a9c70edf68d0127b9415885a2d9
This commit is contained in:
Manuel Buil 2017-07-21 09:05:16 +02:00
parent 27991691da
commit c1f38edcea
5 changed files with 6 additions and 16 deletions

View File

@ -23,6 +23,7 @@ verbose: True
# Set the package install state for distribution packages
# Options are 'present' and 'latest'
tacker_package_state: "latest"
tacker_pip_package_state: "latest"
tacker_git_repo: https://git.openstack.org/openstack/tacker
tacker_git_install_branch: master

View File

@ -30,7 +30,7 @@
- name: Check init system
command: cat /proc/1/comm
register: _pid1_name
changed_when: false
changed_when: False
tags:
- always

View File

@ -13,14 +13,13 @@
# See the License for the specific language governing permissions and
# limitations under the License.
# TODO(mbuil): Fix the ansible lint
- name: Perform a tacker DB sync
command: "{{ tacker_bin }}/tacker-db-manage
--config-file {{ tacker_etc_dir }}/tacker.conf upgrade head"
become: yes
become_user: "{{ tacker_system_user_name }}"
changed_when: False
tags:
- tacker-db-sync
- tacker-setup
- tacker-command-bin
- skip_ansible_lint

View File

@ -26,14 +26,8 @@
notify:
- Restart tacker services
# TODO(mbuil): Fix the ansible lint
# probably replace shell by command
- name: Reload init scripts
shell: |
initctl reload-configuration
command: initctl reload-configuration
when: upstart_init | changed
notify:
- Restart tacker services
tags:
- skip_ansible_lint

View File

@ -51,12 +51,10 @@
when:
- not tacker_developer_mode | bool
# TODO(mbuil): Fix the ansible lint
# Hint: latest should be a var.
- name: Install requires pip packages
pip:
name: "{{ tacker_requires_pip_packages | join(' ') }}"
state: latest
state: "{{ tacker_pip_package_state }}"
extra_args: "{{ pip_install_options_fact }}"
register: install_packages
until: install_packages|success
@ -115,12 +113,10 @@
notify:
- Restart tacker services
# TODO(mbuil): Fix the ansible lint
# hint: latest should be a var.
- name: Install pip packages
pip:
name: "{{ tacker_pip_packages | join(' ') }}"
state: latest
state: "{{ tacker_pip_package_state }}"
virtualenv: "{{ tacker_bin | dirname }}"
virtualenv_site_packages: "no"
extra_args: "{{ pip_install_options_fact }}"