openstack
/
openstack-ansible-pip_install
Code Issues Proposed changes

Ensure that pip.conf templates variables properly 

When a user provides values other than the defaults for
upgrade/pre, they may not format it in a way that pip
interprets properly. To ensure that we template the
conf file correctly, we ensure that it's interpreted
as a boolean, then make it lower case as is expected by
pip.

Change-Id: I91590665cd2d878b6b5ef92d1118610bb4a3fd84
This commit is contained in:
Jesse Pretorius 2018-04-20 13:03:56 +01:00
parent 70c6e23bcc
commit b9d90b5e81
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
templates/pip.conf.j2
View File

@ -13,9 +13,9 @@ trusted-host =
{% endif %}
[install]
upgrade = {{ pip_upgrade }}
upgrade = {{ (pip_upgrade | bool) | lower }}
upgrade-strategy = {{ pip_upgrade_strategy }}
pre = {{ pip_enable_pre_releases }}
pre = {{ (pip_enable_pre_releases | bool) | lower }}
{% if pip_links | length > 0 %}
find-links =
{% for pip_link in pip_links %}