It makes no sense to use become when you're connecting to a
host via the root remote_user. As such, we remove all uses of
'become: true' from the test plays with the exception of the
'test-prepare-keys.yml' playbook which uses a local connection
rather than a remote one and it therefore needs to use become.
We also transition all plays to use 'remote_user' which is the
correct parameter to replace 'user' (since ansible 1.4).
Finally, we switch the horizon nova service setup to its own
playbook using a local connection and the upstream keystone
modules.
Change-Id: I20517c22f07b1bb811a51d8c63741604360fe7f8
There is no record for why we implement the MQ vhost/user creation
outside of the role in the playbook, when we could do it inside the
role.
Implementing it inside the role allows us to reduce the quantity of
group_vars duplicated from the role, and allows us to better document
the required variables in the role. The delegation can still be done
as it is done in the playbook too.
In this patch we remove the test-vars which were duplicated from the
role, and remove the MQ setup tasks as they are no longer required.
We also remove the usage of a variable for the role name as that is
unnecessary legacy.
Depends-On: https://review.openstack.org/568517
Change-Id: I516e65e3b49f1722636d69f80c1bddc01c942a48
With the merge of https://review.openstack.org/569061 the
roles which do not have the rabbitmq_all group are failing
with messages like:
'dict object' has no attribute 'rabbitmq_all'
This patch ensures that the tasks are only activated if the
inventory group is present and populated.
Change-Id: I8f9004147753bb7f8121e344379417a6d6e2e807
There is no record for why we implement the database creation outside
of the role in the playbook, when we could do it inside the role.
Implementing it inside the role allows us to reduce the quantity of
group_vars duplicated from the role, and allows us to better document
the required variables in the role. The delegation can still be done
as it is done in the playbook too.
In this patch we remove the test-vars which were duplicated from the
role, and remove the DB setup tasks as they are no longer required.
Change-Id: I0dfe0bd8316ff7c1db916aa8e8d6c13d0715b30d
Depends-On: https://review.openstack.org/568481
With the merge of https://review.openstack.org/559127 the roles
which do not yet have the oslomsg_rpc_all/oslomsg_notify_all
groups are failing with messages like:
'dict object' has no attribute 'oslomsg_rpc_all'
'dict object' has no attribute 'oslomsg_notify_all'
This patch puts the old ensure-rabbitmq.yml task include back
and activates it when these groups are not defined.
Change-Id: I90dcd122fbc96f7737363dd353b50a516122667a
This commit contains updates to introduced oslo.messaging
service in place of rabbitmq server.
This patch:
* Add ensure oslo.messaging vhost and user for backend
* Update service role installs
* Add oslo.messaging settings to test-vars
Change-Id: Ie69d522ee2df4282ce4fc69c2b3f81f4df1da77d
Sometimes a test will result in a failure, but it
takes more time than necessary to find the failure
due to Ansible continuing to execute on other hosts
after removing one from the play execution.
This patch ensures that any error will result in
an immediate failure so that the fatal error is
easier to find.
Change-Id: I4e89bfdb1e48d0ac65f9fb8549e55a19ab773f9f
The swift role includes tasks that delegate to the physical host of
containers (localhost in gate tests). Since ansible_become was removed
from localhost's vars, set become in this play to fix tests that install
swift.
Also add the become option to all other plays to avoid this issue for
any other roles that may now or in the future delegate tasks to localhost.
Change-Id: I08cada62636a1a7a1e2c1b15e0052876437e24aa
Neither the rabbit, nor galera common tasks use
the hostname var that was defined, so we can remove
the var from all test playbooks.
Change-Id: I92c85c2c5c53f4e3d028debcfe925c26ad84284b
Moved Rabbitmq and DB tasks to generic files.
This patch removes the redundant behaviour of the tasks such
as Ensuring Rabbitmq hosts and user, creating db, granting access
to db in the testing yml files. The patch makes it more generic
and shifted the common tasks to separate files create-grant-db.yml
and ensure-rabbitmq.yml
Change-Id: Ibd94e1ebdce45b782ab447ca3db5068588a1e368
Zuul