When targeting localhost with 'remote_user: root' and
using 'become: yes' we lose the environment variables
for the user running the playbook (eg: USER, HOME).
However, if we use 'connection: local' and 'become: yes'
together, it works properly.
To ensure these plays have the correct access to change
things on the host, we apply this change to them all.
We also ensure that 'become: no' is explicitly set on
any local connection plays to make the intent more
obvious. Finally, we also use 'yes' and 'no' uniformly.
Change-Id: I6e4607dd4aaffa0bfcda254103697bf9b28eca1a
It makes no sense to use become when you're connecting to a
host via the root remote_user. As such, we remove all uses of
'become: true' from the test plays with the exception of the
'test-prepare-keys.yml' playbook which uses a local connection
rather than a remote one and it therefore needs to use become.
We also transition all plays to use 'remote_user' which is the
correct parameter to replace 'user' (since ansible 1.4).
Finally, we switch the horizon nova service setup to its own
playbook using a local connection and the upstream keystone
modules.
Change-Id: I20517c22f07b1bb811a51d8c63741604360fe7f8
The lxc container create process were running in serial as it sets up
the test environment. Being this is setting up a test environment
there's no need for it to be executed in serial. The original reason
these container creates were running in serial was due to SSH issues
however the integrated repo has been creating containers in parallel for
sometime now so it is believed the original control path issues have
been resolved.
Change-Id: I59d563549b288e634338474aed45011e94b85c47
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
The commit [1] allowed repo management for all
hosts where openstack_hosts is applied, and commit [2] removed
UCA from pip install, which applies to all the hosts,
whether they are containers or not.
We should therefore add UCA to containers back.
[1]: https://review.openstack.org/#/c/515399
[2]: https://review.openstack.org/#/c/515400
Change-Id: I79ff70c438b44753be2a93f004ebbc46de0a963d
Sometimes a test will result in a failure, but it
takes more time than necessary to find the failure
due to Ansible continuing to execute on other hosts
after removing one from the play execution.
This patch ensures that any error will result in
an immediate failure so that the fatal error is
easier to find.
Change-Id: I4e89bfdb1e48d0ac65f9fb8549e55a19ab773f9f
In Ansible 2.3 the local connection plugin overrides
the host vars for the ansible_python_interpreter,
causing tests to use the wrong interpreter and
install python packages into unexpected locations.
This is especially visible when using host
delegation to localhost instead of the targeting
localhost directly.
To ensure that the behaviour remains consistent with
our expectations all local connection usage for
localhost is removed and localhost is targeted as
a remote host.
Change-Id: Ifcccf3c25aa10085b35017b01644354e10eca15a
After configuring the bind mounts in the container, we used a
task to wait for SSH to respond on the container, using the
Ansible wait_for module trying to connect to port 22.
When managing containers in Ansible using other connection plugins
that use LXC commands on the physical host to execute modules,
there may not be an SSH daemon running within the container. In
these situations we can accomplish the same check without SSH by
using the wait_for_connection module (new in ansible 2.3) to verify
that Ansible has a working execution path into the container, but
not necessarily via SSH.
Change-Id: I25978a3043af1df1613f41e479b7f058d64f685d
Use 'connection: local' in the test-prepare-containers.yml and
test-prepare-host.yml playbooks similar to the test-prepare-keys.yml
playbook one.
Change-Id: I1e69b72121ac07f23a467c61b9ab5888fc57c275
Currently we don't have logs of what happened in the containers.
This commit changes the lxc_container_create default bind mounts
to ensure that the /var/log directory from the containers is
bind mounted to /var/log/{{ inventory_hostname }} on the host.
The tox configuration is also changed to ensure that links are
not dereferenced in the log copy, and that the layout of the log
storage is the same as that of the integrated gate.
Change-Id: I56f5e422313c405d4f65feb8e445d4f4b0700566
Co-Authored-By: Jesse Pretorius <jesse.pretorius@rackspace.co.uk>
Signed-off-by: Jean-Philippe Evrard <jean-philippe.evrard@rackspace.co.uk>
Replacing usage of ansible_ssh_host, ansible_ssh_user,
ansible_ssh_port with ansible_host, ansible_user and ansible_port
Depends-On: I35371879a87c115f219cd181245fe59f6d7d3f77
Change-Id: I97c3958c406b44b271d361860516d0b903438a83
The container destroy playbook was attempting to ssh to the targets
it was destroying instead of simply connecting to the localhost and
removing them. This change allows the connection to be local allowing
the destroy to go through.
This also changes the container create and destroy tasks to be done
in serial. This is being done due to potential control path issues.
Change-Id: Ide0fa39bfef917abd8b0abf1b5c9991beae9c10b
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
This patch removes the following pinned vars for test execution:
lxc_container_release:
This variable is set based on the host platform and should not
be fixed to this value in the playbook.
lxc_container_backing_store:
This value is dynamically set based on the host configuration
and 'dir' is the fallback value so it does not need to be set.
global_environment_variables:
This value is an *optional* variable. It was only ever set in
order to test that the functionality to apply the contents of
this variable work.
This patch also sets 'become: true' for the playbook to ensure
that the execution of the container creation/deletion is executed
as the root user.
Change-Id: Id6f35e1b9fef5096c06dffb1900c2d144bc5ece4
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
test-prepare-container.yml is seperated into:
test-prepare-container.yml: Creation of test containers.
destroy-containers.yml: Deletion of test container.
Change-Id: I2e42debeaca0a3a8c837fd34c11ad7e6cbcf151b
ZhijunWei