openstack
/
openstack-ansible
Code Issues Proposed changes

Pin argparse for idempotent pip installs 

Argparse is part of the Python standard library in 2.7 but is still
an unmarked and unpinned downstream dependency of some packages
(unittest2==1.1.0 for example).

Ubuntu's libpython2.7-stdlib package includes an argparse.egg-info file
setting its version to 1.2.1.

The python_venv_build process will try to build and install the latest
version of argparse available in PyPI, 1.4.0, but this will never
actually install over the existing standard library install. The pip
module currently marks the install as changed regardless, causing a
restart of OpenStack services during every playbook run.

Change-Id: I8be207c359388d00b34448318bc17c8b0039c4db
This commit is contained in:
Jimmy McCrory 2018-10-18 10:06:08 -07:00 committed by Jesse Pretorius (odyssey4me)
parent d4853793fc
commit 93ce5fa105
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
global-requirement-pins.txt
View File

@ -16,6 +16,7 @@ Cython<0.28
###
# Bumping pip to version 10 fails in tempest when trying to install
# packages with an empty list.
argparse==1.2.1;python_version=='2.7'
pip==18.0
setuptools==40.0.0
wheel==0.31.1