* Update manila from branch 'master'
to 2c95d47b9715f711237f6f248986104aca85b9a6
- Merge "Check share network for share groups before deletion"
- Check share network for share groups before deletion
Share network subnets were not checking for the existence of share
groups while processing a delete request. Then, if a share network
had a share server that was tied to a share group, it would end up
deleting the share server, leaving the share group orphan. When we
triggered the deletion of the share group, it would fail, as the
share server was not known to Manila anymore.
Fix that issue by adding an extra validation step during the share
network subnet delete API.
Closes-Bug: #2004212
Depends-On: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/875981
Change-Id: I563bf925523fa44689c83f432ce5a460276afef7
* Update manila from branch 'master'
to d0b5bdab0681fe5fe15cc4c0935e55c27b4e8d96
- Merge "[doc] Quota paramaters have moved to the [quota] section"
- [doc] Quota paramaters have moved to the [quota] section
Closes-Bug: #1942362
Change-Id: I14f56450f1bd048a0094db5c5cde0be396c3eb28
* Update manila from branch 'master'
to d8987589ae88ae9b2769fbe6f26d5b6994098038
- Merge "Add job to test with SQLAlchemy master (2.x)"
- Add job to test with SQLAlchemy master (2.x)
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: Ib67538ebd0f8ebbea5a700343f52655b0f7fecd4
* Update manila from branch 'master'
to 28bb87ff778f65f0c2b810582717fcd032575728
- Merge "tests: Don't (always) auto-create snapshot instances"
- tests: Don't (always) auto-create snapshot instances
If we are manually creating these things, we don't want any
automatically created. This is a latent issue that was being exposed by
SQLAlchemy 2.0's tweaked session management.
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: I9d760ebbfcca176a39b44f20fb92e16eaf6284c5
* Update manila from branch 'master'
to 56db40e344495e162d1255747a274e2641d13447
- Merge "db: rename_table is not a batch operation"
- db: rename_table is not a batch operation
This is reported upstream [1] but I suspect the root cause is that we
were relying on a bug in Alembic: renaming tables doesn't really make
sense as a batch operation, which by definition works by recreating
tables with an updated schema (to support SQLite and its lack of full
'ALTER' support).
[1] https://github.com/sqlalchemy/alembic/issues/1453
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: I1da6d117778bbbad64b2df2dfd2f8aeef8a7084c
* Update manila from branch 'master'
to 221d4d940dc0a4a0324b975d20f22931d08437ab
- Merge "Add delete CLI helper to ShareCommands"
- Add delete CLI helper to ShareCommands
This patch adds a delete cli command to ShareCommands
The helper CLI command checks if service if up. If service
is down, it deletes the share instance
Closes-Bug: #1867030
Change-Id: I6a0575c1ed86213010e50fe1b7a733cdf7fa1736
* Update manila from branch 'master'
to 9d7bf9b1c15b76e65bfe3cb9a53345d4d8ae8c26
- Merge "db: Don't use strings to indicate relationship names"
- db: Don't use strings to indicate relationship names
Resolve the following RemovedIn20Warning warning:
Using strings to indicate relationship names in Query.join() is
deprecated and will be removed in SQLAlchemy 2.0. Please use the
class-bound attribute directly.
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: I155b4ce4b605720c8335d465124fd32cc973a737
* Update manila from branch 'master'
to 78272c75707548549f07be8decbe3ccf9b853fbe
- Merge "db: turn off autocommit"
- db: turn off autocommit
after testing using an assert for DML without a transaction,
we can now turn autocommit off. enginefacade should be used
completely now
Change-Id: I2ee07c7e41ea43c2ab24a4a095550dd0b5fe47dd
* Update manila from branch 'master'
to e15eb1cbf433504f67a2183e480b7fbfe1106b74
- Merge "db: update migrations to use SQLA 2.0 patterns"
- db: update migrations to use SQLA 2.0 patterns
All tests in test_migration.py pass with either SQLAlchemy 1.4
or SQLAlchemy 2.0 installed.
Change-Id: Ie8831c04b7b4515deea27b1ceb472d07cda91ca0
* Update manila from branch 'master'
to dd308df3d226ea41f2630dca7ac72d5467ca0f8b
- Merge "db: Remove final use of legacy facade"
- db: Remove final use of legacy facade
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: I1251a5c0b2f073604ae61f378992fea7df51c07d
* Update manila from branch 'master'
to ffcf6948815c49f6b003fb2fc68f89931efaa4ee
- Merge "db: Post-migration cleanup"
- db: Post-migration cleanup
Now that we have migrated all of our DB APIs to enginefacade, we can
clean up the outstanding TODOs.
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: Iee198a16f030f1205d38b7c232d4e3a42642c756
* Update manila from branch 'master'
to a30697d3e78c49297e3a67db902d21a8254b000c
- Merge "db: Remove session arguments from AZ methods"
- db: Remove session arguments from AZ methods
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: I38ae324d5edb3705b559c3706d6888f08473a633
* Update manila from branch 'master'
to 685acf601310eda98aa5c25970f6179f2b024358
- db: Migrate "share snapshot", "share snapshot instance" APIs to enginefacade
Thankfully the APIs being migrated here were _mostly_ sharing sessions
already, so we can simply migrate from public (decorated) methods to
private methods with minimal fuss.
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: Id1b555e48106662d15e8c50567a5f3acecf6a8f1
* Update manila from branch 'master'
to 13b4c31117a9ad50caa4fdea7811e43212bc29a2
- Merge "[doc] Mount options in the ceph native driver"
- [doc] Mount options in the ceph native driver
CephFS native shares will now have the cephfs filesystem name
added to its metadata through `__mount_opts`.
We are also warning and instructing administrators how to prevent
less privileged users to update such metadata.
Signed-off-by: silvacarloss <ces.eduardo98@gmail.com>
Closes-Bug: #2057707
Change-Id: Ica80d80d9a3709814c1ba1c9e5d942ab0c97aec7
* Update manila from branch 'master'
to c9cf3540ff54e269988e031f4ad91a5a000802fb
- Merge "db: Unwind unnecessary independent transactions"
- db: Unwind unnecessary independent transactions
We need to maintain these on quotas (for now) but not on other
operations.
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: I991d6127c14b5f06ca9ca8e6caccbc392e639b42
* Update manila from branch 'master'
to b0d6056282f68519e23a978211ea654e0ac18dbf
- Merge "[DOC] Add snapshot metadata to user guide"
- [DOC] Add snapshot metadata to user guide
Add code block for share snapshot create, list,
set and unset to user guide.
Closes-Bug: 2058941
Change-Id: Ibed2063a92a9f338553f1db879c45545fcdbf2ee
* Update manila from branch 'master'
to c7dcf18319446c06462abc60e13f688dbb94af1b
- Merge "[doc] Admin only modifiable metadata"
- [doc] Admin only modifiable metadata
Updates to the administrator and configuration metadata to address
the new configuration option, which allows administrators to
specify metadata items that should not be updated by less
privileged users.
Signed-off-by: silvacarloss <ces.eduardo98@gmail.com>
Partial-Bug: #2057707
Change-Id: If8d51d50630f0581d588e07c3c086442b451c360
* Update manila from branch 'master'
to 36549c8b97dad72a55bdc7a7ef58a4c5d06944be
- db: Migrate "share instance", "share replica" APIs to enginefacade
We migrate both of these at the same time since a share replica is
effectively a share instance with only the 'replica_state' field set. As
such, they share many common DB APIs.
These are mostly trivial to migrate. Just a lot of refactoring to create
private methods, avoiding nested transactions.
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: I267e2e0fac0b4130f8836de276082788fbd8d454
* Update manila from branch 'master'
to 4dc5f6b73015f0540a470a11c321f7ef05ec11c4
- Merge "Fix the link to get the next share replica"
- Fix the link to get the next share replica
The url to get the next share replica is broken when performing
pagination. The new API uses underscore to represent resource.
This fix resolves the broken link for share replicas by using alias.
Closes-bug: #2023754
Change-Id: I31e32c0bcfb60b53121da9a96df3b44ad2b3ac67
* Update manila from branch 'master'
to 0c8cc2333b881af3cb3206d2a45f52aab5e77ff5
- Update master for stable/2024.1
Add file to the reno documentation build to show release notes for
stable/2024.1.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2024.1.
Sem-Ver: feature
Change-Id: If6933ad6a578042eef9c56652d5273dafd29602e
* Update manila from branch 'master'
to 18ffa38116510e547fb00d765cf60e386c5446e8
- Merge "Change admin metadata config option name"
- Change admin metadata config option name
This change is a follow-up to a change that merged recently [1].
We are changing the name of the config option to make it similar
to the policy we have defined for updating some metadata that
should only be manipulated by administrators.
[1] https://review.opendev.org/c/openstack/manila/+/909175
Related-Bug: #2050010
Change-Id: I9a8a27f1181b92291f2d4ad5fd9d4483e2dacc50
* Update manila from branch 'master'
to 12a4c6627cc1cb6fd22fc1b7384b0705996a6e2d
- Merge "[doc] Update CephFS admin guide"
- [doc] Update CephFS admin guide
There's a new driver mode supported since
Antelope (introduced in Zed) that supports
ceph orchestrator deployed CephFS NFS clusters.
We were missing documentation regarding this.
Also consolidate the admin/configuration references
for this driver; this deletes all the outdated
information in the existing config guide.
Partially-implements: bp use-cephadm-nfs-ganesha
Change-Id: I43952d890629e60465059a5b4242817becb198b1
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
* Update manila from branch 'master'
to 6c04a9621fd9a320d83d4ae5ca181bafada305b2
- Merge "Deprecate the Ceph NFSProtocolHelper"
- Deprecate the Ceph NFSProtocolHelper
A couple of releases ago, we started supporting clustered NFS
gateways [1], and we mentioned we had clear intentions to make
this the default choice for the deployments.
In this change, we are deprecating the NFSProtocolHelper, which
will be removed in the next skip-level release.
This means that Manila will no longer support exports created over
a NFS Ganesha instance that is not managed by the Ceph Cluster.
[1] https://review.opendev.org/c/openstack/manila/+/848987
Change-Id: I062a8c552d7d94e010cef6694bec6da68d7ea180
* Update manila from branch 'master'
to adf48763dba48e1d823f8cc358f7a78a00b496d0
- Merge "Add more tests for share/snapshot deferred deletion"
- Add more tests for share/snapshot deferred deletion
Partially-implements: bp/deferred-deletion
Change-Id: I49c7916d4823c691f3fffe6797a779b086589188
* Update manila from branch 'master'
to 0ca91f11b633ada1c57e4a4069e81d7cd3482ae8
- Merge "Human readable export location NetApp driver changes"
- Human readable export location NetApp driver changes
NetApp driver changes to accommodate human readable
share location. Export path is updated with
human frendly value if present else use share-id.
partially-implements: bp human-readable-export-locations
Depends-On: I72ac7e24ddd4330d76cafd5e7f78bac2b0174883
Change-Id: I2f5bfdbc9d0458c7b9198a3eb94b3b095d5b5e04
* Update manila from branch 'master'
to 1bfbfac266808077b7ab35c8ff2f5f52a5923ae1
- Merge "[CI] Drop glusterfs jobs"
- [CI] Drop glusterfs jobs
These have been permafailing; let's drop
them until they're fixed. GlusterFS drivers
were deprecated in the Caracal release [1]
[1] https://review.opendev.org/c/openstack/manila/+/908735
Change-Id: Idab5349d2d8c3e78b6f570682fe07f1073731784
Related-Bug: #1998493
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
* Update manila from branch 'master'
to bd3b074aa57e912b0b74fa28e543bdf58ac65a7c
- Merge "Forbid resetting state of active replicas"
- Forbid resetting state of active replicas
In a replication setup, users encountered a critical
issue where they unintentionally reset the replica_state
of an active replica while attempting to resolve errors
on a non-active replica. This led to a situation with no
active replica, causing data loss. Users expected
server-side validation to prevent such actions.
This commit implements the necessary validation in the
codebase to ensure that the reset_replica_state action
cannot be applied to active replicas, addressing the
reported issue and improving data integrity in
replication setups.
Co-Authored-By: Solly <solobarine@gmail.com>
Closes-Bug: #2015328
Change-Id: I629669476e585a834673b8c8b49ad4b0270b877f
* Update manila from branch 'master'
to d4fb4319f5d59db67a8f42975f27d719005935d4
- Merge "refactoring: modify function parameters and annotations to match"
- refactoring: modify function parameters and annotations to match
- the parameter description in the parameter and annotation did not match, so this was fixed.
Change-Id: I1557b74b5a2d0b81f68aa15149490bb178a5a716
Signed-off-by: Youngjun <yj.yoo@okestro.com>
* Update manila from branch 'master'
to 64f03ed4f7dddb4ceb3af35387d279229e0199ba
- Merge "Remove unused oslo.db.concurrency namespace options"
- Remove unused oslo.db.concurrency namespace options
This option is used by TpoolDbapiWrapper which is not used in manila.
Change-Id: I2cb11c4a962b49ebb1bc0fa01d7765d3109b3a8d
* Update manila from branch 'master'
to f5a8202c53d81a39f5a9e5610809f33e16cd9486
- Merge "Deprecate Windows SMB share driver"
- Deprecate Windows SMB share driver
This feature was added and maintained by Cloudbase as part of effort to
support Windows-only OpenStack but Winstackers project was retired and
there seems to be no on requiring this deployment architecture now.
Because the driver hasn't been get any meaningful update for some time
and we no longer have Hyper-V CI active, this proposes deprecating
the driver so that we can retire it in 2024.2 at the earliest.
[1] d9c0bda0b7afa2bf419bd98b819bbb8315e8d530
Change-Id: Icec29f5512d4c4ce8c8d7ccb1f2d3823bffa7ed9
* Update manila from branch 'master'
to 42cf099bb4423d4ede54b668639a8f485054396a
- Merge "Implement the share backup for NetApp driver"
- Implement the share backup for NetApp driver
Implement the share backup feature for NetApp driver.
NetApp SnapVault technology is used to create and restore
the backup for NetApp ONTAP share. backup delete workflow
just delete the transferred snapshot from destination
backup volume.
Depends-On: Ifb88ec096674ea8bc010c1c3f6dea1b51be3beaa
Change-Id: I5a4edbf547e7886fb4fa9c1bed90110a33f9bf3b
* Update manila from branch 'master'
to b6010bb7468b11eeea2c3495aad23e86a4233524
- Merge "Add support for share/snapshot deferred deletion"
- Add support for share/snapshot deferred deletion
Implements: bp/deferred-deletion
Change-Id: I9e55e1706fc0c3d9f65f73e13ba2a20f355c74f4
* Update manila from branch 'master'
to 012c256babb87c1fa3d03a154611e0c8178eb7ca
- Merge "Share backups enhancement"
- Share backups enhancement
Added new column named 'backup_type' in 'share_backups' table
and changes the share common api libs to support the dhss_true
configuration for share backup creation
Partially-implements: bp/share-backup
Change-Id: Ifb88ec096674ea8bc010c1c3f6dea1b51be3beaa
* Update manila from branch 'master'
to 99722dbea80399d1750ab387c3b45f636c56b846
- Merge "Add doc for service disable reason"
- Add doc for service disable reason
Change-Id: Ie2774a16323cf03a741583165fc7079cc8ca096d
* Update manila from branch 'master'
to a230ea511e0a20a16f51e3549b9ccc70f13149c9
- Merge "Human readable export location core implementation"
- Human readable export location core implementation
Export locations are usually too difficult to memo
rize.Currently, there is no way to determine the
export location before the share is created, so
users wait until the share creation request gets
completed, and then they check the export
locations to mount the share. The generated
export locations are often not human readable
and it is hard to memorize and control them.
Implements: bp/human-readable-export-locations
Change-Id: I72ac7e24ddd4330d76cafd5e7f78bac2b0174883
* Update manila from branch 'master'
to a5532c3080b7457093744a5b49d2f3ed3a6dd0df
- Merge "reno: Update master for unmaintained/xena"
- reno: Update master for unmaintained/xena
Update the xena release notes configuration to build from
unmaintained/xena.
Change-Id: I22133f8d1c1a50ccf48ff3475703fe3031118520
* Update manila from branch 'master'
to f5b822ae07a2b58d7f56c414aa82ef77da7cf988
- Merge "reno: Update master for unmaintained/victoria"
- reno: Update master for unmaintained/victoria
Update the victoria release notes configuration to build from
unmaintained/victoria.
Change-Id: Ib511a5b553441030e9d0bd6686497b162661ebf7
* Update manila from branch 'master'
to ff3f875d5e5bd15fe71a1c8e5e65582d233f5110
- reno: Update master for unmaintained/wallaby
Update the wallaby release notes configuration to build from
unmaintained/wallaby.
Change-Id: I18776fe290aec903e8c1abe92dd5f1ddd9119464
* Update manila from branch 'master'
to f4c77bfe7111bc000ba3f663ce5820f06a7df17b
- Merge "Add cephfs filesystem to shares metadata"
- Add cephfs filesystem to shares metadata
Make use of the `get_optional_share_creation_data` driver interface
to metadata in shares' created using the cephfs protocol.
Closes-Bug: #2050010
Change-Id: I91b51f974840f593334f2dcddfcfd45adfe87780
* Update manila from branch 'master'
to 7b685d9dda3b7557b634e95d864240fdbe2fd8cd
- Merge "Add a new config option to specify admin metadata"
- Add a new config option to specify admin metadata
- A new config option named ``admin_metadata_keys`` was introduced
and we expect it to be set in the DEFAULT section of the manila
configuration file. It is expected that administrators will provide
a list of metadata keys that can only be updated by administrators
through this configuration option.
- Drivers will be able to set metadata while creating shares
through the `get_optional_share_creation_data` driver interface.
Closes-Bug: #2050010
Change-Id: I6412710c7db89747d23033e1a5a6be9de5886b0b
* Update manila from branch 'master'
to 618576ff3119b46bc69e50e11d7f4b2abadb72e1
- Merge "Add disabled reason field to service."
- Add disabled reason field to service.
update micversion to 2.83
user can set disabled reason for service.
Closes-Bug: #2037700
Change-Id: I3d7c46945366ac9e1d305c2f6de2233859259bf7
* Update manila from branch 'master'
to 696f9ea8a22902a31ea0c3399f8a7b9f77ea5bbf
- Drop reference to WalkVersionsMixin from oslo.db
The WalkVersionsMixin class was already removed from oslo.db, because
of removal of sqlalchemy-migrate support.
Change-Id: I952e0aed8705fd4fc0b89f6ee34f31da1b30c656
* Update manila from branch 'master'
to 25d923925a59fc9c68a92198ead6a8821cee0650
- Merge "is_valid_ip_address: Catch non-string values early"
- is_valid_ip_address: Catch non-string values early
The is_valid_ipvN methods from oslo.utils raises an exception for
non-string values, because of the change in netaddr 1.0.0. This adds
a wrapper logic to retain the previous behavior, which is preferred by
manila.
Change-Id: If1297e4d54fd645969ca79690a1c558c9efdbc8d
Zuul
OpenStack Release Bot