* Update puppet-openstacklib from branch 'master'
to 320b5b9522d37de3bf5b62d63c488818e5d4868a
- Merge "Use creates property of exec"
- Use creates property of exec
... instead of unless + test command, to leverage the built-in feature
and simplify the logic in our own modules.
Change-Id: Id9b6bc78f225ddca2ce9580b38a02351c2fbdd35
* Update puppet-openstacklib from branch 'master'
to fbe39f3ee093547ddfd813988e5b8c74de439a5f
- reno: Update master for unmaintained/yoga
Update the yoga release notes configuration to build from
unmaintained/yoga.
Change-Id: I9dca2052fa43a46dc196b1e1ddc440c8ea5a742f
* Update puppet-openstacklib from branch 'master'
to 84c99513c759d1284512b8ee19fd00bb823b56f3
- Merge "Simplify policies definition"
- Simplify policies definition
Currently the openstacklib::policy::policies parameter requires
the following format.
openstacklib::policy { 'foo':
policies => {
'title' => {
'key' => 'policy-key',
'value' => 'policy-value'
}
},
...
}
However the top level key ('title') is used to determine resource
names and does not affect actual configuration. This is quite redundant
and sometimes confusing to users.
This allows using title strings to define policy keys. With this change
users can use a policies value like the following example. This is
similar to the existing config classes interface.
openstacklib::policy { 'foo':
policies => {
'policy-key' => {
'value' => 'policy-value'
}
},
...
}
Change-Id: I7f8caa2b3e5cab852f64c5fdbb3452485d8aabab
* Update puppet-openstacklib from branch 'master'
to 4f440b1103d784d0d15a88c8250561bf83c2c9af
- Merge "Fix old github url"
- Fix old github url
... and remove the unmaintained description about version-release
mapping, because now it's described in [1].
[1] https://docs.openstack.org/puppet-openstack-guide/latest/install/releases.html
Change-Id: I19e24a8f6a1f34ce37f1c459e814b0a724479468
* Update puppet-openstacklib from branch 'master'
to 981b4816bb34d9398eeee753d97e8f8d55d4e96e
- add access_log_env_var for apache vhost
Allows to only requests with particular environment variables be logged.
Example: set a dontlog variable for healthchecks, so healthchecks are not
logged.
Change-Id: I4dea75f85d2e4a2287bdcce845c4b5fa05da0ddc
* Update puppet-openstacklib from branch 'master'
to 04e35709a72e56ebeaada6b58a7cb9a89caac914
- Merge "Bump upper version of puppetlabs-mysql"
- Bump upper version of puppetlabs-mysql
... because now v15.0.0 is used in CI.
Change-Id: Ia9c0595f84628998e3424c15fe382d36d33c252b
* Update puppet-openstacklib from branch 'master'
to 9ff464ca40a63e84035c10df24e6fe89b5ad3400
- Bump supported Debian version to 12 (Bookworm)
Debian 12 was released in June 2023. Recent versions of OpenStack
(actually, 2023.1 and later) no longer support Debian 11.
Change-Id: I3762a0c9d2bd6f4a11c147e40a3140613ec8c3cf
* Update puppet-openstacklib from branch 'master'
to 44a54f4f41d20aab3ce2a55d770f4dc27bc01ba4
- Fix unit tests with Debian 12
Debian 12 has PostgreSQL 15, and uses scram-sha-256 by default. So
we need a fix similar to the one[1] made for Ubuntu earlier.
[1] 6adbd49b9f2ae8d52f021c0fdb67760695483f85
Change-Id: I6e6e88951caa3aea0b7a1e13238e22ae4cb1c3dd
* Update puppet-openstacklib from branch 'master'
to 4552c7d2de1342c491a326c2d88f335f4f3ce082
- Merge "Import functions from stdlib"
- Import functions from stdlib
... instead of copying the implementations into our modules. The issue
with unit tests, which is described in the comment, is no longer seen.
Change-Id: If5dd1a7d8987010f35e164861c807869128f690c
* Update puppet-openstacklib from branch 'master'
to 4a7f395dd9664b09036b09ba18dacecedea05894
- Merge "Replace deprecated `should`"
- Replace deprecated `should`
This replaces usage of `should` by `expect` according to the following
deprecation warning.
Using `should` from rspec-expectations' old `:should` syntax without
explicitly enabling the syntax is deprecated. Use the new `:expect`
syntax or explicitly enable `:should` with
`config.expect_with(:rspec) { |c| c.syntax = :should }`
instead.
Change-Id: Ifaac60ea93a5f854cd70929d7f3f5308a9b9911e
* Update puppet-openstacklib from branch 'master'
to 3f0bda3f6c8230c95586d1af3eba16603cc53fac
- Introduce new 'openstackclient' tag
... so that we can define dependencies on client packages.
Change-Id: If6f54d9b63ebe0dbc7e82795d0ba3fb88551086e
* Update puppet-openstacklib from branch 'master'
to 22a9bd19ca778a527c0e5bf0f1d4534f1709075a
- Revert "Remove 'openstack' tag from iscsi service"
This reverts commit 0f3357a209dd9ed0b7e8ba23a83b9dc33475df1b.
Reason for revert:
The openstack tag is used by variety of package resources, so it's not
specific to client packages.
Change-Id: If171ff72b2f4d74cf520c2b1b48a3526b1b0929e
* Update puppet-openstacklib from branch 'master'
to 6adbd49b9f2ae8d52f021c0fdb67760695483f85
- Fix broken unit tests with puppetlabs-postgresql >= v9.2.0
The default password encryption in Ubuntu 22.04 has been changed from
md5 to scram-sha-256 by [1].
[1] 985309e2df
Change-Id: I7f1218a3dc1377305b5eb7296b3ef03645f6a085
* Update puppet-openstacklib from branch 'master'
to 4dc548c81b1c105c329054c7a1ace2e3dc01bd81
- Merge "Bump upper version of puppetlabs-apache"
- Bump upper version of puppetlabs-apache
... because now we are using v11.x.x in CI.
Change-Id: I7fb5d002d2421c272ece8d357b5cd6f4e22f6c2e
* Update puppet-openstacklib from branch 'master'
to e02d866bbcdc04bbc28ffc398f2e5ab41cd10c2c
- Merge "Bump upper version of puppetlabs-postgresql"
- Bump upper version of puppetlabs-postgresql
... because now we have v10.x.x used in CI.
Change-Id: Id25bbe62b6882d934f2abea3c7ee929885669bb3
* Update puppet-openstacklib from branch 'master'
to 885894610b6160bdfcf341f740f9c7413d5286b4
- Merge "Update master for stable/2023.2"
- Update master for stable/2023.2
Add file to the reno documentation build to show release notes for
stable/2023.2.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.2.
Sem-Ver: feature
Change-Id: I6d09b765c2e6d238b270349672d60c1c9e51cf62
* Update puppet-openstacklib from branch 'master'
to 0f3357a209dd9ed0b7e8ba23a83b9dc33475df1b
- Remove 'openstack' tag from iscsi service
... because this tag is commonly used for client packages.
Change-Id: Ic709f978beca3371ad6b4cfc60c15cc8dc71e5d6
* Update puppet-openstacklib from branch 'master'
to 4c7fa922be980f22705c5d2b7bd9e9df41f694b5
- Remove usage of deleted manifest_dir
Recent update in rspec-puppet removed some of the config interfaces for
old puppet versions[1]. This drops usage of these interfaces to resolve
the following error in unit tests.
```
An error occurred while loading ./spec/unit/provider/manila_spec.rb.
Failure/Error: c.manifest_dir = File.join(fixture_path, 'manifests')
NoMethodError:
undefined method `manifest_dir='...
```
This also removes explicit setting of mock module. The definition is
no longer required since we bumped puppetlabs_spec_helper to v 5.0.0.
[1] 316d95923c
Change-Id: If94493ff448e4c634d65dbbd5259722b3ad6448f
* Update puppet-openstacklib from branch 'master'
to 4c21a53fcf8b8249eeeff86373539f257e69b2f1
- Bump upper version of stdlib
... because we are currently using v9.0.0 in CI. Lower version may be
bumped after 2023.2 release.
Change-Id: I603d8da53a962816ec22242901720e0ce496ee4e
* Update puppet-openstacklib from branch 'master'
to 077d72772763bb9fa4d7a92a8c8529a458d87591
- Merge "replace validate_legacy with proper data types"
- replace validate_legacy with proper data types
the validate_legacy function is marked for deprecation in
v9.0.0 from puppetlabs-stdlib.
This also adds a few strict validations to the db classes based on
the validations implemented in the underlying resources.
Change-Id: I9e809415a532a694a50492a5600863d7d3d18a20
* Update puppet-openstacklib from branch 'master'
to 5cb78b4d259b9b1a483a1b119dddfb3a9c2740f2
- Add utility function to compose URL from elements
This change introduces the generic function to compose URL from
elements. This can be used to compose endpoint url or coordination
backend url.
Change-Id: I77469f9dca817c4ab2af939de9bd74dce122c3d8
* Update puppet-openstacklib from branch 'master'
to cf3f23fc093967ceed035149b0dbd077a2bfa2d8
- Exclude release note files
The directory contains the source files to generate the release note
document, so is not required.
Change-Id: I85f4c6d974cacf88d3a9dd483ab82daa7c09f88b
* Update puppet-openstacklib from branch 'master'
to 9392a0cda1129f2f438f34c8587b5bd8eb41566f
- Merge "Add .pdkignore to exclude some files from tar ball"
- Add .pdkignore to exclude some files from tar ball
We've seen release job failures caused by too large tarball, which
contains irrelevant files like git history.
Let's exclude these files to reduce size of the archive.
The file is copied from the puppetlabs repositories with some files
specific to OpenStack projects added.
Change-Id: Ia6245847ee40654663d24e64eaccef583fdc3828
* Update puppet-openstacklib from branch 'master'
to 2741e737850a25c11d7a1dcf8f2a314674238e3b
- Disable MultiViews in apache vhost
MultiView is used to switch the content according to the type map.
However this feature is not really used by the wsgi application of
OpenStack services.
This removes the option because this is sometimes regarded as
a security concern.
Change-Id: I41a8b242e6dfa4061fa0dc6912bda72e892e3da1
* Update puppet-openstacklib from branch 'master'
to a22990d4d5abe1eecd59a818b6e69eb6aa3423e1
- add a separate datatype for servicedefault
Needed for non String types if they have a default
that points to facts['os_service_default'].
Otherwise we need to allow String for all parameters.
Since the function is_service_default checks the string,
I do not assume that the fact is overwritten in
any deployment !
Change-Id: Ic2b969f9b99d1748c80edb691f38f4451e499a80
* Update puppet-openstacklib from branch 'master'
to 60f964b7a094b207ccd3a9dc0654f323b07a4519
- Merge "Revert "Replace Stdlib::Absolutepath by Stdlib::Compat::Absolute_path""
- Revert "Replace Stdlib::Absolutepath by Stdlib::Compat::Absolute_path"
This reverts commit 0861e31cf9e3d4cb6022038f46caf3cdc5f83873.
Reason for revert:
Stdlib::Absolutepath has never been deprecated, but
Stdlib::Compat::Absolute_path was deprecated. The latest stdlib
removed all Stdlib::Compat::* types[1].
[1] fcbd4267fd
Change-Id: I560dbe312a5833f1d6705768bfbf79c06a9ce734
* Update puppet-openstacklib from branch 'master'
to 804958c8c3d3c1c60b3c492ec4e0a7ba923a4983
- Merge "Remove support for Puppet 6"
- Remove support for Puppet 6
... because Puppet 6 reached its EOL in February 2023.
Change-Id: I3a733d20ccfadde8f2b691d57b3ace318224c3cd
* Update puppet-openstacklib from branch 'master'
to 524e5b0995bf1519cf173921f417fab7052f5480
- Bump upper version of puppetlabs-rabbitmq
... because now we use v13.0.0 in CI.
Change-Id: I6a198ed4cf7cbf7e673e8931a121dacb03655a96
* Update puppet-openstacklib from branch 'master'
to e05c8e739ba4a509ad48905f5f575e344fcc2658
- Replace stdlib hash function by the built-in Puppet one
The upstream patch [1] removed the hash stdlib function which was
deprecated since a while. We should now use the Puppet built-in
function Hash().
[1] https://github.com/puppetlabs/puppetlabs-stdlib/pull/1320
Change-Id: Id6e2b70cd1a4472caee324e94a674cfe24cd6a9e
* Update puppet-openstacklib from branch 'master'
to ba4ecaea82bc100964ba50b3e5f64b3c837cbb38
- Merge "Bump upper version of puppetlabs-apache"
- Bump upper version of puppetlabs-apache
... because now we used v10.0.0 in our CI jobs.
Depends-on: https://review.opendev.org/881289
Change-Id: I60b3dc77957737b0a7ca1d5a5e5ae40d71a124a1
* Update puppet-openstacklib from branch 'master'
to 9a7cc37655ba706ba1e8e812c2c51014367b7870
- Bump upper version of puppetlabs-postgresql
... because now we have v9.0.0 used in our CI jobs.
Depends-on: https://review.opendev.org/881289
Change-Id: I3495c08303dfe8ac05547e39ea2d376676aef5f4
* Update puppet-openstacklib from branch 'master'
to fde06c64266d7aef9460afb434812639adb943c1
- Bump upper version of puppetlabs-mysql
... because now we are using v14.0.0 in CI jobs.
Depends-on: https://review.opendev.org/880699
Change-Id: I198da6fbb0d8bc9c200366b17f78db2edcf87cf9
* Update puppet-openstacklib from branch 'master'
to f07650e88d9fd653dda8d106649f67cc1bd0451a
- Bump upper version of puppetlabs-inifile
... because now we use v6.0.0 in CI jobs.
Depends-on: https://review.opendev.org/880118
Change-Id: I6e82a0fa4e4fa63418c21257a9e36a76464f873b
* Update puppet-openstacklib from branch 'master'
to 98d111dde58f3c1c720ec6e4030e3d8f2b75b2c7
- Update master for stable/2023.1
Add file to the reno documentation build to show release notes for
stable/2023.1.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.1.
Sem-Ver: feature
Change-Id: Ia6e053a6d45db122b8bdeb5e08886ca3e454cedc
* Update puppet-openstacklib from branch 'master'
to 43a05b5446f642a7370f79de32a64a11956133e7
- Remove TripleO job
... because TripleO is being retired.
Change-Id: Ifc9bbd22c6291cf7691c07d1f457d6d9c7c891b4
* Update puppet-openstacklib from branch 'master'
to a1dfd6861f9593f005e72acaef7262e618d2cf6c
- Add strict validation about boolean parameters
This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.
Change-Id: Ie9214b3324166a795b2d3aaf098852c8706bc8a0
* Update puppet-openstacklib from branch 'master'
to 62439012bdf37f7f5c77eb976ea18a0fc746b57d
- Replace legacy facts and use fact hash
... because the latest lint no longer allows usage of legacy facts and
top scope fact.
Change-Id: If81712ed2129684d887668f6320e88a206fdad4b
* Update puppet-openstacklib from branch 'master'
to 66dc9289fcfc0d6ac4a40e8bfa7bb1bd272e612f
- Merge "Remove logic for CentOS < 9"
- Remove logic for CentOS < 9
... because RDO supports CentOS Stream 9 (aka CentOS 9) only since Zed.
This also refactors the logic to determine the Python 3 version and
makes the openstacklib::default class hard-fail in unsupported OS
Families.
Change-Id: I9d1fa698356d7840e50edf9c975e3672be62e912
* Update puppet-openstacklib from branch 'master'
to 8cdf9a9e5d12466cb453bc5d5eaa401a3629bce8
- Bump upper version of puppetlabs-apache
... because now we are using 9.x in our testing and it is known to
work.
Change-Id: Ia8b7f075629edf329486882f0fec6333363bbad0
* Update puppet-openstacklib from branch 'master'
to eaf7c98ae4aa4e712ece73bd3ddfe9706a6c660e
- Replace mocha by rspec-mocks
puppetlabs_spec_helper recommends rspec-mocks instead of mocha[1] and
it uses rspec-mocks by default instead of mocha since v 5.0.0[2]
This is the prep work to adapt to that migration.
[1] https://github.com/puppetlabs/puppetlabs_spec_helper/#mock_with
[2] 493f0cbc1c
Closes-Bug: #2004135
Change-Id: I273711da547446f2c37be84656d0e3be2a3f9ec7
* Update puppet-openstacklib from branch 'master'
to ee63d152c39321ef46cc5a2bf5f2ceb193e2135e
- Switch to Ubuntu Jammy (22.04)
... because Focal no longer supports the recent releases such as Zed.
Change-Id: I747ec31f63faf64db4730930daa3775ce59aa468
* Update puppet-openstacklib from branch 'master'
to 779c96bc49b303f364954c6b942a2824d0995343
- inet6_prefix: Simplify exception handling
The following exceptions all inherit IPAddr::Error, which inherits
ArgumentError.
- IPAddr::AddressFamilyError
- IPAddr::InvalidAddressError
- IPAddr::InvalidPrefixError
Because we use the same logic for all of these exceptions, we can just
catch the base ArgumentError instead of listing all these separately.
Change-Id: Ie88fce429e1b73a89820a94e8635ed6ad906b07f
* Update puppet-openstacklib from branch 'master'
to e0d95463803d3c63589db365976dbe8fb0b7d7d8
- Revert "Add old ruby support to inet6_prefix"
This reverts commit efffd27a414000eea0a85dae3162ed65b636cb3b.
Reason for revert:
The logic was added to support ruby 1.x which does not contain [1], but
recent operating systems no longer ship such an old version.
CentOS 9: Ruby 3.0
CentOS 8: Ruby 2.5
Ubuntu 20.04: Ruby 2.7
[1] e03d266c1d
Change-Id: I7c633f8d12e4678910872b7782273b2ca2c76d65
* Update puppet-openstacklib from branch 'master'
to c4ae4e767f83ae201efb248bdf8df04b73c4a2e9
- Update master for stable/zed
Add file to the reno documentation build to show release notes for
stable/zed.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/zed.
Sem-Ver: feature
Change-Id: I40157ac363465cf03b10ca06416484dd4b6366c7
* Update puppet-openstacklib from branch 'master'
to 74e6edf91edcf50c02402b940fc4236b2d4b8ed1
- Merge "Bump upper version of puppetlabs-mysql"
- Bump upper version of puppetlabs-mysql
... because now we use puppetlabs-mysql 13.0.0 in our CI.
Depends-on: https://review.opendev.org/854692
Change-Id: I0d07b5761f111cd7c0ecc8b2df0a6c9c18766e04
* Update puppet-openstacklib from branch 'master'
to 82e7adab31b3c6da2535f685dcdf86b23af64db8
- Cap upper version of puppetlabs-apache
... to declare which major version has been tested. In the past
puppetlabs-apache made a few major releases (eg 8.0.0) which broke
compatibility with our modules.
Change-Id: I08fa50bb6a46957b887996f00ad5dca5d1f8a109