We are running functional tests in zuul without a 'pyNN' factor (e.g.
'tox -e functional'). For this to work, we need to allow an empty
factor, i.e. we want:
[testenv:functional{,-py310}]
rather than:
[testenv:functional{-py310}]
(note the missing comma)
Unfortunately we missed this as tox 4 has a currently unaddressed
regression [1] that results in it running the base testenv in the case
there is only a partial factor match. That needs to be fixed for avoid
this biting us again the future, but we can at least fix it for now.
[1] https://github.com/tox-dev/tox/issues/3219
Change-Id: Ib9f65a4523222f1224d51534c5061f90501b59d3
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This was in-effect already dropped with the introduction of the
dependency on platformdirs > 3.0. This just makes it official.
Change-Id: I18806e78fe1491948948d224edb27d6ac4a8f45f
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This should be helpful for new contributors.
Change-Id: I91c14bbaeb61bdf7026015a3eb3f21edae8ec2a9
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This is more trouble than it's worth now. Black takes care of this for
us. I wish I'd decided this before the blackify series :(
Change-Id: Idae7a151fa4f24b932a130669fce563e7150278b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This is helpful for OSC. We also use the opportunity to clean up the
tests for these two functions since they were fairly janky.
Change-Id: I559e6341b15041cb40fe208439da44c66b7cc6ca
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
tox 4 is significantly faster when it comes to creating virtualenvs and
is far better and detecting e.g. changes to requirements. tox 4.3.0
includes many of the fixes for bugs introduced by tox 4.0 and is a good
default candidate.
Change-Id: I7d29a4a1bc6ee9273e70adc9f382c1d1610f0286
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We disable the H301 check since it clashes with black.
Black used with the '-l 79 -S' flags.
A future change will ignore this commit in git-blame history by adding a
'git-blame-ignore-revs' file.
Change-Id: Ib987ac513c4f5e527bf4122b784d0a69856b903e
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We want to bump the versions of hacking, but doing so requires changes
in two places: '.pre-commit-config.yaml' and 'tox.ini'. This is silly:
we can simply use tox to handle pre-commit and leave all other
dependencies to pre-commit. Do this, migrating doc8 to pre-commit and
bumping the other dependencies in the process.
Change-Id: I26fa07145129d3ef9cb17693427ed70e55dbaaf5
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Remove errant whitespace and a commented out line.
Change-Id: Ice5ef168891fe35c4447468dd0d7956ef04db090
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Tox v4 made a number of changes that break compatibility with old tox v3
tox.ini files. In particular openstacksdk lists env vars for passenv on
a single line separating them with spaces. This is no longer allowed and
produces this error:
failed with pass_env values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found 'OS_* OPENSTACKSDK_*'
We can fix this by listing each value on a single line which we do here.
Depends-On: https://review.opendev.org/c/openstack/python-openstackclient/+/868430
Change-Id: Ibf4a16e544921ec914f6e23112e0fc37a12096a5
We want to start testing sdk and osc on real clouds. They are all
different, have different settings, policies, etc. In order to cope with
that it would be necessary to rework lot of tests and code to ensure all
of those "feautres" are properly detected by sdk and osc.
Block-storage test base class should not set operator cloud, only tests
that require it explicitly should use it
Change-Id: I09d118097bade8f0d8ff497957846a754ebc7c1e
The information on how to run functional tests was badly out of date.
Correct it.
Change-Id: I7e77e2a96ab15f7dede01344cb03b0e61c8589bd
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This reverts commit 2d16931ca9.
Reason for revert: r1 in requirements will actually never appear. It was an error merging this.
Change-Id: Ifca8f5f0a0cfaed1f6555bacd1256f064efe4f9f
Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.
Until the requirements repository has as feature/r1 branch, tests will
continue to use the upper-constraints list on master.
Change-Id: I9c01131c4415ad4d0ed5c6cdc6830728734cc261
We facing errors related to the new pip resolver, this
topic was discussed on the ML and QA team proposed to
to test lower-constraints [1].
I propose to drop this job because the complexity and recurring pain needed
to maintain that now exceeds the benefits provided by this mechanismes, and
We need to drop the lower-constraints.txt file as well as the corresponding
tox target
[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019390.html
Change-Id: Ib0ef1fadf4fe44f1d6af2f7d542b8af919652501
Add the '-j auto' flag to all 'sphinx-build' invocations. While we're
here remove the unnecessary '-d DIR' argument: Sphinx will configure a
sane doctree directory for us without any special configuration. This
results in a tidy little speed boost. Before:
real 1m23.772s
user 1m9.665s
sys 0m6.299s
After:
real 0m54.613s
user 1m26.129s
sys 0m7.810s
Change-Id: Id9240456f8bb289620a64792b433dbde4fa09586
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Update version of tox to 3.9.0 to support inline comments in tox.ini
Import pep8 test requirements directly in tox.ini and do not import all
the test-requirements
Update version of hacking
Fix import orders in various modules
Leave filter for imports in tests/ for the time being
Change-Id: Ia625036d1f50ae97880ef70335804228320a9c6d
Stephen Finucane
OpenStack Release Bot