These were missed in change I3eafc92ba7c7305b1a73d3f96c427ed12c96dbf7.
Change-Id: Idf7148bcf588efbd20352bf2160ecee573156444
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Introduced changes:
- pre-commit config and rules
- Add pre-commit to pep8 gate, Flake8 is covered in the pre-commit hooks.
- Applying fixes for pre-commit compliance in all code.
Also commit hash will be used instead of version tags in pre-commit to
prevend arbitrary code from running in developer's machines.
pre-commit will be used to:
- trailing whitespace;
- Replaces or checks mixed line ending (mixed-line-ending);
- Forbid files which have a UTF-8 byte-order marker (check-byte-order-marker);
- Checks that non-binary executables have a proper
shebang (check-executables-have-shebangs);
- Check for files that contain merge conflict strings (check-merge-conflict);
- Check for debugger imports and py37+ breakpoint()
calls in python source (debug-statements);
- Attempts to load all yaml files to verify syntax (check-yaml);
- Run flake8 checks (flake8) (local)
For further details about tests please refer to:
https://github.com/pre-commit/pre-commit-hooks
Change-Id: I8d5290d62b12a7850fc932c3778cc37951dd67ed
Co-authored-by: Moisés Guimarães de Medeiros <moguimar@redhat.com>
Python 3.8 is now our highest level supported python runtime.
This updates the default tox target environments to swap out
py37 for py38 to make sure local development testing is
covering this version.
This does not impact zuul jobs in any way, nor prevent local
tests against py37. It just changes the default if none is
explicitly provided.
Change-Id: I9513860cc02287ab987d22f3403bb19bd07c28a9
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.
Ignore W504 line break after binary operator
Change-Id: Ice5627d714bad308bcf2e467a553d2d2297ea337
Sphinx 1.8 introduced [1] the '--keep-going' argument which, as its name
suggests, keeps the build running when it encounters non-fatal errors.
This is exceptionally useful in avoiding a continuous edit-build loop
when undertaking large doc reworks where multiple errors may be
introduced.
[1] https://github.com/sphinx-doc/sphinx/commit/e3483e9b045
Change-Id: I2831ab17d943638062b709882c7a1cc481e46476
python3.5 was the only supported python3 version on Xenial, now that we have
Bionic Beaver nodes that support python3.7, lets switch to testing with
python3.7 in addition with python3.6 in Stein and beyond.
See ML discussion here [1] for context.
[1] http://lists.openstack.org/pipermail/openstack-dev/2018-October/135632.html
Change-Id: Ib687a18cd86c64c7f3959e079646c13ad012dd01
Signed-off-by: Charles Short <chucks@redhat.com>
Story: #2004073
Task: #27440
The 'releasenotes' directory is excluded from pep8 checks like the 'doc'
directory already is.
Change-Id: If8b034fd59e09d7adcf4ac74868ca102445d7458
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
The -constraints venvs have gone away and constraints are just the
default setting. Also updates the list of default envs.
Change-Id: I8c442df1cacf6077febc6e26b66d134496ae7a3c
There are translatable strings in this library and we need to
support that properly. Replace the stub _() with a proper
implementation based on oslo.i18n.
Takashi Kajinami