Previous method verify if line that contain "source file"
exists into dumpxml of every virtual machine to extract
uuid of virtual machines running on hypervisor but this
line exists only when a disk file is present on the host
and boot from volumes for example has not "source file" line
into dumpxml and this script will kill them.
To avoid theese case it should be possible to use
'virsh list --uuid --all' to list directly the virtual machine
uuids of nova instances.
This changes avoid to shut running customer virtual machines.
This also fixes handling of --noop by correcting the condition checking
for arguments.
Change-Id: Ib9ec04a37bfe69e323f14f6bf4cb72b0fa818803
Closes-Bug: #1816434
Signed-off-by: Davide Panarese <dpanarese@enter.it>
Fixing https://bugs.launchpad.net/osops/+bug/1534660. Some of these
fixes are not pretty and I've not been able to test the tools still
work.
I think the bashate rules should be relaxed for operations tools ... or
people shouldn't use bash for such tools. Sometimes it's pretty
difficult to shorten lines and still have readable code.
Co-Authored-By: Peter Jenkins <mail@peter-jenkins.com>
Co-Authored-By: Mike Dorman <mdorman@godaddy.com>
Change-Id: I70cfc2420cc9a2a4ec553ab7b7ca43a7fc38a9f0
Sean McGinnis