openstack
/
osprofiler
Code Issues Proposed changes

Allow user to specify password for Redis connection 

Support full schema for connection to Redis: make port number
optional, allow password and database number. The schema is following:
`redis://[:password]@host[:port][/db]`

Change-Id: I0f8be615aa95409653211b24e114d8b0870b2afa
Closes-Bug: #1768742
This commit is contained in:
Ilya Shakhat 2018-05-17 11:50:53 +02:00 committed by Tovin Seven
parent e1ba98e13a
commit 56e5ce42e7
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
osprofiler/drivers/redis_driver.py
View File

@ -23,7 +23,7 @@ from osprofiler import exc
class Redis(base.Driver):
def __init__(self, connection_str, db=0, project=None,
def __init__(self, connection_str, project=None,
service=None, host=None, conf=cfg.CONF, **kwargs):
"""Redis driver for OSProfiler."""
@ -38,10 +38,9 @@ class Redis(base.Driver):
"'redis' manually. Use command:\n "
"'pip install redis'.")
parsed_url = parser.urlparse(self.connection_str)
self.db = StrictRedis(host=parsed_url.hostname,
port=parsed_url.port,
db=db)
# only connection over network is supported with schema
# redis://[:password]@host[:port][/db]
self.db = StrictRedis.from_url(self.connection_str)
self.namespace = "osprofiler:"
self.namespace_error = "osprofiler_error:"
@ -147,7 +146,7 @@ class Redis(base.Driver):
class RedisSentinel(Redis, base.Driver):
def __init__(self, connection_str, db=0, project=None,
def __init__(self, connection_str, project=None,
service=None, host=None, conf=cfg.CONF, **kwargs):
"""Redis driver for OSProfiler."""