Commit Graph

5 Commits

Author SHA1 Message Date
Takashi Kajinami e62823d134 Bump hacking
... because hacking 3.0.x is too old. pylint is also bumped to resolve
conflicting dependencies. The new version is currently used in neutron.
The pylint setting is imported from neutron with one additional
disablement to ignore the following error.

ovsdbapp/schema/open_vswitch/helpers.py:47:14: R1732: Consider using
'with' for resource-allocating operations (consider-using-with)

Change-Id: I41b4524ff13b8d46d2e0c76f09b5ec47601bd955
2024-01-27 23:14:24 +09:00
zhouxinyong e6c2f1fed1 Update hacking for Python3
The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.

Fixed related code warnings and updated .pylintrc.

Change-Id: I5e82d29e0d6f09b98bebdd5dbcc34b01512b28ef
2020-04-01 10:06:32 -04:00
Chuck Short ac3c95c1b4 update pylint to 1.9.2
The older version of pylint being used does not work
correctly under python 3. In order to be able to
update the pylint job to run under python 3,
we need to update the tool.

Aslo fix a couple of pylint issues:

- Fix import order issues.
- Fix 'no-else-return' checks.

Added the following to the blacklist:

- inconsistent-return-statements
- catching-non-exception
- using-constant-test

Change-Id: I91a304241ebdb4d6bd15509cae8463d7b43b3c0f
Signed-off-by: Chuck Short <chucks@redhat.com>
2018-08-21 09:36:16 -04:00
Jakub Libosvar 0823a67e6e pylint: Disable duplicate-code for check
Duplicated code is recognized on same imports which in modules that
implement specific API doesn't make sense as imports will be likely the
same: e.g.
http://logs.openstack.org/41/470441/28/check/gate-ovsdbapp-pep8-ubuntu-xenial/84bbf0c/console.html#_2017-07-03_20_00_50_632331

The patch disables this check for pylint.

Change-Id: Ia1d410abcf53d30ef71edb5404cf53b430aa3523
2017-07-03 20:31:35 +00:00
Dong Jun 15d956380b Enable pylint 1.4.5
This patch enables pylint 1.4.5 checking in ovsdbapp.
Script tools/coding-checks.sh is copied from neutron and adapted for
ovsdbapp.
.pylintrc is also copied from neutron, message options that do not
need to be suppressed have been removed.
This patch also adjusts code to fit pylint 1.7.1

Change-Id: If27c9a13798f20f3c22ca62a38cb93e7ad602a18
2017-06-30 09:54:53 +08:00