... because hacking 3.0.x is too old. pylint is also bumped to resolve
conflicting dependencies. The new version is currently used in neutron.
The pylint setting is imported from neutron with one additional
disablement to ignore the following error.
ovsdbapp/schema/open_vswitch/helpers.py:47:14: R1732: Consider using
'with' for resource-allocating operations (consider-using-with)
Change-Id: I41b4524ff13b8d46d2e0c76f09b5ec47601bd955
That fixes some dependency clashes in py36 job when installing
"pylint" with "astroid" library.
Closes-Bug: #1955724
Change-Id: I7cc4b779c68fe21d6ca50b6c76cdd2b6edaa7ea2
Bumped a bunch of constraints and requirements to fix
a gate failure with recent pip update.
Fix associated new warnings.
Change-Id: Ibc6f6025b89f2ac893471bf58794569804545b9d
New versions of isort broke pylint. This patch fixes it at 4.3.21.
Change-Id: Ie1b3b162e18090ae1cc90998b5a41d74b9ef2876
Depends-On: https://review.opendev.org/739469
flake8 new release 3.8.0 added new checks and gate pep8
job start failing. hacking 3.0.1 fix the pinning of flake8 to
avoid bringing in a new version with new checks.
Though it is fixed in latest hacking but 2.0 and 3.0 has cap for
flake8 as <4.0.0 which mean flake8 new version 3.9.0 can also
break the pep8 job if new check are added.
To avoid similar gate break in future, we need to bump the hacking min
version.
- http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014828.html
Change-Id: I5e11540d7a97928a520944a32c3780fdef7b9d65
The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.
Fixed related code warnings and updated .pylintrc.
Change-Id: I5e82d29e0d6f09b98bebdd5dbcc34b01512b28ef
Start publishing docs with using the proper template.
For this, add also a doc/requirements.txt file and move docs
requirements there. Update tox.ini for this and use the modern way to
invoke sphinx-build for building.
Remove obsolete sectoins from setup.cfg.
Update the conf.py files and remove unused lines
with newer openstackdocstheme - and require newer theme.
Fix indents in CONTRIBUTING.rst so that the formatting works nicely.
Also, use lower-constraints template instead of individual jobs.
Change-Id: Ia1a7030878f12ca0b8184363173eada929ece3bd
1. Sync sphinx dependency with global requirements. It caps python 2 since
sphinx 2.0 no longer supports Python 2.7.
Change-Id: I6d4b6a378435d89d409bb92e60bb34ca6dfd5af8
The older version of pylint being used does not work
correctly under python 3. In order to be able to
update the pylint job to run under python 3,
we need to update the tool.
Aslo fix a couple of pylint issues:
- Fix import order issues.
- Fix 'no-else-return' checks.
Added the following to the blacklist:
- inconsistent-return-statements
- catching-non-exception
- using-constant-test
Change-Id: I91a304241ebdb4d6bd15509cae8463d7b43b3c0f
Signed-off-by: Chuck Short <chucks@redhat.com>
According to Openstack summit session [1],
stestr is maintained project to which all Openstack projects should migrate.
Let's switch to stestr as other projects have already moved to it.
[1] https://etherpad.openstack.org/p/YVR-python-pti
Change-Id: I32db99af179412f46b02ced9eaf61049cbffcdb0
This patch enables pylint 1.4.5 checking in ovsdbapp.
Script tools/coding-checks.sh is copied from neutron and adapted for
ovsdbapp.
.pylintrc is also copied from neutron, message options that do not
need to be suppressed have been removed.
This patch also adjusts code to fit pylint 1.7.1
Change-Id: If27c9a13798f20f3c22ca62a38cb93e7ad602a18