Commit Graph

80 Commits

Author SHA1 Message Date
Nisha Agarwal 43570962b3 Fix the method create_csr
Change-Id: I89c930b2c4f7363821441b17ff29755b559061db
2022-03-29 17:41:54 +00:00
paresh-sao 792cd4185b Fix virtual media insertion of invalid url
This patch fixes 'insert_virutal_media' api to through an error
when the url given is either invalid or unreachable.

Closes-Bug: 1958976
Change-Id: I1d49086e214fe86a5bf5bc3986e7e886ee28ff30
2022-02-16 01:21:55 +00:00
Riccardo Pittau 6e03a55374 Enable check import order
Enable pep8 import order Using flake8-import-order.

Change-Id: I89e192d9c756156b4e86cbbf2399b9b23fb5edd5
2020-07-06 15:20:12 +02:00
Riccardo Pittau 64540ba316 Bump hacking to 3.0.0
The new version enables a lot of standard flake8 checks, so a few
fixes are required. W503 is disabled as it conflicts with W504
and the latter seems to be preferred nowadays.
Also excluding C901 and E731 that should be fixed in different
patches as they require code changes.

Change-Id: I8decccc4925f86e0b979b47e2920d6a782d991d7
2020-03-31 09:45:01 +02:00
kesper bdb14f3419 Follow-up patch for UEFI iSCSI boot nic adapter fix
This commit addresses comments on UEFI iSCSI boot patch
for multiple nic adapter support.

Change-Id: I626bb5db7d496a68c622fdd6ab6c2fa3ecff07fc
2019-08-29 08:30:41 +00:00
paresh-sao 94d4e1c372 Fixed problem with UEFI iSCSI boot for adapters
This commit fixes problem with multiple nic adapter
by adding mac as an optional parameter to pass macs in
such cases.

Change-Id: Iea420d7a047c8ac849fa2eeab5c6892be2d7a6e1
Bug-Id: 1838730
2019-08-23 06:42:45 +00:00
Nisha Agarwal a7c0ced92b Fixes the storage capabilities
This patch fixes the storage code which
fails in certain cases while fetching
certain storage related capabilities.

Change-Id: If7e3e0cfd8342f1d5c0deccca528fd9d23451a55
2019-08-22 01:34:03 -07:00
vmud213 a03de4f619 Removes filter on the bios settings.
This fix changes the default behavior to consider all the BIOS settings
rather than applying filter on them for only specific settings.

Change-Id: I19dc807c41a52136e8f7c306004508885af2733d
2019-07-31 17:01:02 +00:00
Nisha Agarwal 5fbd785e91 Revert "Add NIC inspection for Gen9"
This reverts commit 7286d7019c.
The fix is reverted because iLO4 behaviour is not consistent in
reporting the NIC data even for MCTP compliant NIC cards.
And iLO4 does not has the intelligence to detect the
NIC health status out-of-band for non-MCTP compliant NIC cards.
It reports the correct status only when AMS is running on the
server which requires OS to be present onto the system.

Change-Id: I02c27d820b27bd532f23ab7ef276b39f868f5205
2019-02-28 03:30:30 -08:00
Nisha Agarwal 7286d7019c Add NIC inspection for Gen9
This commit adds NIC inspection for Gen9 and just
gets the MACs which are physically connected through
a cable.

Closes-Bug: 1812623
Change-Id: Ica624aae8f956a2da061801def6ddc43152a5b09
2019-02-06 23:59:45 -08:00
Zuul 34fabd5c4c Merge "Adds API to get the results of the BIOS settings" 2018-10-05 10:38:04 +00:00
vmud213 377a8a96c0 Adds API to get the results of the BIOS settings
This commit adds an API to get the results of the BIOS settings applied
prior to the latest power cycle.

Change-Id: Ia6786889b717105e9af67faa15da815ad2f4e4cb
Closes-Bug: 1790776
2018-10-04 16:04:03 +05:30
Shivanand Tendulker 5d5e784e94 Follow-up for commit 0e9f3d1b46
This patch addresses minor comment given in the commit
0e9f3d1b46

Change-Id: Ifa439779a22ef61f91cc79bd8f964c1d1a27758c
2018-09-18 08:11:07 -04:00
Zuul 8ac17b2f84 Merge "Validates the BIOS settings before applying" 2018-09-07 12:51:34 +00:00
vmud213 0e9f3d1b46 Validates the BIOS settings before applying
If 'only_allowed_settings' filter is applied, this change validates if
each of the settings provided is supported. If any setting is provided which
is not supported by the user, 'IloError' exception is thrown.

Change-Id: I966db94634b7e3021f07dc45dcca5cc4f5120329
Closes-Bug: 1785782
2018-09-07 13:22:57 +05:30
Anshul Jain 72ba876a58 Redfish: Adds 'read_raid_configuration' API to get current raid config
This commit adds functionality to verify the success of raid create
or delete operation and gets the current raid configuration on
SmartStorageConfig redfish based iLO.

Co-Authored-By: Paresh Sao <paresh.sao@hpe.com>
Change-Id: I9f546e8ef87229f442dc3855042cbe3ac3a198f8
2018-08-27 09:02:39 +00:00
Anshul Jain 8bda342451 Redfish: Adds `create_raid_configuration` API to create raid.
This commit adds functionality to create logical drives in a
SmartStorageConfig redfish systems.

Co-Authored-By: Paresh Sao <paresh.sao@hpe.com>
Change-Id: I679deac7e6b15d7a0de980fb16c9e283780fca80
Closes-Bug: 1716329
2018-07-23 11:21:28 +00:00
Anshul Jain 2cf3a473c9 Redfish: Adds 'delete_raid_configuration' API to clear raid
The commit adds functionality to delete logical drives in a
SmartStorageConfig redfish systems.

Co-Authored-By: Paresh Sao <paresh.sao@hpe.com>
Change-Id: Id3a07ab0ca1c0ad8199a28ef2efb22aadc5edfd5
2018-07-18 08:38:48 +00:00
vmud213 21549e746d iLO RIS: Add support to manage BIOS settings
Adds support to get current BIOS settings, default BIOS settings and
pending BIOS settings for Gen 9 systems. Also provides support to update
the BIOS configuration with the provided configuration.

Change-Id: I5f8ed4e5c0ee4abf472b261846829d877522258e
2018-07-17 14:44:12 +05:30
Shivanand Tendulker ffe1e61cf2 Add support for retrieving system POST state
This commit adds support for retrieving system POST state for Gen9 and
Gen10 servers.

Note: These is no RIBCL interface to retrieve system POST state.

Change-Id: Ib8d99a9fa3ece9baa17b5bb37d2f87917750350e
Partial-Bug: #1762311
2018-07-13 09:58:15 +00:00
Zuul 48741568b1 Merge "Add support for NMI(Non Maskable Interrupt)" 2018-07-13 06:20:54 +00:00
Shivanand Tendulker f3db9b7c8a Add support for NMI(Non Maskable Interrupt)
This commit adds support for NMI for Gen9 and Gen10 servers.

Note: These is no RIBCL interface to perform NMI using RIBCL.

Change-Id: Iaf663443179417e47d022098c73a4776d41d4287
Partial-Bug: #1762311
2018-07-10 08:18:10 -04:00
Nisha Agarwal 258b18d302 Make case-insensitive search for Blade server model string
Closes-bug: 1761243
Co-Authored-By: M V P Nitesh <parimalanitesh@gmail.com>

Change-Id: Ia7db061bb8848388c769411d84208b7c925864c8
2018-04-25 09:47:05 +00:00
vmud213 42f14bd6a7 Retain "mac" argument for backward compatibility
Add methods to support backward compatibility by retaining the "mac" argument
for the exisiting methods that support managing iSCSI information.

Change-Id: I5e006556e5303fd8febc836b1bd355b87933f1eb
Closes-Bug: #1744307
2018-01-19 18:29:05 +05:30
Zuul 00531fd385 Merge "Retry power on operation for Blade servers" 2018-01-15 06:05:21 +00:00
paresh-sao 5f71652533 Redfish: Adding the ability to set and unset iSCSI boot info
This commits adds new functions 'set_iscsi_boot_info' and
'unset_iscsi_boot_info' to change iSCSI settings on iLO.

Change-Id: I855ae6a4b2ab84e939cf6b0c49f2af001f6a3173
2018-01-11 11:19:59 +00:00
Zuul 8ba1e9ef0e Merge "Remove 'mac' argument for [un]set_iscsi_boot_info()" 2018-01-10 05:39:31 +00:00
paresh-sao 176aefbc9b Remove 'mac' argument for [un]set_iscsi_boot_info()
This adds changes to both iSCSI boot related interfaces
'set_iscsi_boot_info' and 'unset_iscsi_boot_info' so
iSCSI attempt is done for all nics instead one.

Change-Id: I871d3e5da579bb8fddeb265267c9c7df76d370c4
Closes-Bug: #1739405
2018-01-05 05:41:32 +00:00
paresh-sao b3cc428789 Changed '_update_persistent_boot' to set 'UefiTarget' boot device
also removed 'mac' from 'set_one_time_boot'

Adds modification in '_update_persistent_boot' to set 'UefiTarget'
as boot device, without using 'mac' also removed 'mac' from
'set_one_time_boot' and 'update_persistent_boot' as revert of
'25f4881730d80a9142d9cf181618b38185d33c91.'

Change-Id: I2c0f95aed084f415b1c065f1a97936d75bdab366
Closes-Bug: #1727670
2018-01-04 04:17:49 +00:00
paresh-sao 579b71710a Add support to set iSCSI initiator information
This commit adds support to set iSCSI initiator information
of iLO using RIS.

Change-Id: I0a239727b395b4361447aef3bd8a763c96cf574e
2017-12-19 05:50:09 +00:00
Nisha Agarwal fd3dbea575 Retry power on operation for Blade servers
This patch retries power on operation if it fails
to power on in definite time. This is needed
only for Blade servers. The fix is done for
Gen9 Proliant servers.

Change-Id: I088b8cf9bbde057c5536cad6368fce7d8d608f41
Closes-bug: 1725204
2017-12-06 14:20:55 -08:00
paresh-sao d6aa7eaf1b Add support to get iscsi initiator information
This commit adds support to get iscsi initiator information
of iLO using RIS.

Change-Id: I2040661c7cead33b06295f800661f436a98063c9
2017-10-27 06:18:24 +00:00
Aparna e6b834c8ed Change server capability 'raid_support' to 'hardware_supports_raid'
Change-Id: Ie4002b6b08ed02dcd6946ce1230a0ee4d38d96f1
2017-08-03 11:43:33 +00:00
Aparna 5cae90ec8e Support to get hardware raid support
This commit adds support to get raid support
on a bare metal.

Change-Id: I4307a1003202ace6b153de69b04e0bd8f0616e07
2017-07-27 11:45:18 +00:00
Nisha Agarwal ee97a8a8ed Discover Storage details
Discover following attributes:
has_ssd
has_rotational
drive_rotational_<speed>_rpm
logical_raid_level_<raid_level>

Change-Id: Ib987651d78057719033366417dd3addf46d14578
2017-07-27 04:18:49 -07:00
Nisha Agarwal a8dd93607f Discover iscsi_boot attribute
This patch adds the capability iscsi_boot to the
server capabilities.

Change-Id: I2b51108d4ff6a07035db5cb512eb82155059eecb
2017-07-27 00:30:35 -07:00
Nisha Agarwal 8acf275f52 Add supported boot modes to server capabilities
Added a new function ``get_supported_boot_mode`` to ris to check the
value of BIOS-UEFI class supported on the server. This method was
already present in ribcl. It gets used through client interface to be
used in turn by ``get_server_capabilities``. The following properties
are updated as part of invoking this method:

    boot_mode_bios
    boot_mode_uefi

Also, removed the unused method ``_get_server_boot_modes`` from ribcl.
Added a utility method in ``ilo.common`` complementing supported boot
modes extraction.

Co-Authored-By: Debayan Ray <debayan.ray@gmail.com>
Related-Bug: 1526382
Change-Id: I7a60e660a6f5e574e53128f824bae0909d66d9ff
2017-07-26 04:14:00 -04:00
Aparna a999200227 Add 'sriov_enabled' capability
This commits adds 'sriov_enabled' capability
for redfish and ris.

Change-Id: Iade847df6257096db2ca4101b02537f994aae073
2017-07-19 12:49:06 +00:00
Shivanand Tendulker f3c4ffc92b Set 'trusted_boot' capability only when TPM chip is present
Need to populate the 'trusted_boot' capability only when TPM chip
is present. These capabilities gets used during scheduling and
needs to be set only when corresponding feature is available.

Change-Id: I1113bc5025fa643dc2d1c6cb9fd8e91da1b0331f
Closes-Bug: #1688463
2017-05-08 07:56:45 -04:00
kesper 86759d886b Adding capability to check NVDIMM_N availability
This commit adds a new capability to check NVDIMM_N
availability using the bios parameter on the ProLiant Servers.

Change-Id: I91206332562bc5929df06806884811af73738304
2017-05-08 05:07:00 +00:00
kesper 641813c18f Add support to get cpu virtualization capability
This commit adds support to get cpu virtualization status
enable or not using RIS.

Change-Id: Idc0369d3f280efac669e85175abdd2b356c7e776
2017-05-05 07:25:23 +00:00
Debayan Ray 1226273f26 Separate out rest infra from ris
This patch is again targeted towards support of consuming
Redfish APIs. ReST infrastructure has been separated out from
RIS module to be used by both RIS and Redfish portions.

Partial-Bug: 1646685
Change-Id: I9b40bf732589b3604ed1e0726a0f895b49213058
2017-04-07 11:56:20 -04:00
Debayan Ray 0a3a490d34 Refactor ris-rest infrastructure
This patch refactors the rest infrastructure in ris in
following ways:

    - Includes ``retrying`` package to retry on redirection
    - Modularized the rest infra code
    - No behaviour change as such barring the log output

Partial-Bug: 1646685

Change-Id: I155f961c034b1d9ac9a962974d8461c1097987e3
2017-04-07 04:54:24 -04:00
Jenkins 35b19cde86 Merge "Add trusted_boot to server capabilities" 2017-03-03 08:35:25 +00:00
Nisha Agarwal 595aa9a821 Add trusted_boot to server capabilities
This patch adds the trusted_boot capability to
ironic nodes.

Change-Id: I472465f5020f92a2b0fd79707a6ee75abcbbcdf3
2017-01-24 08:58:45 +00:00
Jenkins a405ca43e5 Merge "Adds 'UefiTarget' as a boot option" 2017-01-05 09:31:44 +00:00
kesper 3bfdc3f70e Adds 'UefiTarget' as a boot option
This commit adds 'UefiTarget' as a
boot option which performs iSCSI boot
in iLO

Change-Id: I65af17e0ccb0b9c76b6edf9a7b689a591dda94ca
Closes-Bug: #1647690
2017-01-05 06:33:23 +00:00
kesper 6364db9d72 Support to disable iscsi boot option in iLO
This commit adds changes to disable iscsi boot
option in iLO.

Change-Id: Ia8946e196002f51c0e00d6273b474d030671bc1a
Closes-Bug: #1647537
2017-01-04 05:22:26 +00:00
kesper dfff9e6564 Change to disable target DHCP in iLO
For boot from iscsi volume when the iscsi target
parameters are passed then the target DHCP should
be set to False in iLO.

This commit adds changes to disable target DHCP for
uefi iscsi boot in iLO. The parameter
`iSCSITargetInfoViaDHCP` is set to False which disables
the DHCP.

Change-Id: I3b70be02ee2211b4a40ac40d93331c299deb9bf6
2016-11-29 05:15:29 -05:00
ankit 369f0c3800 Fix log message for exception in Gen7
Previously the exception raised for Gen7 servers were
not handled properly.

This commit resolves the issue by handling the exception
in a appropriate manner.

Change-Id: I7371fb26e78a558ee382bbe9785e6401c51437bd
Closes-Bug: #1613831
2016-08-30 08:26:20 +00:00