Commit Graph

389 Commits

Author SHA1 Message Date
Riccardo Pittau f655e23cef Keep using pysnmp-lextudio to avoid conflict installation
The pysnmp-lextudio version is more recent and maintained, we should
keep using that for the time being to avoid conflicts of
installation with ironic, while using simple pyasn1.

Change-Id: Icb6e7779100b676685e227e225fde5c392141333
2024-03-15 10:43:15 +01:00
Paresh Sao 68e2d8a51c Revert "Migrate to pysnmp lextudio ecosystem"
This reverts commit 56c507344d.

Change-Id: Ie72b2a955d49cd6d1d5a802d499dd45cea9a518e
2024-03-11 05:50:23 -04:00
Nisha Agarwal 5839129389 Adds a retry workaround for power ON failure
Closes: 2021995
Change-Id: Id98474c334840ecc86371aa6b6395f7b4d6b1714
2023-09-06 11:36:15 +00:00
Riccardo Pittau 56c507344d Migrate to pysnmp lextudio ecosystem
The pysnmp library is not maintained since 4 years now and it's
incompatible with recent libraries like pyasn1.
Its fork pysnmp-lextudio is regularly maintained, we should move
to that.
For more info see https://github.com/etingof/pysnmp/issues/429

Change-Id: Ic37805b39054b1d6a4a4c69a8faf57b512d920a0
2023-06-13 10:35:53 +02:00
Nisha Agarwal a07293a63f Update Sushy version to latest
Change-Id: I9834d810a4125b40584aa896e707fcaf2794054a
2023-05-09 20:46:49 +00:00
Zuul ad0d7c0382 Merge "Fix etag header test" 2023-05-05 10:43:20 +00:00
Riccardo Pittau 42c4cc5681 Fixes for tox 4
Change-Id: If8df3833e66f02b4fbb51cf8d19c26197bfe997e
2023-02-14 10:11:42 +01:00
Riccardo Pittau 3cde50caf5 Use tests from antelope
Also fix unit test for sushy update.

Change-Id: I9548e1685f240cc7e559d9f029071099b2191068
2022-12-13 13:45:16 +01:00
Julia Kreger f03714f78c Fix etag header test
Proliantutils has a pattern of testing internal calls inside of
the Sushy library. This has the unfortunate side effect of becoming
broken as bugs and related issues are fixed.

Fixes the check on a response which upstream sushy has discovered
has become sensitive on several vendors where eTags must be utilized
to ensure a reliable and correct response from the BMC.

Related-Bug: #1976555
Change-Id: I6b802fbb6a3f93f67269c141cad02b58ccd2d3ac
2022-11-28 11:07:19 -08:00
Mallikarjuna Reddy Kolagatla de9759c0d2 Fix create_csr to create csr with node-uuid as name
Change-Id: Ib586139ad60cafa9ac474fa9136ce52483f4d680
2022-09-06 10:59:11 +00:00
Nisha Agarwal 7c2993f336 Update testing to zed and fix the broken test cases
Change-Id: Idb1d362bc890afbc6bd6b4aca42a5eed841d1b35
2022-09-06 10:06:10 +00:00
Nisha Agarwal 43570962b3 Fix the method create_csr
Change-Id: I89c930b2c4f7363821441b17ff29755b559061db
2022-03-29 17:41:54 +00:00
Nisha Agarwal 535e465c30 Remove deprecation from create_csr and add_https_certificate
Change-Id: Id18e39e174b19478cac723994e7e18aa1e30be13
2022-03-21 12:47:42 +00:00
ankit 084b0acb8b Making changes to csr and https certificate
This commit will support creation of https certificate.

Change-Id: I58989351b24f7cc2520caff5351ab8a6e553554c
2022-02-18 11:12:24 +00:00
Nisha Agarwal ed00e9ee2e Fix test cases for sushy 4.1.0
Change-Id: I28ab424fd1bd371e32288affd52b7d8722d419ae
2022-02-18 10:35:11 +00:00
Nisha Agarwal 9449101bd2 Fix few bugs in inspection
Change-Id: I6ace0784941d29e0ace3bd26a2d261c625765371
2022-02-16 14:15:39 +00:00
paresh-sao 792cd4185b Fix virtual media insertion of invalid url
This patch fixes 'insert_virutal_media' api to through an error
when the url given is either invalid or unreachable.

Closes-Bug: 1958976
Change-Id: I1d49086e214fe86a5bf5bc3986e7e886ee28ff30
2022-02-16 01:21:55 +00:00
Riccardo Pittau 682eb63985 Update testing to yoga
Update jobs and requirements to yoga
Also fix tests where needed

Change-Id: I5dbf28d0ac77d81cc8f79496777aa15be3c52dd0
2021-12-03 08:58:54 +01:00
Dmitry Tantsur 500f518d40 Update for sushy 4.0.0
* Mappings used to be an implementation detail, and now they're gone.
  The CPU architecture handling was wrong anyway, copy it from Redfish.
* Update some tests to rely on Sushy constants rather than their copies.
* Mock sleep() in tests that can take a lot of time to finish.

Change-Id: I681c829a806fdf2c69ad0af8bbba1b527bffb926
2021-11-30 10:54:25 +01:00
Nisha Agarwal 29751a500b Fix the test cases for latest sushy
This patch fixes the test cases which are dependent on
changes in sushy library version 3.12.0.

Closes-Bug: 1950421
Change-Id: I485010c613b0e8d5d4c9bcb96959730bae42dc88
2021-11-09 23:48:40 -08:00
Zuul abc6432029 Merge "Adding changes for HTTPS Cert" 2021-07-29 05:14:47 +00:00
vmud213 06b4eed744 Add support to exclude finger prints of certs
Currently while removing the CA certificates from the iLO, when certificate
file list is empty, all the CA certificates from the iLO are removed. In some
cases certain certificates are required to be retained on the iLO. This
patch fixes the issue by accepting the list of certificates to be retained on
the iLO.

Change-Id: I4898361527e5785e181cffaf294557db0078c93d
2021-07-14 15:23:45 +00:00
ankit 79c2384a54 Adding changes for HTTPS Cert
This commit adds support for generating Certificate
Signing Request and importing Signed Certificates to iLO5.

Change-Id: I116e685d4f1e190679c2faa8fa296202f2433759
2021-06-23 12:32:25 +00:00
Zuul 2be2d0e18d Merge "Adds changes for security_dasboard clean_step" 2021-03-05 10:48:00 +00:00
Nisha Agarwal 03e0d7a3c4 Adds changes for security_dasboard clean_step
Adding changes for below security params
* Password_Complexity
* RequiredLoginForiLORBSU
* RequireHostAuthentication
* MinPasswordLength
* IPMI/DCMI_Over_LAN
* Authentication_failure_Logging
* Secure_Boot

Change-Id: Iac423c409ebec86f65af4b93bbcea161a7bb60af
2021-03-05 09:58:37 +00:00
Nisha Agarwal 8729133641 Adds more gpu capabilities
Change-Id: I1772f794370d4fb2291473f07ee75b9c975c4530
2021-03-04 09:37:32 +00:00
vmud213 43ad8ae6dd Support to clear certificates when no certificates
Adds support to clear certificates when no certificates are provided. In
this case the certificates that currently exist on the ilo are removed.

Change-Id: I351554a0c65d60b63fb7bf57ed1a6bae89f2d71c
2020-11-10 09:12:22 +00:00
Zuul 9a29e32bb2 Merge "[Redfish] Enhance removing TLS certificates" 2020-08-27 16:00:33 +00:00
kesper 1395b6e699 Follow-up patch for proliantutils docs
This patch adds fix for github rendering issue. It will adds
markup language in rst.

Change-Id: I926535b024d42aa4fd5cf9f05cb53766dca201a5
2020-08-27 11:58:29 +00:00
vmud213 92b9d4ac1b [Redfish] Enhance removing TLS certificates
Enhances the TLS certificate removal logic so that it now accepts
the list of TLS certificate files instead of fingerprints. Also
enhances the logic of exporting TLS certificates if multiple
certificates are present in a single file.

Change-Id: Ida1f13c27cea1134a38f5f8465398c63272494fb
2020-08-27 09:19:59 +00:00
Zuul 9734712019 Merge "Add security dashboard attributes" 2020-08-27 08:20:20 +00:00
Zuul 212c8ce709 Merge "Adds documentation for proliantutils" 2020-08-27 06:48:06 +00:00
kesper 872d0363c9 Adds documentation for proliantutils
This commit adds documentation for proliantutils

Change-Id: Ia3d66e2ed2e79f1a894d302695d8ca94c129f090
2020-08-27 07:16:11 +00:00
Nisha Agarwal 699dfb0041 Add security dashboard attributes
Change-Id: Ic89c56e178b478a0c653b76a588c10aef037f318
2020-08-26 14:32:04 +00:00
kesper 0d9b4ac662 Adds support for one button secure erase
This commit will add support for one button secure erase for iLO5
server.

Change-Id: I71203fa0c500c45d7bc7729c6ad418c11695f1f5
2020-08-06 07:16:36 +00:00
vmud213 af96983b3d [Redfish] Provides APIs to add/remove TLS certificate
Change-Id: I25c827b5dbd443c2827c0faeb9c92c06e7f778f7
2020-07-30 08:20:27 +00:00
Zuul c57437dc85 Merge "Redfish: Adds APIs to support boot from http url" 2020-07-30 05:23:36 +00:00
vmud213 bf33b36e3a Redfish: Adds APIs to support boot from http url
Adds APIs to set and get http url from which the server is configured to
boot from.

Change-Id: Idcb49d1a55e29fc54c91dd054a0b80593a703b3e
2020-07-19 06:59:34 +00:00
Shivanand Tendulker 5dc26eb950 Adds steps 'apply_configuration' and 'flash_firmware_sum'
Following inband deploy steps are added:
1. 'apply_configuration' is added for 'raid' interface.
2. 'flash_firmware_sum' is added for 'management' interface.

Change-Id: I42e153aaa52befb13d0471a2a1f0a2401684aaea
2020-07-14 09:34:55 -04:00
Riccardo Pittau 6e03a55374 Enable check import order
Enable pep8 import order Using flake8-import-order.

Change-Id: I89e192d9c756156b4e86cbbf2399b9b23fb5edd5
2020-07-06 15:20:12 +02:00
Shivanand Tendulker a6d02fb6c2 Adds py3 to tox environment
Adds py3 and removes py27 from tox environment
Fixes testcases that were failing for py38 environment.

Depends-on: https://review.opendev.org/#/c/738168/
Change-Id: I1a5f88c06808449e906d9b8ad43d690136737800
2020-06-26 13:20:41 -04:00
Riccardo Pittau 64540ba316 Bump hacking to 3.0.0
The new version enables a lot of standard flake8 checks, so a few
fixes are required. W503 is disabled as it conflicts with W504
and the latter seems to be preferred nowadays.
Also excluding C901 and E731 that should be fixed in different
patches as they require code changes.

Change-Id: I8decccc4925f86e0b979b47e2920d6a782d991d7
2020-03-31 09:45:01 +02:00
Shivanand Tendulker 5bc756917d Updates mimimum version of sushy in requirements
Minimum version of sushy should be 3.1.0

Change-Id: I905b43bc42ad75329938b15f4b5b7873f59e63ee
Closes-bug: #1864187
2020-02-21 07:45:08 -05:00
Zuul c0c0614661 Merge "Strip whitespace from cookie in firmware update" 2020-02-18 11:12:05 +00:00
Zuul 71389178ae Merge "Decode output of fru print" 2020-02-18 10:42:20 +00:00
Antony Messerli 83266ff678 Decode output of fru print
Decodes bytes object of fru print to string, was failing
during an ilo inspection.

Change-Id: Ieed55ffca1e839ff5a5dfe523038ba03ea14d0d7
Closes-Bug: 1853210
2020-02-18 07:47:30 +00:00
Shivanand Tendulker 0196cd3162 The _op method has changed in sushy 3.10
The sushy method _op() in connector.py accepts new set of arguments.
Proliantutils needs to accept these arguments in its overridden
method.

Change-Id: If66e23209cfcae7c418d1e0dec34add5ed65dc6c
Closes-Bug: #1863236
2020-02-17 07:15:40 -05:00
Mark Goddard 37afea2bbc Strip whitespace from cookie in firmware update
When updating firmware, some devices return a cookie with a newline in.
This can result in the following error:

Invalid return character or leading space in header: Cookie

This is due to the header validation in the requests library, which
requires no newlines in headers.

This change fixes the issue by stripping whitespace from the cookie.

Change-Id: Ib2dab7beef0da415e8f2358b459ec1205bf688b4
Closes-Bug: #1859616
2020-01-17 17:29:56 +00:00
Shivanand Tendulker 086b3485c2 Fixes caching of ilo instances to use admin credentials
Currently the IloClient object cached uses iLO host as the key.
This can be issue if the iLO credentials are changed. The cached
node will not use new credentials leading to failure in
communication with iLO.

Change-Id: Ie1ea10aae78c4dab307d8a31996322597046ecb1
Closes-Bug: 1852688
2019-11-15 02:51:27 -05:00
Shivanand Tendulker 36f90a22d5 Fixes testcases that are broken due to change in sushy
Few of the testcases were broken as we are asserting sushy method which
got changed.

Change-Id: I05c9eee411cf586b5cfc0f4895ab1efc7d2c9b42
2019-11-15 00:55:16 -05:00