Use validate_legacy

This changes all the puppet 3 validate_* functions
to use the validate_legacy function.

The validate_legacy function has been available since
about three years but require Puppet >= 4.4.0 and since
there is Puppet 4.10.12 as latest we should assume people
are running a fairly new Puppet 4 version.

This is the first step to then remove all validate function
calls and use proper types for parameter as described in spec [1].

[1] https://review.openstack.org/#/c/568929/

Change-Id: I5644b1b2e8c0c90ed1de91631cbfc2cd1a9ddd07

manifests/config.pp

@@ -30,8 +30,8 @@ class aodh::config (
 
   include ::aodh::deps
 
-  validate_hash($aodh_config)
-  validate_hash($aodh_api_paste_ini)
+  validate_legacy(Hash, 'validate_hash', $aodh_config)
+  validate_legacy(Hash, 'validate_hash', $aodh_api_paste_ini)
 
   create_resources('aodh_config', $aodh_config)
   create_resources('aodh_api_paste_ini', $aodh_api_paste_ini)

manifests/db/mysql.pp

@@ -45,7 +45,7 @@ class aodh::db::mysql(
 
   include ::aodh::deps
 
-  validate_string($password)
+  validate_legacy(String, 'validate_string', $password)
 
   ::openstacklib::db::mysql { 'aodh':
     user          => $user,

manifests/policy.pp

@@ -31,7 +31,7 @@ class aodh::policy (
   include ::aodh::deps
   include ::aodh::params
 
-  validate_hash($policies)
+  validate_legacy(Hash, 'validate_hash', $policies)
 
   Openstacklib::Policy::Base {
     file_path  => $policy_path,