Commit Graph

258 Commits

Author SHA1 Message Date
Takashi Kajinami a67c2c8caa Drop barbican-specific database options
These options were renamed and now barbican uses the consistent options.

Depends-on: https://review.opendev.org/c/openstack/barbican/+/848011
Change-Id: Icd79dafba400b55d023387da3ae704a6186cefa2
2024-04-15 14:31:20 +00:00
Takashi Kajinami 0b649011d9 [p11_crypto_plugin] login should be secret
... because the option accepts password to login to PKCS11 session.

Change-Id: Ide5ffb33aa8ac640f7a3b552d577d4c820565402
2024-03-29 16:47:08 +09:00
Takashi Kajinami 9a728d5a5d Expose rabbit_transient_quorum_queue
Depends-on: https://review.opendev.org/911021
Change-Id: Icdc456fb132d74037dff7ce5c502994103061258
2024-03-13 16:14:10 +09:00
Takashi Kajinami d2625af949 Deprecate parameters for certificate plugins
... because certificate plugins were deprecated some time ago in
Barbican and are being removed in this cycle.

Depends-on: https://review.opendev.org/c/openstack/barbican/+/909640
Change-Id: Ie2dacb037a3d5ba8f1732ddb8f4b8ea8ded1e5ed
2024-03-08 13:41:21 +09:00
Zuul 9c0930273d Merge "Refactor resource dependencies" 2024-02-29 08:15:12 +00:00
Takashi Kajinami 33492bfc70 Support [queue] asynchronous_workers option
... which determines number of processes launched in barbican-worker.

Change-Id: Ia31a7d440ba3102afa7b5972fe893cfb4f1817a1
2024-02-25 16:54:46 +00:00
Takashi Kajinami 276812bec6 healthcheck: Expose ignore_proxied_requests parameter
Depends-on: https://review.opendev.org/909807
Change-Id: Id5c5cb90a50983357d0c8001eedefedb3fd60f4d
2024-02-22 03:04:48 +00:00
Takashi Kajinami 7040e66812 Refactor resource dependencies
This refactors resource dependencies to improve the following points.

 - Avoid unnecessary dependencies across services. For example aodh
   service does not require cinder db.

 - Restart only api service when config files like paste.ini, which
   are used only be api service is changed.

Change-Id: Iad138f5d2e8c7427e02b889c43c26f00213636f3
2024-02-17 21:23:16 +09:00
Zuul 926d47ea1d Merge "healthcheck: Expose allowed_source_ranges" 2024-01-18 16:42:11 +00:00
Takashi Kajinami 7c460507f2 healthcheck: Expose allowed_source_ranges
... which was added to puppet-oslo recently.

Depends-on: https://review.opendev.org/905557
Change-Id: I5d81635643b0cb8ceac80702e2d539db73c598e9
2024-01-17 02:39:52 +09:00
Zuul b23fc4b8cb Merge "vault: Drop redundant hard-coded default of use_ssl" 2023-12-15 18:21:08 +00:00
Zuul f5b72e871d Merge "kmip: Leverage the service default" 2023-12-15 18:00:44 +00:00
Takashi Kajinami 01ececb278 vault: Drop redundant hard-coded default of use_ssl
... because the option defaults to false in Barbican itself.

Change-Id: I328421404969571111a24d9c8a42c3da884a512b
2023-12-15 16:50:35 +09:00
Takashi Kajinami 5bd12fd7f4 kmip: Leverage the service default
The kmip plugin uses the reasonable default tcp port (5969) in case
the port option is not set.

Change-Id: Ic32a397e93479f7d54e22e3f94e35c7c95dbbca4
2023-12-15 16:42:32 +09:00
Takashi Kajinami 784c7fd120 retry_scheduler: Simplify package/service check
... by maintaining os-family handling in the centralized place.

Change-Id: Ib0cc4d0470296fa58fd89cc53bb982bd7424afbb
2023-12-11 22:40:50 +09:00
Takashi Kajinami 19f9032983 Use new openstackclient tag
The new openstackclient tag was added so that we can get all resources
about openstack CLI more easily. This adds this tag to barbicanclient
because the package provides some sub-commands.

Change-Id: I8f1f8b4a6de6ca0d95c2f53a89a1d50a6c82d29e
2023-11-19 16:16:23 +00:00
Takashi Kajinami ca2fd10f71 Accept array for barbican::api::enabled_secret_stores
The parameter defines the value of [secretstore] stores_lookup_suffx
option, which is a ListOpt.

Change-Id: I78954f70700cbcfe1f76f311d1a61cd1c6e45abf
2023-11-08 01:05:56 +09:00
Takashi Kajinami 7bcaae05f6 Remove cleanup of [DEFAULT] bind_host and bind_port
The cleanup logic was added before 2023.1 release so we can assume
these options are purged before a deployment is upgraded.

Change-Id: If6949bb89b01104abe09515c6b93f7d7fed709d5
2023-10-13 21:49:08 +09:00
Zuul 21312a3279 Merge "RabbitMQ: Add support for quorum queue options" 2023-09-15 15:59:13 +00:00
Takashi Kajinami 122686e238 RabbitMQ: Add support for quorum queue options
Depends-on: https://review.opendev.org/894866
Change-Id: I55b5eb5d6139f464f633d5c13827fea91378e3b7
2023-09-14 22:48:48 +09:00
Takashi Kajinami db0bd5156d Do not restart services after policy file changes
The oslo.policy library has implementations to detect change in policy
rules and reload the new rules without service restart.

Change-Id: Ibe9d189f1c12a91a7327f819726695aa52417ac7
2023-09-11 12:25:52 +09:00
Takashi Kajinami d459be69cd Ensure purge_config takes a boolean value
The purge_config parameters only accept boolean values. This enforces
that using the typed parameters.

Change-Id: I669f1a2ff2462d60afe2fbd0c33e607d20cb14fc
2023-07-17 13:00:23 +09:00
Zuul 6e2515b4fd Merge "Add per module policy service refresh" 2023-06-26 15:24:24 +00:00
Tobias Urdin c38323518b Add per module policy service refresh
Updating the policies for this project should only
refresh the services that reads it.

Change-Id: I42153ec891feb569a9614166104be5382d893f96
2023-06-26 00:03:26 +02:00
Takashi Kajinami 7775352fcd authtoken: Make password required
The password parameter is not really optional. This makes it
a required parameter to give more sensible validation error.

Change-Id: I482621899616f6e3dc902900b0933ffa58ca519a
2023-06-23 10:23:43 +09:00
Takashi Kajinami d3724a40b2 replace validate_legacy with proper data types
the validate_legacy function is marked for deprecation in
v9.0.0 from puppetlabs-stdlib.

Change-Id: I0707b0a8b200480dbfb8f52353596127cf4dc8b5
2023-06-16 02:07:13 +09:00
Takashi Kajinami 578e24a0b9 Add strict validation about boolean parameters
This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.

Change-Id: I963d73e46f82a780486fa282b424151485e43d1e
2023-03-03 04:36:46 +00:00
Takashi Kajinami 729f5d286c Replace legacy facts and use fact hash
... because the latest lint no longer allows usage of legacy facts and
top scope fact.

Change-Id: I6e76d095bb0f78ef4962f1150da94e4d4153a374
2023-03-01 16:51:25 +09:00
Takashi Kajinami 626681f04d CentOS: Install barbican-retry service
RDO now provides the package to launch the barbican-retry service[1].
This change ensures the package and the service are configured by
the corresponding class.

[1] https://review.rdoproject.org/r/c/openstack/barbican-distgit/+/40434

Change-Id: I134feadb75b397bc159a8fe9e3dbc87915339785
2023-02-26 15:14:03 +09:00
Zuul 0480d0a292 Merge "apache: Clean up deprecated public_* parameters" 2023-01-24 11:48:47 +00:00
Takashi Kajinami acd9bf3373 Expose policy_default_rule
The option has been managed by the underlying puppet-oslo module but
has not been configurable. This introduces the parameter to customize
the option.

Change-Id: I7eb5ab771da3b6e2c446f4d8e83394a544fd147d
2023-01-23 14:27:53 +09:00
Takashi Kajinami 5b17af21a7 apache: Clean up deprecated public_* parameters
These were deprecated during the previous cycle so can be removed now.

Change-Id: I4e2e29d98803015b50c0f11678645cd5166e7d3c
2023-01-23 10:16:58 +09:00
Takashi Kajinami 9c6f3af402 api: Remove deprecated ssl parameters
These parameters were deprecated during the previous cycle[1] because
these are not actually used by barbican.

[1] 109ea49acb

Change-Id: I6471ed0fe696f2c6455150adc63c9c896037e404
2023-01-06 13:06:17 +09:00
Takashi Kajinami a79ac82ef2 Remove deprecated client_package_ensure
The parameter has had no effect for several cycles and was formally
deprecated during the previous cycle[1].

[1] 6c60f0d67e

Change-Id: Ib94130cf8215e3a832e4d44645ce90a2450627d2
2023-01-06 13:04:51 +09:00
Takashi Kajinami eb2b84ea8f Fix inconsistent parameter/resource names of wsgi::apache
The barbican::wsgi::apache class names a few parameters and resources
differently from the other modules. To make its interface and
implementation consistent with the other implementations, this renames
these inconsistent names. The old parameter names are kept but will be
removed in a future release.

Change-Id: I49ca51e4ea7a2404dfdbd0c88ce39339750da4f6
2022-08-26 15:46:37 +09:00
Takashi Kajinami 5b21717a19 Use standard parameter description format for wsgi::apache
Currently parameter description of the <module>::wsgi::apache classes
are formatted differently in individual modules, and this is making
the maintenance effort quite difficult.

This change updates the description format following the srandard one
we are globally using in our modules to reduce undesired differences
between modules.

Change-Id: Ifac421c3a74bf600e8b0e596a8449e5f25cda90b
2022-08-26 15:06:50 +09:00
Takashi Kajinami 38981908d8 Add Apache WSGI logging parameters for pipe/syslog
Add parameters for advanced logging configurations in Apache to
support piped logging and support for syslog (via mod_syslog
available in Apache >= 2.5.0)

Co-Authored-By: Andy Botting <andy@andybotting.com>
Change-Id: I77f1d65b1f6085fdb1205de9654a8d6d2da496f5
2022-08-26 15:00:26 +09:00
Takashi Kajinami 5d4084a951 Remove the temporal logic to fix barbican_api pipeline
The old wrong value should be fixed when the deployment is updated to
stable/yoga, and the logic is no longer used in stable/zed and later.

Related-Bug: #1946378
Change-Id: I699847c127e5890857446585ededc9d860b0dc78
2022-08-20 12:10:13 +09:00
Takashi Kajinami 577a44a522 Adapt to new type validation in puppetlabs-apache
The puppetlabs-apache module is enforcing more strict data type
validation[1].

This change updates the default values to adapt to that change.

[1] f41251e336

Closes-Bug: #1983300
Depends-on: https://review.opendev.org/851652
Change-Id: I9573f53e24dcf0666e4649189ccd8fcab0dbcc26
2022-08-02 16:56:24 +09:00
Zuul 50d44acc7c Merge "Clean up baribcan::api::retry_scheduler_* parameters" 2022-08-01 09:11:37 +00:00
Zuul b50eb0a28a Merge "Remove support for [p11_crypto_plugin] token_label" 2022-08-01 08:46:43 +00:00
Takashi Kajinami 72299ab60d Expose headers option of apache::vhost
The headers option in apache::vhost is required in some case, for
example when adding the X-XSS-Protection header. This change allows
customizing the option for the api vhost.

This change also adds support for request_headers so that both request
headers and response headers can customized.

Change-Id: I0e78f2183ffe14c310ee5c5632c203258c8c85cd
2022-06-30 11:11:50 +09:00
Takashi Kajinami f606fd1ca3 Remove support for [p11_crypto_plugin] token_label
... because it was deprecated during Wallaby cycle[1].

[1] 4403fe7247

Change-Id: Ia9b89d92256f51d5a48a19849715335f6856e839
2022-06-23 12:41:44 +09:00
Takashi Kajinami 237c4b2fb0 Clean up baribcan::api::retry_scheduler_* parameters
... because these were deprecated during Yoga cycle[1].

[1] 0d4580b27d

Change-Id: I781d06e3ba9c9b9ab7fd8360095cdb67917f016c
2022-06-23 12:36:32 +09:00
Rajesh Tailor 3b1ecbed5c Fix some typos in parameter descriptions
Change-Id: I634698c222da7e5f570ac3bd2cdee924457791bd
2022-06-17 16:38:08 +05:30
Takashi Kajinami 109ea49acb api: Deprecate unused ssl parameters
These parameters are used by oslo.service library but Barbican does not
provide wsgi servce based on the library.

Change-Id: Ie035ec4a4dbce089e9911e11f91c2c013998192b
2022-05-19 14:47:45 +09:00
Zuul 3af0df5bb4 Merge "Remove non-existing bind_host/port" 2022-05-11 10:22:21 +00:00
Takashi Kajinami 043774f389 Remove non-existing bind_host/port
The bind_host parameter and the bind_port parameter are not implemented
in current Barbican. This change removes these ineffective parameters
from barbican.conf.

Change-Id: I7758a6e852795c5410e6dab023ce612f44ee27fd
2022-05-09 09:48:46 +09:00
Zuul fdda2d13a4 Merge "apache+mod_wsgi: Disable SSL by default" 2022-05-08 13:38:33 +00:00
Takashi Kajinami 6e8df9739a apache+mod_wsgi: Disable SSL by default
During the previous cycle, a warning message was added to inform users
of this change.

Now the default value is updated so that SSL is disabled by default.

Change-Id: I72cf30d418b99ba06c4d5738544acb1930d4806f
2022-05-06 20:41:43 +09:00