Commit Graph

12 Commits

Author SHA1 Message Date
Emilien Macchi ae2c5f7939 Use puppet-openstack_spec_helper for Rakefile & spec_helper_acceptance
Use common code in puppet-openstack_spec_helper in Rakefile and
spec_helper_acceptance.

Change-Id: I4107e22dfaa023ec3a062f276bc846567eb3acf8
2016-01-18 09:11:13 -05:00
Emilien Macchi 403316c2f4 Checkout openstack-integration from master
Since stable/liberty was created, let's now checkout master to prepare
the next release (Mitaka).

Change-Id: I38ca2182c0d2ca2fb7d06988911457b1374c9f62
2015-11-26 10:44:59 +01:00
Emilien Macchi 8bc29454c1 release: prepare 7.0.0 (liberty)
This patch prepares this Puppet module to be released in 7.x series (Liberty)
with 7.0.0.

Change-Id: I4d892d41a8d7c8ed1f1a00712afced944c821f92
2015-11-25 10:43:51 +01:00
Gael Chamoulaud 5fbf51147b Remove class_parameter_defaults puppet-lint check
Change-Id: Ib1a514aa20d6aadbb6c7f0456487d285f3d03abc
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
2015-11-12 12:28:02 +01:00
Emilien Macchi dfa1e8c0af Try to use zuul-cloner to prepare fixtures
In OpenStack Infra, we would like to run Puppet unit tests that
sometimes depends on other Puppet OpenStack modules.
Example: a patch in puppet-openstacklib that needs to be tested in puppet-nova.

This patch modifies the Rakefile to:
* clean spec_prep and spec_clean Rake tasks
* use openstack/puppet-openstack-integration/install_modules_unit.sh script
  to clone modules.
* do not use .fixtures.yaml file to clone modules and rely on
  zuul-cloner or git.
* Add openstack/ in gitignore so we never commit the
  puppet-openstack-integration repository (can happen when spec_clean
  did not run but you want to submit the patch anyway)
* Allow to run a custom Puppetfile if PUPPETFILE env is exported. It
  will allow people to test the module with the dependencies they like,
  feature we had with .fixtures.yaml.

Also add 'r10k' to Gemfile.

That way, we will be able to use zuul dependencies and run tests accross
modules like we do with functional testing.

Change-Id: I8b884ef477bbc031da6bd3955ed308679e0380f6
2015-10-08 14:46:03 -07:00
Sebastien Badia 93575b1639 Initial msync run for all Puppet OpenStack modules
This patch is the initial modulesync run, it impact:

* gitignore: just a sync between projects
* gemfile:
  - update and allow to setup facter version and gem source
  - split beaker gems with a dedicated group
  - switch to rspec-puppet 2.2.0
* rakefile:
  - use the new syntax for lint configuration
  - add a acceptance target
* acceptance:
  - sync nodesets
* spec: added rspec coverage report

Change-Id: I34e999a752667d5f85266bc64059d9740ccbc367
2015-08-06 18:43:19 +00:00
Sebastien Badia 565c78cc7f Add Puppet 4.x lint checks
This changes the puppet-lint requirement to 1.1.x, so that we can use
puppet-lint plugins.  Most of these plugins are for 4.x compat, but some
just catch common errors.

This commit also remove custom metadata rake task (this task is now
provided by puppetlabs_spec_helper).

Conflicts:
	Gemfile

Change-Id: I22369948db6a2f8ddab9b8c93c3a047ff2e229ca
2015-03-11 09:03:59 +01:00
Sebastien Badia 94825922a0 Added metadata lint and puppet-syntax gems
metadata-json-lint is a little tool to check the validity of
Puppet metatdata.json files.

puppet-syntax tool check the validity of templates,manifests and hiera
files (the goal here is to replace manual checks in the gate by a
standard? check `rake syntax`).

Change-Id: I60b9cdfe27eeb8a8f5ad3a238dd847ed3096cb6b
2014-11-02 17:08:36 +00:00
Mike Dorman a4f20d069e Stringify $evaluation_interval for validate_re call
Under Puppet 3.7.x, calls to validate_re fail if the parameter is not
strictly a string.  This change creates a string from
$evaluation_interval when passing to validate_re, so the call will
pass regardless of if the parameter to the class is specified as
string or an integer.

Change-Id: I17b82977f21483acf134837a66c5ecebe346cfdf
Closes-Bug: 1371235
2014-09-23 11:33:53 -07:00
Mathieu Gagné ffde8588fd Fail puppet-lint on warnings
Puppet-lint will now fail if there is any warnings.

Change-Id: I49e181bdfd0b27a61bf7242accd352a3625eaf93
2013-08-28 13:26:34 -04:00
Mathieu Gagné 9b901a5db9 Disable 80chars/class_parameter_defaults checks
* Disable warnings for "line has more than 80 characters"
* Disable warnings for "parameterised class parameter without a default value"

We do not wish to track warnings for such violations.

Change-Id: I4a00f219682a83f051c92b5e885e778b9422fdbf
2013-08-12 17:47:54 -04:00
emilienm ff053ee175 First Commit 2012-12-07 09:43:55 +01:00