openstack
/
puppet-ceph
Code Issues Proposed changes
694 Commits 1 Branch 24 Tags 10 MiB
Commit Graph

9 Commits

Author SHA1 Message Date
Takashi Kajinami 4db054a27a Add back unit tests with Puppet 5 + CentOS 8 Stream 
This module still supports Puppet 5. This change adds back unit test
coverage with Puppet 5.

Depends-on: https://review.opendev.org/854061
Change-Id: I757d5c2f1c2af1c548d8ce6fba324c6f42826910
 2022-08-28 13:33:27 +09:00
Takashi Kajinami 5c3065db78 Fix unit test failure with recent puppetlabs-inifile 
Depends-on: https://review.opendev.org/816117
Change-Id: I03ed7c12682e94a555855e5e2c6ec98b78f9ce38
 2021-11-26 01:03:48 +09:00
Guilherme Maluf 28c4efee3d Set lowercase for ceph_config values 
Capitalized values of True and False are conflicting with systemd
scripts

This commit set all values to lowercase

Fixes: Bug #1697476

Change-Id: Ibd01a7a850e7593fabd676b8b0c0af2b77101a2a
 2017-06-12 14:57:05 -03:00
Brandon Weeks a9f20b38f9 Fixes circular argument reference in Ruby >=2.2 
Change-Id: I114611a228b8499a86dff48726fba32b8ad06e99
 2016-02-09 12:50:58 -08:00
Denis Egorenko 1ddbb0e96b Replace all StackForge names to OpenStack 
spec_helpers didn't change because keystone module (>=5.1.0 <6.0.0)
is not present in openstack/keystone - only >= 6.0.0 and it will
not working for puppet-ceph acceptance tests, because they are running
with Juno code.

Change-Id: Ibf7c55cac755432fb4901587693363cea4c27f42
 2015-11-09 21:22:24 +03:00
Gael Chamoulaud a3c12f05d8 Convert rspec tests to rspec 3.x 
This patch fixes and converts:
- Expectations on block
  * 'r.stderr.should be_empty' into 'expect(r.stderr).to be_empty'
- Standard expectations
  * 'obj.should matcher' into 'expect(obj).to matcher'
- One-liner expectations
  * 'it { should matcher }' into 'it { is_expected.to matcher }'
  * 'it { should_not matcher }' into 'it { is_expected.to_not matcher }'
- Operator matchers
  * '1.should == 1' into 'expect(1).to eq(1)'

Change-Id: I8f0666f15387874a1aa579e08a1e9571dd71098f
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
 2015-03-31 13:39:35 +02:00
Sebastien Badia cf6478490e spec: updates for rspec-puppet 2.x and rspec 3.x 
This patch aim to update our specs test in order to work with the new
rspec-puppet release 2.0.0, in the mean time, we update rspec syntax
in order to be prepared for rspec 3.x move.

In details:

  * Convert 'should' keyword to 'is_expected.to' (prepare rspec 3.x)
  * Upgrade and pin rspec-puppet from 1.0.1 to 2.0.0
  * Clean Gemfile (remove over-specificication of runtime deps of puppetlabs_spec_helper)

Change-Id: I512ffe4ac12763ec5a4bea935001088bad231cc1
 2015-02-27 13:41:44 +00:00
David Gurtner 8e0346d0ee Adapt tests to work with recently changed inifile 
In the recent release 1.1.1 of puppet inifile type the exists? call
has been changed to return booleans instead of nil / object

This changes the dependant unit test to mirror this change.

Change-Id: I768948250b3269dffa766d05ddd03d2ea20bcdd3
Closes-Bug: #1340319
 2014-07-10 19:47:22 +02:00
Andrew Woodward 0383a1aea2 Add ceph_config ini helper 
* add a ini_file helper as ceph_config.
* set the seperator as ' = ' in order to be the same as ceph-deploy
* add path param so that seperator can be easily tested.
** also allows for users to change the default path if desired.
* add test case to prove spacing around seperator.
* add simple test case to ensure type works.

Closes-bug: #1243852
Change-Id: I0f3bb41d75d48d8af3b5b7cfb7768c4d3de2c002
 2013-10-25 10:22:01 -07:00