openstack
/
puppet-designate
Code Issues Proposed changes

acceptance: Remove dirty fix for empty values (fixed in inifile module) 

Fixed by Mike in [MODULES-1599] : If a previously blank/empty value
is changed to a non-empty value, the value is put on a new line.

Link: https://tickets.puppetlabs.com/browse/MODULES-1599

Partial-bug: #1465780
Change-Id: Ib4ef48857a212f3a7aa2f465a9d391160ee9b45b
Depends-On: I9fcd5823b70dacbe1e41737f05d52a175481d57d
This commit is contained in:
Sebastien Badia 2015-06-24 10:41:27 +02:00
parent e202f75c97
commit 37644e946f
2 changed files with 1 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
metadata.json
View File

@ -31,7 +31,7 @@
],
"description": "Installs and configures OpenStack Designate (DNS Services).",
"dependencies": [
{ "name": "puppetlabs/inifile", "version_requirement": ">=1.0.0 <2.0.0" },
{ "name": "puppetlabs/inifile", "version_requirement": ">=1.4.0 <2.0.0" },
{ "name": "openstack/keystone", "version_requirement": ">=6.0.0 <7.0.0" },
{ "name": "puppetlabs/stdlib", "version_requirement": ">=4.0.0 <5.0.0" },
{ "name": "theforeman/dns", "version_requirement": ">=1.4.0 <4.0.0" },

19
spec/acceptance/basic_designate_spec.rb
View File

@ -5,22 +5,6 @@ describe 'basic designate' do
context 'default parameters' do
it 'should work with no errors' do
ppp= <<-EOS
case $::osfamily {
'Debian': {
Exec { logoutput => 'on_failure' }
package { ['debconf-utils','debconf']: ensure => installed, } ->
exec { 'fix_empty_rabbit_password':
command => '/bin/echo "designate-common designate/rabbit_password password password" | /usr/bin/debconf-set-selections',
unless => '/usr/bin/debconf-get-selections | grep "designate/rabbit_password"',
}
exec { 'fix_empty_keystone_password':
command => '/bin/echo "designate-common designate/admin-password password password" | /usr/bin/debconf-set-selections',
unless => '/usr/bin/debconf-get-selections | grep "designate/admin-password"',
}
}
}
EOS
pp= <<-EOS
Exec { logoutput => 'on_failure' }
@ -129,9 +113,6 @@ describe 'basic designate' do
}
EOS
# TODO : A fix on inifile must be filed, if the value is an empty string, the inifile provider
# configure the value with a newline.https://paste.debian.net/238471/
apply_manifest(ppp, :catch_failures => true)
# Run it once, idempotency does not work
# this is what we have each time we run puppet after first time:
# http://paste.openstack.org/show/2ebHALkNguNsE0804Oev/