the validate_legacy function is marked for deprecation in
v9.0.0 from puppetlabs-stdlib.
Note that this change looses validation about pool ids. Alternatively
we can define a new data type to keep the validation, but these defined
types for pool-manager were already deprecated and useless and will be
removed in a near future release so we avoid that redundant step.
Change-Id: I85d7058bf379c6aa0e787b2f806f14aebf0693d3
This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.
Change-Id: I703a2a64ce15ea6adf7cf233e635baf3ad963d31
According to Designate architecture documentation,
only the designate-central and mdns services require database access.
This change removes the designate::db class for generic service and
include the designate::db class for services that need it instead.
Change-Id: I696745e2d57aade6cbb0fe89e334fddf1beaafdb
The latest version of puppet now reports these as catalog failures so
this change removes the unnecessary Package and Service references
since those are already handled by designate::deps.
Change-Id: I3e4d1ab3d8efe3bfd0755c4f2524a2fe193a0896
Closes-Bug: #1702964
The parameter name used to enforce package state is inconsistent across
manifests and modules. I settle on package_ensure since it's already
widely used.
Change-Id: I9868f954a032a0014b9304526daf5476b0922c5d
Closes-Bug: #1668732
This adds defined anchor points for external modules to hook into the
software install, config and service dependency chain. This allows
external modules to manage software installation (virtualenv,
containers, etc) and service management (pacemaker) without needing rely
on resources that may change or be renamed.
Change-Id: If9fa188b7dca47e6724a737d66e34c0c85668c36
This patch introduces designate::generic_service which is already
exists in other modules to manage designate packages and services.
Change-Id: Ic05539fbbcfb88ed95f35d5eb5ca95b7f7141ed1
Close-Bug: #1486860
Takashi Kajinami