the validate_legacy function is marked for deprecation in
v9.0.0 from puppetlabs-stdlib.
Note that this change looses validation about pool ids. Alternatively
we can define a new data type to keep the validation, but these defined
types for pool-manager were already deprecated and useless and will be
removed in a near future release so we avoid that redundant step.
Change-Id: I85d7058bf379c6aa0e787b2f806f14aebf0693d3
This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.
Change-Id: I703a2a64ce15ea6adf7cf233e635baf3ad963d31
The agent framework and drivers have been deprecated in Designate
during Antelope cycle. See the dependent change for further details.
Depends-on: https://review.opendev.org/872716
Change-Id: Id0fc93fde98fafc4dc79a38982dd5ca844a4b049
... because it is not required and inheriting designate::params is
enough. Reducing scope of inheritance allows us to decouple individual
classes.
Change-Id: Iacb44a1d485c475bcb3a0be053c8ed7a60399866
These parameters were deprecated and renamed during the previous cycle
because of the confusing behavior which we can hardly guess from their
names[1].
[1] b7cfb61a6d
Change-Id: I93aba377d20da0733f17199707197d4e31a1606f
... because it was deprecated during Wallaby cycle[1]. This also
removes some remaining implementations used for PowerDNS 3 driver
support.
[1] 5ce240bc4d
Change-Id: I611f6333d5d0f648ab07698fafead5558ba8ccd0
Rename confusing service_ensure parameter.
Based on:
https://review.opendev.org/c/openstack/puppet-designate/+/773372
Added manage service parameter to worker.pp, so it will have the same
service management functionality as the rest of the services.
Change-Id: Ibe58d1395ee0b79af7535714ef5c9d2b26b52780
The parameter name used to enforce package state is inconsistent across
manifests and modules. I settle on package_ensure since it's already
widely used.
Change-Id: I9868f954a032a0014b9304526daf5476b0922c5d
Closes-Bug: #1668732
This adds defined anchor points for external modules to hook into the
software install, config and service dependency chain. This allows
external modules to manage software installation (virtualenv,
containers, etc) and service management (pacemaker) without needing rely
on resources that may change or be renamed.
Change-Id: If9fa188b7dca47e6724a737d66e34c0c85668c36
This patch introduces designate::generic_service which is already
exists in other modules to manage designate packages and services.
Change-Id: Ic05539fbbcfb88ed95f35d5eb5ca95b7f7141ed1
Close-Bug: #1486860
This adds defined anchor points for external modules to hook into the
software install, config and service dependency chain. This allows
external modules to manage software installation (virtualenv,
containers, etc) and service management (pacemaker) without needing rely
on resources that may change or be renamed.
Change-Id: I2b5707a0fe3dd72a56bbf1d840b4197bfa3012db
Some users wish to override the default package provider by their own.
Tag all packages with the 'openstack' to allow mass resource attributes
override using resource collectors.
Closes-bug: #1391209
Change-Id: Idcd296c754c4c66efcbdd1672c8367ce3539b268
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
The $service_ensure and $enabled parameter ordering is inconsistent
across classes and doesn't match the order of the documentation (which
is consistent).
Change-Id: Ib221c0042f5d50b10e339c53265d2a188308f11b
This changes the puppet-lint requirement to 1.1.x, so that we can use
puppet-lint plugins. Most of these plugins are for 4.x compat, but some
just catch common errors.
Change-Id: I3b16baf063746024cb8dc89a931dae2f604258f6
This makes all package names and package ensure values customizable as
parameters. This is helpful for people who are not using vendor
provided packaging. This also normalizes the package ensure value to be
'present' in all case.
Change-Id: Iee186f753b2800e59addd3f38591675fd5af35ad
* Fix designate package name require, openstack-designate is the final
package name, designate-common name is override by params class.
* Remove designate-common dependency on central/sink/api services.
* Fix designate::api/keystone_user default user.
Change-Id: I441565d39ba5d425c6b93db071237a85f1eb4b1f
Takashi Kajinami