Commit Graph

52 Commits

Author SHA1 Message Date
Takashi Kajinami da507fc631 Refactor resource dependencies
This refactors resource dependencies to improve the following points.

 - Avoid unnecessary dependencies across services. For example aodh
   service does not require cinder db.

 - Restart only api service when config files like paste.ini, which
   are used only be api service is changed.

Change-Id: If2cbbc392bd54d906c7a4f51f1c7cfca69463aaf
2024-03-01 13:12:01 +09:00
Takashi Kajinami 90c4b48640 Add support for sizelimit middleware option
The sizelimit middleware was added to pipelines defined by the default
api-paste.ini file [1]. This adds support for the parameter of
the sizelimit middleware.

[1] c0a5572814e96f90d3d4b9ea0f10d35d88f5cd68

Change-Id: Ic3659225f4445c8b33e05157af76af4d11b45194
2023-10-18 22:21:05 +00:00
Takashi Kajinami 8ed0bcb867 replace validate_legacy with proper data types
the validate_legacy function is marked for deprecation in
v9.0.0 from puppetlabs-stdlib.

Note that this change looses validation about pool ids. Alternatively
we can define a new data type to keep the validation, but these defined
types for pool-manager were already deprecated and useless and will be
removed in a near future release so we avoid that redundant step.

Change-Id: I85d7058bf379c6aa0e787b2f806f14aebf0693d3
2023-06-19 17:27:32 +09:00
Takashi Kajinami 5e89485f5d Add strict validation about boolean parameters
This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.

Change-Id: I703a2a64ce15ea6adf7cf233e635baf3ad963d31
2023-03-03 04:37:27 +00:00
Takashi Kajinami dd44ce031e Replace legacy facts and use fact hash
... because the latest lint no longer allows usage of legacy facts and
top scope fact.

Change-Id: Ica6edbc7077c0bb2021cc737f44f3ced84cd5f83
2023-03-01 16:49:01 +09:00
Takashi Kajinami d9634ff74a Remove cleanup of [service:api] max_header_line
... because the logic was added during the previous cycle[1] and
the option should be removed when a deployment is upgraded to Zed.

[1] f39567e17b

Change-Id: Iecc650fe94846a2f643ff2bf0b613026a1fb6570
2022-11-27 01:36:47 +09:00
Zuul 5d9b0ede4e Merge "Enable policy settings in designate-api" 2022-08-01 08:43:09 +00:00
Takashi Kajinami 20d78340cf Fix wrong variable used to determine designate api service
Closes-Bug: #1982794
Change-Id: I9140547a2f2a8d6fd8999394333c7d29fdd9cde0
2022-07-26 01:41:33 +00:00
Takashi Kajinami 7ff495ca7d Enable policy settings in designate-api
This change makes designate::policy included by the api class
automatically to enable oslo.policy settings automatically in
the designate service.

Closes-Bug: #1980698
Change-Id: Ided1306c3c7154861c7c55257ea2bdd35fa6b370
2022-07-05 08:31:12 +09:00
Rajesh Tailor d425d2ed73 Fix typos in parameter descriptions and tests
Change-Id: I23cf4500b147770f0863a2e73c94f4bbff22d37f
2022-06-17 18:40:22 +05:30
Takashi Kajinami f39567e17b Fix ineffective max_header_line
The [service:api] max_header_line parameter has had no effect since
Train and it was effectively replaced by the [DEFAULT] max_header_line
parameter provided by oslo.service.

This updates the parameter definition accordingly.

Closes-Bug: #1967825
Change-Id: Ia969cc31b380950a87c0be0b911cc214b4219d82
2022-05-17 11:25:44 +09:00
Takashi Kajinami da4b2f7030 Allow verifying project id of quota definitions
This change introduces some parameters to enable verification of
the given project id while updating quota definitions.

Change-Id: If45d66fa2f0bc13a77fa95ba2995ae0118f79ac6
2022-03-22 14:44:39 +09:00
Brent Eagles 1288b062e8 Add Designate API WSGI support
Add support for running the Designate API under WSGI with Apache.

Change-Id: I2fc87d6a4a166779e34210a377c99b313a0f1b97
2021-11-02 22:57:36 +09:00
Takashi Kajinami 10e6949f8d Remove the deprecated manage_service parameter
These parameters were deprecated and renamed during the previous cycle
because of the confusing behavior which we can hardly guess from their
names[1].

[1] b7cfb61a6d

Change-Id: I93aba377d20da0733f17199707197d4e31a1606f
2021-10-15 09:15:55 +09:00
Jacob Aharon b7cfb61a6d Standardize the manage service parameter
Rename confusing service_ensure parameter.
Based on:
https://review.opendev.org/c/openstack/puppet-designate/+/773372

Added manage service parameter to worker.pp, so it will have the same
service management functionality as the rest of the services.

Change-Id: Ibe58d1395ee0b79af7535714ef5c9d2b26b52780
2021-07-30 22:38:01 +09:00
Takashi Kajinami 2950b5d77a Allow list values for enabled_extensions_admin/v2
The following parameters are defined as "ListOpt"s which accept
comma-separated lists.
 service:api/enabled_extensions_admin
 service:api/enabled_extensions_v2

This change makes sure that list values are converted to string
properly to accept list values in the corresponding designate::api
parameters.

Change-Id: I6c18016bf33791e953f708b0f6abf772a434d74f
2021-07-19 10:57:09 +09:00
Takashi Kajinami 5c7d7e6d58 Add support for oslo_middleware/enable_proxy_headers_parsing
Change-Id: I6b57a4ea107a59896e39d07146e90bdef65b4d08
2021-07-14 21:00:23 +09:00
Takashi Kajinami a1f2605c4e Remove leftover of v1 api support
This change removes the enable_extentions_v1 parameter which was left
when support for v1 api was removed[1].

[1] a5d78457d6

Change-Id: I1f5ce5c70af4636c1176029bf76ffdfc83300871
2021-07-13 00:49:46 +09:00
Takashi Kajinami 4820eaa913 Rename confusing service_ensure parameter
The service_ensure parameter is supposed to accept service status and
ensure that service is in the given status, but in designate::api class
the parameter has been used wrongly.

This change renames the parameter to clearly show that the parameter
defines whether the service is managed or not.

Change-Id: I0984f74c5f6c863464be6599252d38cf1d321aa2
2021-02-01 22:10:45 +09:00
Takashi Kajinami a5d78457d6 Fix leftovers about removed v1 API
Designate has already removed its v1 API, so we should deprecate
and remove all parameters for it.
This change also fixes the outdated default value for keystone endpoint
url, which still includes '/v1'.

Change-Id: I645af15a9825ad000fc951d6c8334e715e645c8a
2020-12-15 20:26:36 +09:00
Takashi Kajinami c794aa6e64 Remove v1 api support
... because it was deprecated long ago in puppet-designate, and actual
implementation was already removed from designate[1].

[1] c318106c01b2b3976049f2c3ba0c8502a874242b

Change-Id: I121e06e5586d574aa63e4fd0b6553d414e227caf
2020-05-06 14:58:27 +09:00
Tobias Urdin b7f73b35c5 Convert all class usage to relative names
Change-Id: Iae69aff79cc231336b14d65305fff9c64cbd27e0
2019-12-08 23:04:25 +01:00
Tobias Urdin 25f07ee1e1 Remove deprecated parameters
Removes deprecated parameters that has been
deprecated for one cycle or more.

Change-Id: I01e33221ef4f2c3afd5277dbc3f1787feee31f37
2018-05-22 12:18:55 +02:00
Thomas Herve 34e606c795 Use os_workers when applicable
This uses os_workers as default for every workers config setting of the
various services.

Change-Id: I828f7fd8000d8e386b4d794ba8bf308599aa5491
2017-11-28 09:39:26 +01:00
ZhongShengping e837bed3ff Inconsistent package_ensure parameter name
The parameter name used to enforce package state is inconsistent across
manifests and modules. I settle on package_ensure since it's already
widely used.

Change-Id: I9868f954a032a0014b9304526daf5476b0922c5d
Closes-Bug: #1668732
2017-03-08 17:54:18 +08:00
Enrique Garcia Pablos b1d6d9e1ef New parameters for service::api section
Change-Id: I18bde9968517c1f35af26a930e6e14a2dd98dd22
Closes-Bug: 1654208
2017-01-13 12:21:25 +01:00
Enrique Garcia Pablos cd30cfaf01 Set default values for parameters in designate::api class
Change-Id: Ie8bf890f5914d418bfbee4a58aaf1d831de15507
Closes-Bug: 1654388
2017-01-06 18:22:25 +01:00
Enrique Garcia 116c3c319b Add parameters: workers,threads,enable_host_header and max_header_line into designate::api class
Change-Id: Ief499951902ddc699a2053858f60bea3543989ec
Closes-Bug: 1523746
2017-01-05 18:00:30 +01:00
ZhongShengping 1e95f32a6f Add hooks for external install & svc management
This adds defined anchor points for external modules to hook into the
software install, config and service dependency chain.  This allows
external modules to manage software installation (virtualenv,
containers, etc) and service management (pacemaker) without needing rely
on resources that may change or be renamed.

Change-Id: If9fa188b7dca47e6724a737d66e34c0c85668c36
2016-12-01 08:44:02 +08:00
ZhongShengping 9da7cb373d Deprecate host and port options
The "api_host" and "api_port" options from group "service:api" have been deprecated
in favor of the listen option setting.

Change-Id: I1011e890adeb36e6908af7c183f74161d442a777
2016-11-29 09:41:54 +08:00
Iury Gregory Melo Ferreira 05d0fc5ce4 Remove old authtoken options
Since we are in ocata lets remove all old parameters in api
to configure the keystone_authtoken section

Change-Id: Idd1bc92b6a68e93911042784d9edb366f85547a6
2016-11-05 16:20:37 -03:00
Alex Schultz d9b8080925 Update keystone authtoken configuration pattern
This change updates our previous implementation of the keystone
authtoken setting to use the new designate::keystone::authtoken class to
do the configuration for the api.

Change-Id: Ib2a1d20d4e29353fc139835ce1c010a801506b9c
Closes-Bug: #1604463
2016-08-10 00:04:15 -03:00
Alex Schultz e18e6eb355 Configure keystone authtoken options
Update designate::api to leverage keystone::resource::authtoken to
configure the keystone middleware. This patch also allows designate to
be able to leverage Keystone v3.

Some deprecations:
- designate::api::keystone_tenant is deprecated in favor of
  designate::api::project_name.
- designate::api::keystone_user is deprecated in favor of
  designate::api::username.
- designate::api::keystone_password is deprecated in favor of
  designate::api::password.
- designate::api::keystone_host, designate::api::keystone_port,
  designate::api::keystone_protocol are deprecated in favor of
  designate::api::auth_uri and designate::api_auth_url.
- designate::api::keystone_memcached_servers is deprecated in favor of
  designate::api::memcached_servers.

The patch is backward compatible.

Change-Id: I2cb4076b3e8679adac2722871f8391e750e8b4b0
Closes-Bug: #1604463
2016-07-21 14:12:47 -06:00
Arnoud de Jonge 3d6363085b Added parameters api_base_uri and enable_api_admin
Added enable_api_admin to enable the (experimental) Admin API.
Added api_base_uri to set the base uri used in responses

Change-Id: I8f385fc3f97ba818954a614f9e8d767099f19057
2016-02-02 10:07:23 +00:00
Jenkins 17851d5401 Merge "Add related parameters to designate::api" 2016-01-25 22:46:44 +00:00
Jenkins 59f2c49cee Merge "Make keystone memcached servers configurable" 2016-01-25 18:51:19 +00:00
Andrew Spiers 37097b2328 Make keystone memcached servers configurable
Like other openstack services, designate can use memcached to cache keystone
tokens.

Change-Id: I0b21ae47aee0b94ab672610be23d4bafde3c1d68
2016-01-22 06:52:14 +00:00
Xingchao Yu 681250724c Remove pick for managing package name.
Change-Id: I861b7bfab076def6106df1a64e6479684f96a448
2016-01-14 04:10:23 +08:00
Xiaohua Yuan 24bf0619b5 Add related parameters to designate::api
This patch is aim to add the following params in to designate::api
    - api_host
    - api_port

Change-Id: I876e153aadecc44b82d3ed003212a7a23256a4ab
closes-Bug: #1523746
2016-01-11 16:51:48 -08:00
Xingchao Yu 2dd7a9a0ee Use generic_service to manage services
This patch introduces designate::generic_service which is already
exists in other modules to manage designate packages and services.

Change-Id: Ic05539fbbcfb88ed95f35d5eb5ca95b7f7141ed1
Close-Bug: #1486860
2015-08-21 18:19:04 +08:00
Clayton O'Neill 5a37cc8127 Add hooks for external install & svc management
This adds defined anchor points for external modules to hook into the
software install, config and service dependency chain.  This allows
external modules to manage software installation (virtualenv,
containers, etc) and service management (pacemaker) without needing rely
on resources that may change or be renamed.

Change-Id: I2b5707a0fe3dd72a56bbf1d840b4197bfa3012db
2015-07-17 14:25:04 -04:00
Gael Chamoulaud 572482ab24 Tag all Designate packages
Some users wish to override the default package provider by their own.

Tag all packages with the 'openstack' to allow mass resource attributes
override using resource collectors.

Closes-bug: #1391209

Change-Id: Idcd296c754c4c66efcbdd1672c8367ce3539b268
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
2015-03-31 10:32:19 +02:00
Clayton O'Neill 2dfe3c7fec Qualify designate Class requires
Change-Id: I2f07f24fff2b895077dc2200c675ed1546b5a8ba
2015-02-26 18:33:14 +00:00
Clayton O'Neill 4ce3c0558b Add Puppet 4.x lint checks
This changes the puppet-lint requirement to 1.1.x, so that we can use
puppet-lint plugins.  Most of these plugins are for 4.x compat, but some
just catch common errors.

Change-Id: I3b16baf063746024cb8dc89a931dae2f604258f6
2015-02-17 14:53:22 +00:00
Clayton O'Neill 2861be7d21 Make all package name and ensure customizable
This makes all package names and package ensure values customizable as
parameters.  This is helpful for people who are not using vendor
provided packaging.  This also normalizes the package ensure value to be
'present' in all case.

Change-Id: Iee186f753b2800e59addd3f38591675fd5af35ad
2015-02-15 16:07:53 +00:00
Sebastien Badia 1ecba59a87 documentation: Update readme and puppetdoc documentation
Change-Id: I97ea6e3b4e7c4ac8b407dd3b6d39fd54ffae70fe
2015-01-12 11:07:01 +00:00
Sebastien Badia d229b0f2bd Introduce Debian OS support, various fixes
* Fix designate package name require, openstack-designate is the final
  package name, designate-common name is override by params class.
* Remove designate-common dependency on central/sink/api services.
* Fix designate::api/keystone_user default user.

Change-Id: I441565d39ba5d425c6b93db071237a85f1eb4b1f
2014-11-02 17:42:04 +01:00
Sebastien Badia 3caedea97a Hide secrets from puppet logs
Currently secrets like rabbit_password or admin_password are laked

puppet logs when changed. This commit changes designate_*_config and
designate_*_ini types adding a new parameter that triggers obfuscation
the values in puppet logs.

Change-Id: I54e7c0bb27e46928db1a7f0125783c02d00d0e69
Closes-Bug: #1328448
2014-07-22 13:22:01 +00:00
Xingchao Yu a9f740a70c update options in designate::api 2013-10-18 15:04:04 +08:00
Xingchao Yu 9f9bd60b71 add servce_ensure option 2013-09-26 23:37:12 +08:00