the validate_legacy function is marked for deprecation in
v9.0.0 from puppetlabs-stdlib.
Note that this change looses validation about pool ids. Alternatively
we can define a new data type to keep the validation, but these defined
types for pool-manager were already deprecated and useless and will be
removed in a near future release so we avoid that redundant step.
Change-Id: I85d7058bf379c6aa0e787b2f806f14aebf0693d3
This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.
Change-Id: I703a2a64ce15ea6adf7cf233e635baf3ad963d31
The managed_resource_tenant_id default is currently set
to 12345 which is invalid and will cause issues in designate.
We should use service default instead so that it gets the
designate.conf default value (which is a valid UUID).
Change-Id: Ice64a6d244f8b463382d91bcc7f0600816abacd2
... because it is not required and inheriting designate::params is
enough. Reducing scope of inheritance allows us to decouple individual
classes.
Change-Id: Iacb44a1d485c475bcb3a0be053c8ed7a60399866
These parameters were deprecated and renamed during the previous cycle
because of the confusing behavior which we can hardly guess from their
names[1].
[1] b7cfb61a6d
Change-Id: I93aba377d20da0733f17199707197d4e31a1606f
Rename confusing service_ensure parameter.
Based on:
https://review.opendev.org/c/openstack/puppet-designate/+/773372
Added manage service parameter to worker.pp, so it will have the same
service management functionality as the rest of the services.
Change-Id: Ibe58d1395ee0b79af7535714ef5c9d2b26b52780
The max_domain_name_len parameter was renamed to the max_zone_name_len
parameter[1]. This patch fixes the outdated parameter.
Note that this change directly invalidate the old parameter instead
of using its value to set the correct parameter, because the parameter
has been broken for a long time.
[1] c5949ccb2825128dc3f9c51cc333407246cf12a9
Change-Id: I47545c0d58e7c904ce51278c7bf9e26ab5af406b
According to Designate architecture documentation,
only the designate-central and mdns services require database access.
This change removes the designate::db class for generic service and
include the designate::db class for services that need it instead.
Change-Id: I696745e2d57aade6cbb0fe89e334fddf1beaafdb
The backend_driver option has been deprecated in Ocata.
we can remove it.
Change-Id: If24fb1b814c255d90391a6ee42167b36f5f156bf
Depends-On: I90b7fdb454249c9e0777371a357c545aac6f46fc
This patch adds workers, threads, default-pool-id options to the
central.pp as these options can be configured for designate-central.
Change-Id: I0635d5fd2ece7bca85fab772a055c999d6721c1a
Closes-Bug: #1539327
Co-Authored-By: Sharat Sharma <sharat.sharma@nectechnologies.in>
The parameter name used to enforce package state is inconsistent across
manifests and modules. I settle on package_ensure since it's already
widely used.
Change-Id: I9868f954a032a0014b9304526daf5476b0922c5d
Closes-Bug: #1668732
This adds defined anchor points for external modules to hook into the
software install, config and service dependency chain. This allows
external modules to manage software installation (virtualenv,
containers, etc) and service management (pacemaker) without needing rely
on resources that may change or be renamed.
Change-Id: If9fa188b7dca47e6724a737d66e34c0c85668c36
The previous default, 'None', would error out with oslo_config
expecting an integer value.
ERROR designate ConfigFileValueError:
Value for option min_ttl is not valid:
invalid literal for int() with base 10: 'None'
Change-Id: I056c7fff1607b6e7b9153ed7df4868900dc5ae44
This patch is aim to add the following params in to designate::central
- max_domain_name_len
- max_recordset_name_len
- min_ttl
Change-Id: I66b40c244addc849d87fabf87d4d394cba012e86
closes-Bug: #1482004
This patch introduces designate::generic_service which is already
exists in other modules to manage designate packages and services.
Change-Id: Ic05539fbbcfb88ed95f35d5eb5ca95b7f7141ed1
Close-Bug: #1486860
This patch aims to add the following params to
service::central section.
- managed_resource_email
- managed_resource_tenant_id
Change-Id: I341d0d99fb843f2053b07ef189b93cbf75303649
closes-Bug: #1482204
This adds defined anchor points for external modules to hook into the
software install, config and service dependency chain. This allows
external modules to manage software installation (virtualenv,
containers, etc) and service management (pacemaker) without needing rely
on resources that may change or be renamed.
Change-Id: I2b5707a0fe3dd72a56bbf1d840b4197bfa3012db
Some users wish to override the default package provider by their own.
Tag all packages with the 'openstack' to allow mass resource attributes
override using resource collectors.
Closes-bug: #1391209
Change-Id: Idcd296c754c4c66efcbdd1672c8367ce3539b268
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
The $service_ensure and $enabled parameter ordering is inconsistent
across classes and doesn't match the order of the documentation (which
is consistent).
Change-Id: Ib221c0042f5d50b10e339c53265d2a188308f11b
This changes the puppet-lint requirement to 1.1.x, so that we can use
puppet-lint plugins. Most of these plugins are for 4.x compat, but some
just catch common errors.
Change-Id: I3b16baf063746024cb8dc89a931dae2f604258f6
This makes all package names and package ensure values customizable as
parameters. This is helpful for people who are not using vendor
provided packaging. This also normalizes the package ensure value to be
'present' in all case.
Change-Id: Iee186f753b2800e59addd3f38591675fd5af35ad
* Fix designate package name require, openstack-designate is the final
package name, designate-common name is override by params class.
* Remove designate-common dependency on central/sink/api services.
* Fix designate::api/keystone_user default user.
Change-Id: I441565d39ba5d425c6b93db071237a85f1eb4b1f
Takashi Kajinami