Commit Graph

12 Commits

Author SHA1 Message Date
Takashi Kajinami 8ed0bcb867 replace validate_legacy with proper data types
the validate_legacy function is marked for deprecation in
v9.0.0 from puppetlabs-stdlib.

Note that this change looses validation about pool ids. Alternatively
we can define a new data type to keep the validation, but these defined
types for pool-manager were already deprecated and useless and will be
removed in a near future release so we avoid that redundant step.

Change-Id: I85d7058bf379c6aa0e787b2f806f14aebf0693d3
2023-06-19 17:27:32 +09:00
Takashi Kajinami 5e89485f5d Add strict validation about boolean parameters
This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.

Change-Id: I703a2a64ce15ea6adf7cf233e635baf3ad963d31
2023-03-03 04:37:27 +00:00
Takashi Kajinami dd44ce031e Replace legacy facts and use fact hash
... because the latest lint no longer allows usage of legacy facts and
top scope fact.

Change-Id: Ica6edbc7077c0bb2021cc737f44f3ced84cd5f83
2023-03-01 16:49:01 +09:00
Takashi Kajinami d4550c5b6e Remove deprecated designate::producer::backend_url
... because it was deprecated during Xena cycle[1] in favor of the new
designate::coordination class.

[1] 823d409fe8
Change-Id: I564ef6ec944c4b0f4a48fe99db2aade54e7f684c
2022-08-05 10:36:58 +09:00
Takashi Kajinami e586326e77 Stop inheriting the base designate class
... because it is not required and inheriting designate::params is
enough. Reducing scope of inheritance allows us to decouple individual
classes.

Change-Id: Iacb44a1d485c475bcb3a0be053c8ed7a60399866
2022-02-14 11:12:43 +09:00
Takashi Kajinami 10e6949f8d Remove the deprecated manage_service parameter
These parameters were deprecated and renamed during the previous cycle
because of the confusing behavior which we can hardly guess from their
names[1].

[1] b7cfb61a6d

Change-Id: I93aba377d20da0733f17199707197d4e31a1606f
2021-10-15 09:15:55 +09:00
Zuul c5b521ebc3 Merge "producer: Convert enabled_tasks to comma separated list" 2021-08-24 08:40:11 +00:00
Jacob Aharon b7cfb61a6d Standardize the manage service parameter
Rename confusing service_ensure parameter.
Based on:
https://review.opendev.org/c/openstack/puppet-designate/+/773372

Added manage service parameter to worker.pp, so it will have the same
service management functionality as the rest of the services.

Change-Id: Ibe58d1395ee0b79af7535714ef5c9d2b26b52780
2021-07-30 22:38:01 +09:00
Takashi Kajinami fc113562ab producer: Convert enabled_tasks to comma separated list
... because the parameter is ListOpt.

Change-Id: Ib23a9cd3586342ed69d960e43dcc2070ac1cad0d
2021-07-20 13:30:12 +09:00
Takashi Kajinami 823d409fe8 Use oslo::coordination to manage coordination parameters
This change replaces current implementation to manage coordination
parameters by the base class in puppet-oslo. With this change
the required backend package is installed according to the backend
driver used.

Depends-on: https://review.opendev.org/791628
Change-Id: I7e3a98a8b477df0580159ccc0e615cf63bae0e47
2021-07-06 17:04:07 +09:00
michaeltchapman ba9fa2ad2e Add backend coordination url option to producer
Producers that are deployed in an HA environment that do not have
a coordination url set will produce multiple copies of the same
thing and operate in standalone mode.

Change-Id: Idb5ecfd027728dc0c85ffac5ce08d475e6ea8cb6
2020-08-10 13:33:59 +10:00
Thomas Herve 8fad53f974 Add support for producer service
Designate now uses a service called producer in the more recent
architecture.

Change-Id: I1c9ed575b70611209299ed50c6ec80ed6d11da7e
2017-11-08 15:01:57 +01:00