The parameter descriptions says the value should be a positive integer
(or 0). Validate the given value to reject invalid values such as
strings or even negative values.
Change-Id: I63719129644e3723b86d0b63b78c36e151724473
This refactors resource dependencies to improve the following points.
- Avoid unnecessary dependencies across services. For example aodh
service does not require cinder db.
- Restart only api service when config files like paste.ini, which
are used only be api service is changed.
Change-Id: I6a4c65e81b97235d0ce8a142245927c92ab6e48d
... because this option was deprecated as part of deprecation of
glance-scrubber.
Depends-on: https://review.opendev.org/910042
Change-Id: I9862d999025dd63dcbac4f33faeaad4fa6c1ada9
Glance treats rados_connect_timeout=-1 differently now. Let's remove
the description about its old behavior and avoid documenting details
in the module parameter descriptions to reduce our future maintenance
effort.
Depends-on: https://review.opendev.org/894514
Change-Id: If4c711ca7b8c9a5167ee48e902811e8353a1fba0
This looses dependency using the new openstackclient tag, which
requires only packages actually related to openstack CLI.
Also, glanceclient is not required by glance itself so the support
package tag can be removed.
Depends-on: https://review.opendev.org/899594
Change-Id: I50f0775a2f20b9b4f3aca51840cb4ab48ab14120
This introduces the support for the weight option in each store which
is used to sort locations.
Depends-on: https://review.opendev.org/886811
Change-Id: Ia08ab9b396a9f7ba3ee1f41a81cb666e9a80ccde
The oslo.policy library has implementations to detect change in policy
rules and reload the new rules without service restart.
Change-Id: I83b2e24fe124b05673372cd832b034b4d3ccc853
The glance-cache.conf file is not used by glance-api, but it is used
by only CLI commands. So we don't have to restart the glance-api
service when this config file is modified.
Change-Id: I49d5fa3965af0faedd54b6cf21261b66516a3643
The glance-cache.conf is used by the glance-cache-prefetcher command
which requires access to backend store. Thus all store options should
be added to the glance-cache.conf file so that backend store can be
loaded properly.
Closes-Bug: #2034893
Change-Id: I8f0b2be8b138d267364f20ff81876902b225d29e
Using legacy backend class (eg glance::backend::file) with multi_store
set to false(default) has been broken, because of duplicate declaration
of [glance_store] default_store option.
This fixes that problem.
Change-Id: Ibb12bdb8333fc91e2dc95c2c2cc4de79f2c82cc1
This adds the order enforcement to make sure that openstackclient
package is installed before completing the service phase, so that
openstack CLI is available when neutron resources are created.
Change-Id: I190b28fe480eb659808b74f50e2eae6e499869de
The purge_config parameters only accept boolean values. This enforces
that using the typed parameters.
Change-Id: I68260f896eb4b94661685a2ebf76500b0cf409a6
The password parameter is not really optional. This makes it
a required parameter to give more sensible validation error.
Change-Id: I4fc9a34db162b6c85a5f4bcf50c3fb77b1b6640d
The default_store_real variable is not defined in some code paths and
that is causing the following error when Puppet 8 is used.
```
Evaluation Error: Unknown variable: 'default_store_real'.
```
Change-Id: I8220b646de922e44e08db49817b473789e2742f8
Setting an empty string('') to [paste_deploy] flavor results in
the exactly same behavior as removing the [paste_deploy] flavor option.
Thus we don't really need the special treatment for an empty string.
Change-Id: Ib50da09ac6fd2499fc922d5d0e1115cd600ecb69
the validate_legacy function is marked for deprecation in
v9.0.0 from puppetlabs-stdlib.
Note that this change removes the pattern validation about [DEFAULT]
pipeline. The existing pattern check is incomplete, because of
the following two reasons.
- the pattern does not guarantee that the requested pipeline is
really supported or not
- the pattern accepts a+b+c but the existing pipelines in glance
does not have any entries with this pattern
Change-Id: I156d9a3a30ba6c523a0b16a14bf8a1839b61fb78
... instead of using the actual package name. This helps users to
identify the resource name more easily.
Change-Id: Icc6a27685f3b3747b4e0562eb8066aa3cce5516c
This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.
Change-Id: Ie3fce5786d44be38fad176442a0a0f9b24faab77
When I implemented support for reserved store options[1], I somehow
overlooked the fact that some of the registered options are not really
used. This is mainly because glance does not use 'add' API of
the filesystem store but just write data directly into the store
directory.
This deprecates the ineffective options so that we can remove these
in a future release.
[1] d82df7aedd
Change-Id: Ifde7f70f4cf6a04e22e092a819e0c598079682ee
This introduces support for the new cinder_do_extend_attached option
which was added in the 2023.1 release. See the dependent change to find
more details.
Depends-on: https://review.opendev.org/868742
Change-Id: I4fbb2d275cf261286390765d9cd98112ca8adf0c
This parameter was deprecated during the previous cycle[1] and has had
no effect since then.
[1] 89857141d1
Change-Id: I21e59483cef2847b02783a13072745a9f434a318
Takashi Kajinami