This refactors resource dependencies to improve the following points.
- Avoid unnecessary dependencies across services. For example aodh
service does not require cinder db.
- Restart only api service when config files like paste.ini, which
are used only be api service is changed.
Change-Id: I6a4c65e81b97235d0ce8a142245927c92ab6e48d
This looses dependency using the new openstackclient tag, which
requires only packages actually related to openstack CLI.
Also, glanceclient is not required by glance itself so the support
package tag can be removed.
Depends-on: https://review.opendev.org/899594
Change-Id: I50f0775a2f20b9b4f3aca51840cb4ab48ab14120
Using credentials in keystone_authtoken options for glance_* resources
was deprecated some cycles ago[1].
[1] 17cc71c509
Change-Id: I57a2ecc763ccac52d9122afa86871ad74bca7450
Recent update in rspec-puppet removed some of the config interfaces for
old puppet versions[1]. This drops usage of these interfaces to resolve
the following error in unit tests.
```
An error occurred while loading ./spec/unit/provider/manila_spec.rb.
Failure/Error: c.manifest_dir = File.join(fixture_path, 'manifests')
NoMethodError:
undefined method `manifest_dir='...
```
This also removes explicit setting of mock module. The definition is
no longer required since we bumped puppetlabs_spec_helper to v 5.0.0.
[1] 316d95923c
Change-Id: I3077eed14d4e4e2e29cb947ec4ec1fa06abd6229
This introduces the support for the weight option in each store which
is used to sort locations.
Depends-on: https://review.opendev.org/886811
Change-Id: Ia08ab9b396a9f7ba3ee1f41a81cb666e9a80ccde
The glance-cache.conf is used by the glance-cache-prefetcher command
which requires access to backend store. Thus all store options should
be added to the glance-cache.conf file so that backend store can be
loaded properly.
Closes-Bug: #2034893
Change-Id: I8f0b2be8b138d267364f20ff81876902b225d29e
Setting an empty string('') to [paste_deploy] flavor results in
the exactly same behavior as removing the [paste_deploy] flavor option.
Thus we don't really need the special treatment for an empty string.
Change-Id: Ib50da09ac6fd2499fc922d5d0e1115cd600ecb69
the validate_legacy function is marked for deprecation in
v9.0.0 from puppetlabs-stdlib.
Note that this change removes the pattern validation about [DEFAULT]
pipeline. The existing pattern check is incomplete, because of
the following two reasons.
- the pattern does not guarantee that the requested pipeline is
really supported or not
- the pattern accepts a+b+c but the existing pipelines in glance
does not have any entries with this pattern
Change-Id: I156d9a3a30ba6c523a0b16a14bf8a1839b61fb78
... instead of using the actual package name. This helps users to
identify the resource name more easily.
Change-Id: Icc6a27685f3b3747b4e0562eb8066aa3cce5516c
This introduces support for the new cinder_do_extend_attached option
which was added in the 2023.1 release. See the dependent change to find
more details.
Depends-on: https://review.opendev.org/868742
Change-Id: I4fbb2d275cf261286390765d9cd98112ca8adf0c
puppetlabs_spec_helper recommends rspec-mocks instead of mocha[1] and
it uses rspec-mocks by default instead of mocha since v 5.0.0[2]
This is the prep work to adapt to that migration.
[1] https://github.com/puppetlabs/puppetlabs_spec_helper/#mock_with
[2] 493f0cbc1c
Closes-Bug: #2004135
Change-Id: I3c6ee8bb85efcb2169a0248ce11e750991799d63
The option has been managed by the underlying puppet-oslo module but
has not been configurable. This introduces the parameter to customize
the option.
Change-Id: I55a19eb7ed16f87f51ca472e658fc845b1a86dac
The rbd backend implementation of glance_store requires not only
python3-rbd but also python3-rados. In CentOS the python3-rados package
is installed as a dependency of python3-rbd, but in Debian and Ubuntu
that dependency is not defined and we should install python3-rados
explicitly.
This fixes the missing python3-rados package in Ubuntu, by using
the meta python3-ceph package which installs all python libraries.
Closes-Bug: #2002934
Change-Id: I620c607f09e98f1ce1d7ba34d1b797dbef8402ad
This makes sure the db purge cron job is properly configured in
acceptance tests. The job was enabled in the common manifest a while
ago by the dependent change.
Depends-on: https://review.opendev.org/792743
Change-Id: Ic83d6595cd23319e286719c2e7f766ea1aa3e4da
The current test case is validating behavior of the openstack CLI
rather than the deployment. Because we already test image creation by
the glance_image resource type, we can remove that redundant and
out-of-scope test.
Change-Id: I30ba37e5c72c6a918f0ee1f5d8ad275322f007f9
This change introduces an assertion to ensure the glance-api is
listening the correct tcp port (9292). Similar assertions are already
implemented in the other modules.
Change-Id: I9fe22af47e9e12905d731f6b0e4ead2c6864ce40
When running glance-api behind a proxy or load balancer that hides
glance behind an extended base URL, it is necessary to provide
information about the base URL to glance-api to ensure that clients
know where to pass subsequent requests.
Change-Id: I9bebee01c2580f0500a069f5ab57ac2a8c329389
The apache class is already included by the openstacklib::wsgi::apache
defined types and the apache::wsgi class and the apache::ssl class is
automatically included by the apache::vhost defined type.
This removes the redundant inclusion of these classes.
Change-Id: If132d46ec1929ed56e16a9b615010ea0535282ba
These were deprecated during Xena cycle in favor of the new separate
classes to customize key manager[1].
[1] bc7651fa5f
Change-Id: Id3395fd58cbdd7e686a08c8369cd38c3e322628b
The puppetlabs-apache module is enforcing more strict data type
validation[1].
This change updates the default values to adapt to that change.
[1] f41251e336
Closes-Bug: #1983300
Depends-on: https://review.opendev.org/851652
Change-Id: I652d82c449371bf4df73d1384ddf1633a76224e9