This patch removes support for glance-registry service, because it has
been removed from glance [1].
[1] https://review.opendev.org/#/c/738671/
Change-Id: Id05f736dbbddaff2cb90aa6678c777b9a0318e40
This patch introduces cinder_os_region_name parameters for cinder
backend, because global os_region_name parameter was replaced by this
cinder specific parameters[1].
[1] 410747822c9433c83fd4aec547d3e4c288502f90
Change-Id: I4a7c9ac97ff2f1c04b651ecbc89b3cb1c583f2f9
This changes all the puppet 3 validate_* functions
to use the validate_legacy function.
The validate_legacy function has been available since
about three years but require Puppet >= 4.4.0 and since
there is Puppet 4.10.12 as latest we should assume people
are running a fairly new Puppet 4 version.
This is the first step to then remove all validate function
calls and use proper types for parameter as described in spec [1].
[1] https://review.openstack.org/#/c/568929/
Change-Id: Ib21fef57404d63579743270be4080d248a4ca8cc
The sync_db option has been deprecated in Ocata[1].
we can remove it.
[1]https://review.openstack.org/#/c/408161/
Change-Id: I35898b6c298c864a76e05b41322fc61d75244c0d
Glance Registry will at some point be removed from puppet-glance once
API v1 is totally remove from Glance tree.
Some people using 100% v2 API don't need Glance Registry, so they don't
have to run glance::registry class. Though they need the db_sync, so
this patch aims to move the db_sync parameter from glance::registry to
glance::api.
The parameter in glance::registry is deprecated and will be removed in a
future release. Now people should use glance::api::sync_db.
Change-Id: Ib554edb13386845198140c87b0a9b931500656d2
- Allow to configure Glance API v1 with enable_v1_api boolean.
If set to True, the glance::registry::enable_v1_registry also needs to
be set to True. Note that if you set these values to True, Glance will
send some deprecation warnings.
This option is separated from enable_v2_api, and both API versions can be
deployed together.
- Allow to configure Glance API v2 with enable_v2_api boolean.
This option is separated from enable_v1_api, and both API versions can be
deployed together.
Change-Id: Ibbb8b970971c899ae94097042465f605fe55f748
Since we are in ocata lets remove all old parameters in api
to configure the keystone_authtoken section
Change-Id: I4dc0bd544f91fd52ad437b4c3ebbd16a43895726
This patch changes the default worker count from ::processorcount to the
new ::os_workers fact. ::os_workers is based on the number of processors
(currently cpu/4) but is capped at a maximum of 8 worker processors.
This is a much more reasonable default in general and prevents excessive
resource consumption on systems with a large number of CPUs.
Change-Id: I3808177027a880c88f075cdbef0aba2a56fb26bc
Use glance::<service>::authtoken to configure keystone_authtoken
section in glance configs, with all parameters required
to configure keystonemiddleware.
Also changed auth_type to auth_strategy, because auth_type is
related to keystone authentication.
Change-Id: I722a1e41b2cee0b3040c37f07adfd13c33edaa5c
Closes-bug: #1604463
This adds defined anchor points for external modules to hook into the
software install, config and service dependency chain. This allows
external modules to manage software installation (virtualenv,
containers, etc) and service management (pacemaker) without needing rely
on resources that may change or be renamed.
Change-Id: If683fbd098e701a3c4da91941cf818b18b41b209
Option "verbose" from group "DEFAULT" is deprecated for removal.
The parameter has no effect.
-Deprecated verbose for logging and init
-Remove verbose in README
-Remove verbose from tests.
If this option is not set explicitly, there is no such warning
Change-Id: I7e58412fe26962337845b3cb9d67679bac0709d8
It appears that the resources decleration, that made purge_config work,
was accidently removed. I am adding it back so that the option will work
again. This resources decleration was setting the purge flag with a
boolean, so that inifile would handle it.
* Adding in spec tests
Change-Id: Ib80b89932c60aeab0d252109d2e79ac0f209596b
This patch removes File resources which should be delivered by packaging
tools. These resources (files, directories, modes, users, and group
attributes) could be in conflict with different OS packaging systems
which isn't a desired result.
Co-Authored-By: Ivan Berezovskiy <iberezovskiy@mirantis.com>
Closes-Bug: #1458915
Change-Id: I02fe8cc99dcd56e16ac66136a0da244a1eeb630b
This change updates the glance tests to use rspec-puppet-facts to test
multiple operating systems.
Change-Id: I75fd8970ba8335cb4ffa09a7d600415056e9f889
This commit [1] introduced a weird warning that send a warning by
default.
This patch:
* sets os_region_name to the default value in OpenStack using
$::os_service_default
* drops the warning
[1] Id7a6894e5bb12fc7697dfe23e5f9d4a44a719086
Change-Id: Id4e94e18bad19c605bb82d3fb16b867493dab4c3
Another modules already implement a <component>::db class that
is not implemented in Glance. This commit aims to apply here the same logic.
Change-Id: Icd65a3303ccd512d5e34598d3e3a78bc924f8128
This change adds possibility to use the os_service_default
fact for configuration options that default to '<SERVICE DEFAULT>'.
this change is done by analogy with cinder
commit 667e6c0850672dbbf99381eb92468f95e5591913
Change-Id: Ie5c8909bcc1c9a6a7a9ab1b59eec4637751ffd74
Currently logging configuration is splitted in two distinct classes, the init.pp
and the logging.pp classes.
This review aims to centralize all logging related parameters in a single class,
the logging.pp one.
The impacted parameters are :
* use_syslog
* use_stderr
* log_facility
* verbose
* debug
* log_dir
* log_file
This change remains backward compatible with what is currently in place
Change-Id: Ic268104fd9bc77bc142fc635285b0459f3d4314f
In order to standardize the way dbsync are run across our modules,
we create a new class glance::db::sync.
This class will be included if sync_db is enabled.
By making this transition the glance::db::sync class
can be returned by the ENC.
A use case would be in an highly available environment, with 3 galera
nodes, include glance::registry on every node with sync_db set to false
and have the ENC return glance::db::sync just for one node.
Change-Id: I16c8bc411bd34f720513a5d4c94e82b07105af20
When logging is already set up, it can be useful to disable this option
to avoid logs duplication (collected by Upstart, for example)
Change-Id: I1787191d9a512fdd3c3f79d6fadda110c5e41d54
Closes-bug: #1482564
In order to be able to take an action after all the packages of the
module have been installed/updated or all the services have been
started/restarted, we set a 'glance-package' and 'glance-service'
tag for each package and service of this module.
At the moment, there is a generic openstack tag that is not specific
enough if one wants to take action upon a single module change.
Use case :
If an action needs to be taken after all the packages have been
installed or updated : Package <| tag == 'glance-package' |> -> X
Change-Id: If43e27e80500deebf6b758b11541d3d6f50cb129
We want db_sync to run even though manage_service or enabled
can be set to False.
Change-Id: Ic3472ce6a6e704a2fa035df6e1c8866b8ea6bcbc
Closes-Bug: 1452278
Due to a patch in RDO packaging, puppet-glance is broken for RHEL platforms.
This reverts commit 5f15e05704.
Change-Id: I7ba146714d1b0e8d461c556eff5a9f8c4ad9627f
Starting in Kilo, Red Hat-based platforms are using separate
glance-api and glance-registry packages (for an example, see
http://trunk.rdoproject.org/f21/current/).
Change-Id: I3ad476846d7dec3ca612e5b0d20b21b8577f4af0
Other components offer the option to decide whether or not to run the db sync
command. Glance was missing this feature. This commit add this feature for
Glance.
Change-Id: Iec31d724370a40aee56ead5839ef47ceacf7223d
This patch aim to update our specs test in order to work with the rspec-puppet release
2.0.0, in the mean time, we update rspec syntax in order to be prepared
for rspec 3.x move.
In details:
* Use shared_examples "a Puppet::Error" for puppet::error tests
* Convert 'should' keyword to 'is_expected.to' (prepare rspec 3.x)
* Fix spec tests for rspec-puppet 2.0.0
* Upgrade and pin rspec-puppet from 1.0.1 to 2.0.0
* Clean Gemfile (remove over-specificication of runtime deps of puppetlabs_spec_helper)
Change-Id: Ibd0333dc3c0959e846edfbad51fb48e8dfb8fbe9
Card: https://trello.com/c/eHXc1Ryd/4-investigate-the-necessary-change-to-be-rspec-puppet-2-0-0-compliant
Without the correct --config-file parameter the glance-manage db_sync
command does not sync the correct database. The default without any
configuration is to use an SQLite Database at /var/lib/glance/glancedb.
This is most probably not what's intended.
Change-Id: I61f4e47ad082b48ee83b17df70e9856f640083b1
This patch adds the ability to set a new identity_uri parameter.
It also deprecates the old auth_host, auth_port, auth_protocol,
and auth_admin_prefix parameters. Logic is in place so that
users of the deprecated settings should have a smooth upgrade
process and get deprecation warnings until they adopt the
new settings.
Change-Id: Id72991da18dd1f467a7683f8f450e157da64f969
Closes-Bug: #1391235
The main glance class allows overriding the package_ensure setting
from the default of 'present', but on Debian based systems
glance-registry is a separate package. This package updates the
glance::registry class to allow overriding the package ensure there
also.
Change-Id: I6182836728102e827f9d5a3beef4964dd6e8d7f9
Takashi Kajinami